From: Andi Shyti <andi@smida.it>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v17 7/7] test: perf_pmu: use the gem_engine_topology library
Date: Fri, 5 Apr 2019 12:09:28 +0300 [thread overview]
Message-ID: <20190405090928.GF18786@jack.zhora.eu> (raw)
In-Reply-To: <0649f1fc-bb78-9c42-d17a-7ecb6b2c821d@linux.intel.com>
> > @@ -177,7 +172,7 @@ static igt_spin_t * __spin_poll(int fd, uint32_t ctx, unsigned long flags)
> > .engine = flags,
> > };
> > - if (gem_can_store_dword(fd, flags))
> > + if (gem_class_can_store_dword(fd, flags))
>
> flags is not a class here but either legacy eb flags or engine map index.
>
> I think you can refactor so this function (and the chain of callers) takes a
> pointer to intel_execution_engine2 and then use class and flags as needed.
It looks more logical, indeed to have the engine in it, but at
some point you call
spin = spin_sync(gem_fd, 0, I915_EXEC_RENDER);
In the previous patchset I had created two branches of spin_sync,
one that took flags and one that took intel_execution_engine2,
but it looked to much of useless code.
In this case I could either create a dummy engine to make things
work with intel_execution_engine2 or just use flags and minimise
the changes.
In this patch there is still the problem of 4/5 subtests failing,
but we can discuss that offline and, as you noticed, the
igt_dummyload commit lost in the meanders of rebasing.
Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-05 9:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:07 [igt-dev] [PATCH v17 0/7] new engine discovery interface Andi Shyti
2019-04-05 1:07 ` [igt-dev] [PATCH v17 1/7] lib/igt_gt: remove unnecessary argument Andi Shyti
2019-04-05 14:43 ` Caz Yokoyama
2019-04-05 1:07 ` [igt-dev] [PATCH v17 2/7] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-04-05 7:59 ` Chris Wilson
2019-04-05 8:35 ` Andi Shyti
2019-04-05 1:07 ` [igt-dev] [PATCH v17 3/7] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-05 1:07 ` [igt-dev] [PATCH v17 4/7] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-05 8:42 ` Tvrtko Ursulin
2019-04-05 9:00 ` Andi Shyti
2019-04-05 9:16 ` Tvrtko Ursulin
2019-04-05 1:07 ` [igt-dev] [PATCH v17 5/7] lib: igt_gt: add eb flags to class helper Andi Shyti
2019-04-05 1:07 ` [igt-dev] [PATCH v17 6/7] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-05 1:07 ` [igt-dev] [PATCH v17 7/7] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-05 8:50 ` Tvrtko Ursulin
2019-04-05 9:09 ` Andi Shyti [this message]
2019-04-05 9:22 ` Tvrtko Ursulin
2019-04-05 2:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [v17,1/7] lib/igt_gt: remove unnecessary argument Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405090928.GF18786@jack.zhora.eu \
--to=andi@smida.it \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox