Re: [igt-dev] [PATCH i-g-t 15/15] intel_gpu_top: Add gt specific values to header in interactive mode

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 06/05/2023 01:55, Umesh Nerlige Ramappa wrote:
> If -p options is specified in INTERACTIVE mode, show the gt specific
> values.
> 
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>   tools/intel_gpu_top.c | 33 +++++++++++++++++++++++++--------
>   1 file changed, 25 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 0acc81e9e..7018499c7 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1988,14 +1988,31 @@ print_header(const struct igt_device_card *card,
>   	lines = print_header_token(" @ ", lines, con_w, con_h, &rem,
>   				   "%s", card->card);
>   
> -	lines = print_header_token(" - ", lines, con_w, con_h, &rem,
> -				   "%s/%s MHz",
> -				   freq_items[1].buf,
> -				   freq_items[0].buf);
> -
> -	lines = print_header_token("; ", lines, con_w, con_h, &rem,
> -				   "%s%% RC6",
> -				   rc6_items[0].buf);
> +	if (class_view || engines->num_gts == 1) {
> +		lines = print_header_token(" - ", lines, con_w, con_h, &rem,
> +					   "%s/%s MHz",
> +					   freq_items[1].buf,
> +					   freq_items[0].buf);
> +
> +		lines = print_header_token("; ", lines, con_w, con_h, &rem,
> +					   "%s%% RC6",
> +					   rc6_items[0].buf);
> +	} else {
> +		for (i = 0; i < engines->num_gts; i++) {
> +			const char *cont = !i ? " - ": "; ";
> +
> +			lines = print_header_token(cont, lines, con_w, con_h, &rem,
> +						   "%s/%s MHz(gt%d)",
> +						   freq_items_gt[i * 4 + 1].buf,
> +						   freq_items_gt[i * 4 + 0].buf,
> +						   i);
> +
> +			lines = print_header_token("; ", lines, con_w, con_h, &rem,
> +						   "%s%% RC6(gt%d)",
> +						   rc6_items_gt[i * 3].buf,
> +						   i);
> +		}
> +	}
>   
>   	if (engines->r_gpu.present) {
>   		lines = print_header_token("; ", lines, con_w, con_h,

Series was a super easy read, thanks for that! Pretty much r-b for the 
lot from me but I would just like to visualize how the output looks like 
first. Would you mind pasting some examples for all the modes?

Regards,

Tvrtko