Re: [igt-dev] [PATCH i-g-t 13/15] intel_gpu_top: Show gt specific values if requested

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 06/05/2023 01:55, Umesh Nerlige Ramappa wrote:
> On multi-gt platforms, the aggregate values are displayed as default. If
> user passes -p (physical) option for these platforms, show gt specific
> counter values.
> 
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>   tools/intel_gpu_top.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 4d0aeee16..8bcca67a6 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1944,6 +1944,26 @@ print_header(const struct igt_device_card *card,
>   		&power_group,
>   		NULL
>   	};
> +	int i;
> +
> +	/*
> +	 * If we have multi-gt and the user has specified -p options, show gt
> +	 * specific values.
> +	 */
> +	if (!class_view && engines->num_gts > 1) {
> +		int j = 0;
> +
> +		groups[j++] = &period_group;
> +		for (i = 0; i < engines->num_gts; i++)
> +			groups[j++] = &freq_group_gt[i];
> +
> +		groups[j++] = &irq_group;
> +		for (i = 0; i < engines->num_gts; i++)
> +			groups[j++] = &rc6_group_gt[i];
> +
> +		groups[j++] = &power_group;
> +		groups[j++] = NULL;
> +	}
>   
>   	if (output_mode != JSON)
>   		memmove(&groups[0], &groups[1],

This works fine. One day we can think about how to make the setup one 
time. Like have two pre-configured groups arrays and then just select 
the right one here based on class_view.

Regards,

Tvrtko