From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: [igt-dev] [PATCH i-g-t 14/15] intel_gpu_top: Reduce one level of indent
Date: Fri, 5 May 2023 17:55:27 -0700 [thread overview]
Message-ID: <20230506005528.1890922-15-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230506005528.1890922-1-umesh.nerlige.ramappa@intel.com>
Prepare to display gt specific items in INTERACTIVE mode with the -p
option. An additional for loop will push code more towards right, so
reduce one level of indent.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tools/intel_gpu_top.c | 74 ++++++++++++++++++++++---------------------
1 file changed, 38 insertions(+), 36 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 8bcca67a6..0acc81e9e 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1944,7 +1944,7 @@ print_header(const struct igt_device_card *card,
&power_group,
NULL
};
- int i;
+ int rem, i;
/*
* If we have multi-gt and the user has specified -p options, show gt
@@ -1971,51 +1971,53 @@ print_header(const struct igt_device_card *card,
*consumed = print_groups(groups);
- if (output_mode == INTERACTIVE) {
- int rem = con_w;
+ if (output_mode != INTERACTIVE)
+ return lines;
- printf("\033[H\033[J");
+ /* INTERACTIVE MODE */
+ rem = con_w;
- lines = print_header_token(NULL, lines, con_w, con_h, &rem,
- "intel-gpu-top:");
+ printf("\033[H\033[J");
- lines = print_header_token(" ", lines, con_w, con_h, &rem,
- "%s", codename);
+ lines = print_header_token(NULL, lines, con_w, con_h, &rem,
+ "intel-gpu-top:");
- lines = print_header_token(" @ ", lines, con_w, con_h, &rem,
- "%s", card->card);
+ lines = print_header_token(" ", lines, con_w, con_h, &rem,
+ "%s", codename);
- lines = print_header_token(" - ", lines, con_w, con_h, &rem,
- "%s/%s MHz",
- freq_items[1].buf,
- freq_items[0].buf);
+ lines = print_header_token(" @ ", lines, con_w, con_h, &rem,
+ "%s", card->card);
- lines = print_header_token("; ", lines, con_w, con_h, &rem,
- "%s%% RC6",
- rc6_items[0].buf);
+ lines = print_header_token(" - ", lines, con_w, con_h, &rem,
+ "%s/%s MHz",
+ freq_items[1].buf,
+ freq_items[0].buf);
- if (engines->r_gpu.present) {
- lines = print_header_token("; ", lines, con_w, con_h,
- &rem,
- "%s/%s W",
- power_items[0].buf,
- power_items[1].buf);
- }
+ lines = print_header_token("; ", lines, con_w, con_h, &rem,
+ "%s%% RC6",
+ rc6_items[0].buf);
- lines = print_header_token("; ", lines, con_w, con_h, &rem,
- "%s irqs/s",
- irq_items[0].buf);
+ if (engines->r_gpu.present) {
+ lines = print_header_token("; ", lines, con_w, con_h,
+ &rem,
+ "%s/%s W",
+ power_items[0].buf,
+ power_items[1].buf);
+ }
- if (lines++ < con_h)
- printf("\n");
+ lines = print_header_token("; ", lines, con_w, con_h, &rem,
+ "%s irqs/s",
+ irq_items[0].buf);
- if (lines++ < con_h) {
- if (header_msg) {
- printf(" >>> %s\n", header_msg);
- header_msg = NULL;
- } else {
- printf("\n");
- }
+ if (lines++ < con_h)
+ printf("\n");
+
+ if (lines++ < con_h) {
+ if (header_msg) {
+ printf(" >>> %s\n", header_msg);
+ header_msg = NULL;
+ } else {
+ printf("\n");
}
}
--
2.34.1
next prev parent reply other threads:[~2023-05-06 0:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 0:55 [igt-dev] [PATCH i-g-t 00/15] PMU: multi-tile support Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 01/15] perf_pmu: Support multi-tile in rc6 subtest Umesh Nerlige Ramappa
2023-05-12 2:28 ` Dixit, Ashutosh
2023-05-12 12:14 ` Tvrtko Ursulin
2023-05-13 0:08 ` Umesh Nerlige Ramappa
2023-05-13 0:43 ` Dixit, Ashutosh
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 02/15] perf_pmu: Two new rc6 subtests Umesh Nerlige Ramappa
2023-05-09 15:27 ` Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 03/15] perf_pmu: Support multi-tile in frequency subtest Umesh Nerlige Ramappa
2023-05-12 5:02 ` Dixit, Ashutosh
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 04/15] perf_pmu: Quiesce GPU if measuring idle busyness without spinner Umesh Nerlige Ramappa
2023-05-12 5:07 ` Dixit, Ashutosh
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 05/15] perf_pmu: Use correct pmu config for multi-tile Umesh Nerlige Ramappa
2023-05-09 15:28 ` Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 06/15] intel_gpu_top: Add an array of freq and rc6 counters Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 07/15] intel_gpu_top: Determine number of tiles Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 08/15] intel_gpu_top: Capture freq and rc6 counters from each gt Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 09/15] intel_gpu_top: Switch pmu_counter to use aggregated values Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 10/15] intel_gpu_top: Add definitions for gt-specific items and groups Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 11/15] intel_gpu_top: Bump up size of groups to accomodate multi-gt Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 12/15] intel_gpu_top: Increase visibility for class_view Umesh Nerlige Ramappa
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 13/15] intel_gpu_top: Show gt specific values if requested Umesh Nerlige Ramappa
2023-05-10 8:41 ` Tvrtko Ursulin
2023-05-06 0:55 ` Umesh Nerlige Ramappa [this message]
2023-05-10 8:43 ` [igt-dev] [PATCH i-g-t 14/15] intel_gpu_top: Reduce one level of indent Tvrtko Ursulin
2023-05-06 0:55 ` [igt-dev] [PATCH i-g-t 15/15] intel_gpu_top: Add gt specific values to header in interactive mode Umesh Nerlige Ramappa
2023-05-10 8:46 ` Tvrtko Ursulin
2023-05-10 22:14 ` Umesh Nerlige Ramappa
2023-05-11 7:50 ` Tvrtko Ursulin
2023-05-11 18:08 ` Umesh Nerlige Ramappa
2023-05-12 12:06 ` Tvrtko Ursulin
2023-05-06 1:27 ` [igt-dev] ✓ Fi.CI.BAT: success for PMU: multi-tile support Patchwork
2023-05-06 21:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-13 2:22 [igt-dev] [PATCH i-g-t 00/15] " Umesh Nerlige Ramappa
2023-05-13 2:22 ` [igt-dev] [PATCH i-g-t 14/15] intel_gpu_top: Reduce one level of indent Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506005528.1890922-15-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox