Re: [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev7) - Tvrtko Ursulin via igt-dev

From: Tvrtko Ursulin via igt-dev <igt-dev@lists.freedesktop.org>
To: igt-dev@lists.freedesktop.org, Andi Shyti <andi.shyti@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev7)
Date: Tue, 12 Feb 2019 08:43:24 +0000	[thread overview]
Message-ID: <079ee3ce-ece2-8a4d-fbe3-98a9037769af@linux.intel.com> (raw)
In-Reply-To: <20190207085840.GP4038@platvala-desk.ger.corp.intel.com>

On 07/02/2019 08:58, Petri Latvala wrote:
> On Wed, Feb 06, 2019 at 09:25:38AM +0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: new engine discovery interface (rev7)
>> URL   : https://patchwork.freedesktop.org/series/52699/
>> State : failure
>>
>> == Summary ==
>>
>> IGT patchset build failed on latest successful build
>> 592b854fead32c2b0dac7198edfb9a6bffd66932 tools/intel_watermark: Clean up the platform checks in the ilk+ code
>>
>>
>>
>> The output from the failed tests:
>>
>> 138/266 testcase check: gem_ctx_isolation       FAIL     0.36 s
>>
>> --- command ---
>> /home/cidrm/igt-gpu-tools/tests/igt_command_line.sh gem_ctx_isolation
>> --- stdout ---
>> tests/gem_ctx_isolation:
>>    Checking invalid option handling...
>>    Checking valid option handling...
>>    Checking subtest enumeration...
>> FAIL: tests/gem_ctx_isolation
>> --- stderr ---
>> Received signal SIGSEGV.
>> Stack trace:
>>   #0 [fatal_sig_handler+0xd5]
>>   #1 [killpg+0x40]
>>   #2 [__real_main687+0x810]
>>   #3 [main+0x44]
>>   #4 [__libc_start_main+0xe7]
>>   #5 [_start+0x2a]
>> -------
>>
>> 248/266 testcase check: perf_pmu                FAIL     0.21 s
>>
>> --- command ---
>> /home/cidrm/igt-gpu-tools/tests/igt_command_line.sh perf_pmu
>> --- stdout ---
>> tests/perf_pmu:
>>    Checking invalid option handling...
>>    Checking valid option handling...
>>    Checking subtest enumeration...
>> FAIL: tests/perf_pmu
>> --- stderr ---
>> Received signal SIGSEGV.
>> Stack trace:
>>   #0 [fatal_sig_handler+0xd5]
>>   #1 [killpg+0x40]
>>   #2 [__real_main1671+0xf1f]
>>   #3 [main+0x44]
>>   #4 [__libc_start_main+0xe7]
>>   #5 [_start+0x2a]
>> -------
>>
> 
> 
> These tests are constructing subtests for each known engine. Your
> engine loop changes make it not possible to enumerate any names
> statically, without accessing the driver.

Is generating subtest names without accessing the driver an absolute 
requirement?

This particular failure would be fixable if the engine list was 
initialized on the first call to __for_each_engine_class_instance, as 
called by the perf_pmu above. And the fixture block is already ran in 
test enumeration, where the driver is opened. I think a lot of tests are 
like this. So in this context a simple query ioctl on top doesn't sound bad.

But I also remember, and I think it was due bug tracking limitations, 
that in the past the desire was test enumeration is constant regardless 
of the execution platform.

I think it would be simpler if we didn't have to maintain a separate 
static list of all possible engines. To make that work we would need to 
detect the mode of execution (list vs execute) in the engine iterator as 
well. So gain, to me it sounds preferable that tests would be allowed to 
enumerate dynamically.

So question is can CI/bugtracking cope with that, and are we okay with 
doing a trivial ioctl from the for_each_engine_<something>.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev