Re: [igt-dev] [RFC PATCH v6 2/4] lib: implement new engine discovery interface

[Andi Shyti <andi.shyti@intel.com>]

Hi Chris,

Thanks for the review!

I think fixed everything, just a few questions on the following

> > @@ -1459,6 +1460,8 @@ void igt_require_gem(int fd)
> >         err = 0;
> >         if (ioctl(fd, DRM_IOCTL_I915_GEM_THROTTLE))
> >                 err = -errno;
> > +       else
> > +               gem_init_engine_list(fd);
> 
> igt_require_gem() maybe called multiple times per subtest.

I'm actually checking that with:

        if (intel_execution_engines2)
                return;

inside the gem_init_engine_list(). Shouldn't that be enough to
prevent multiple calls?

> Just gem_require_engine_list() ? Gives a good indicator which tests are
> converted and which not, and a reminder that we still need to test
> legacy ABIs in conjunction with the new era.

Can do that, but I thought that in the new era, when your and
Tvrtko's patch will get in, we will convert everything to the new
ABI's and this would remain an extra step (which BTW, wouldn't
prevent multiple calls either, as above).

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev