From: Petri Latvala via igt-dev <igt-dev@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev7)
Date: Fri, 15 Feb 2019 11:50:25 +0200 [thread overview]
Message-ID: <20190215095025.GU4038@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <079ee3ce-ece2-8a4d-fbe3-98a9037769af@linux.intel.com>
On Tue, Feb 12, 2019 at 08:43:24AM +0000, Tvrtko Ursulin wrote:
> Is generating subtest names without accessing the driver an absolute
> requirement?
Yes.
> This particular failure would be fixable if the engine list was initialized
> on the first call to __for_each_engine_class_instance, as called by the
> perf_pmu above. And the fixture block is already ran in test enumeration,
> where the driver is opened. I think a lot of tests are like this. So in this
> context a simple query ioctl on top doesn't sound bad.
Fixtures are not executed when enumerating tests.
> I think it would be simpler if we didn't have to maintain a separate static
> list of all possible engines. To make that work we would need to detect the
> mode of execution (list vs execute) in the engine iterator as well. So gain,
> to me it sounds preferable that tests would be allowed to enumerate
> dynamically.
Can the tests be refactored to have a subtest per engine _class_?
That's a static list, isn't it? Within the subtest they would loop
over instances of the class. Kind of like tests that loop over
connectors of $type.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-15 9:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 9:18 [igt-dev] [RFC PATCH v6 0/4] new engine discovery interface Andi Shyti
2019-02-06 9:18 ` [igt-dev] [RFC PATCH v6 1/4] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-02-06 9:18 ` [igt-dev] [RFC PATCH v6 2/4] lib: implement new engine discovery interface Andi Shyti
2019-02-06 9:31 ` Chris Wilson
2019-02-08 12:55 ` Andi Shyti
2019-02-08 13:03 ` Chris Wilson
2019-02-06 18:11 ` Antonio Argenziano
2019-02-08 11:03 ` Andi Shyti
2019-02-08 11:06 ` Chris Wilson
2019-02-06 9:18 ` [igt-dev] [RFC PATCH v6 3/4] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-02-06 9:33 ` Chris Wilson
2019-02-06 9:18 ` [igt-dev] [RFC PATCH v6 4/4] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti
2019-02-06 9:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev7) Patchwork
2019-02-07 8:58 ` Petri Latvala
2019-02-08 10:56 ` Andi Shyti
2019-02-12 8:43 ` Tvrtko Ursulin via igt-dev
2019-02-12 11:39 ` Arkadiusz Hiler via igt-dev
2019-02-12 11:56 ` Tvrtko Ursulin via igt-dev
2019-02-15 9:50 ` Petri Latvala via igt-dev [this message]
2019-02-25 13:22 ` Tvrtko Ursulin
2019-02-26 9:32 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215095025.GU4038@platvala-desk.ger.corp.intel.com \
--to=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox