public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps
@ 2019-10-01 17:49 Chris Wilson
  2019-10-01 19:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Chris Wilson @ 2019-10-01 17:49 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin

Having decided to close the GTT mmap of userptr objects loophole in the
kernel, we need to adjust the test suite to avoid tripping over GTT
mmaps when required.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/i915/gem_userptr_blits.c | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
index 3fad7d1b3..3f5edaeab 100644
--- a/tests/i915/gem_userptr_blits.c
+++ b/tests/i915/gem_userptr_blits.c
@@ -69,11 +69,33 @@
 
 static uint32_t userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
 
+static bool can_gtt_mmap;
+
 #define WIDTH 512
 #define HEIGHT 512
 
 static uint32_t linear[WIDTH*HEIGHT];
 
+static bool has_gtt_mmap(int i915)
+{
+	void *ptr, *map;
+	uint32_t handle;
+
+	igt_assert(posix_memalign(&ptr, PAGE_SIZE, PAGE_SIZE) == 0);
+
+	gem_userptr(i915, ptr, 4096, 0, 0, &handle);
+	igt_assert(handle != 0);
+
+	map = __gem_mmap__gtt(i915, handle, 4096, PROT_WRITE);
+	if (map)
+		munmap(map, 4096);
+
+	gem_close(i915, handle);
+	free(ptr);
+
+	return map != NULL;
+}
+
 static void gem_userptr_test_unsynchronized(void)
 {
 	userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
@@ -853,7 +875,7 @@ static void *umap(int fd, uint32_t handle)
 {
 	void *ptr;
 
-	if (gem_has_llc(fd)) {
+	if (can_gtt_mmap) {
 		ptr = gem_mmap__gtt(fd, handle, sizeof(linear),
 				    PROT_READ | PROT_WRITE);
 	} else {
@@ -884,7 +906,7 @@ check_bo(int fd1, uint32_t handle1, int is_userptr, int fd2, uint32_t handle2)
 	sigbus_start = (unsigned long)ptr2;
 	igt_assert(memcmp(ptr1, ptr2, sizeof(linear)) == 0);
 
-	if (gem_has_llc(fd1)) {
+	if (can_gtt_mmap) {
 		counter++;
 		memset(ptr1, counter, size);
 		memset(ptr2, counter, size);
@@ -971,7 +993,7 @@ static int test_dmabuf(void)
 	free_userptr_bo(fd1, handle);
 	close(fd1);
 
-	if (gem_has_llc(fd2)) {
+	if (can_gtt_mmap) {
 		struct sigaction sigact, orig_sigact;
 
 		memset(&sigact, 0, sizeof(sigact));
@@ -1225,7 +1247,7 @@ static void test_readonly_mmap(int i915)
 	original = g_compute_checksum_for_data(G_CHECKSUM_SHA1, pages, sz);
 
 	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_WRITE);
-	igt_assert(ptr == NULL);
+	igt_require(ptr != NULL);
 
 	ptr = gem_mmap__gtt(i915, handle, sz, PROT_READ);
 	gem_close(i915, handle);
@@ -1834,6 +1856,8 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
 		igt_require_gem(fd);
 		gem_require_blitter(fd);
 
+		can_gtt_mmap = has_gtt_mmap(fd) && gem_has_llc(fd);
+
 		size = sizeof(linear);
 
 		aperture_size = gem_aperture_size(fd);
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
@ 2019-10-01 19:21 ` Patchwork
  2019-10-02  5:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-01 19:21 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: i915/gem_userptr_blits: Check for allowed GTT mmaps
URL   : https://patchwork.freedesktop.org/series/67464/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6986 -> IGTPW_3523
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html

Known issues
------------

  Here are the changes found in IGTPW_3523 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-small-bo-tiledy:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [PASS][3] -> [DMESG-WARN][4] ([fdo#102614])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_linear_blits@basic:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u3/igt@gem_linear_blits@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/fi-icl-u3/igt@gem_linear_blits@basic.html

  * igt@i915_module_load@reload:
    - fi-icl-u3:          [DMESG-WARN][9] ([fdo#107724] / [fdo#111214]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u3/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/fi-icl-u3/igt@i915_module_load@reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
  [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600


Participating hosts (54 -> 47)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5208 -> IGTPW_3523

  CI-20190529: 20190529
  CI_DRM_6986: 9300459553e8c1032f10ec1953e1a375a99aba13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3523: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html
  IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
  2019-10-01 19:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-10-02  5:05 ` Patchwork
  2019-10-02  8:42 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-02  5:05 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: i915/gem_userptr_blits: Check for allowed GTT mmaps
URL   : https://patchwork.freedesktop.org/series/67464/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6986_full -> IGTPW_3523_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3523_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3523_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html

Known issues
------------

  Here are the changes found in IGTPW_3523_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#109276]) +12 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_exec_schedule@wide-bsd:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325]) +9 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb3/igt@gem_exec_schedule@wide-bsd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html

  * igt@gem_mmap_gtt@hang:
    - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#109385])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl8/igt@gem_mmap_gtt@hang.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl8/igt@gem_mmap_gtt@hang.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-hsw:          [PASS][7] -> [DMESG-WARN][8] ([fdo#111870])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw7/igt@gem_userptr_blits@dmabuf-sync.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-hsw5/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#109385] / [fdo#111870]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-iclb:         [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb3/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_userptr_blits@readonly-mmap-unsync:
    - shard-kbl:          [PASS][13] -> [SKIP][14] ([fdo#109271])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl3/igt@gem_userptr_blits@readonly-mmap-unsync.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-kbl3/igt@gem_userptr_blits@readonly-mmap-unsync.html
    - shard-apl:          [PASS][15] -> [SKIP][16] ([fdo#109271])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl3/igt@gem_userptr_blits@readonly-mmap-unsync.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl8/igt@gem_userptr_blits@readonly-mmap-unsync.html
    - shard-glk:          [PASS][17] -> [SKIP][18] ([fdo#109271])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk5/igt@gem_userptr_blits@readonly-mmap-unsync.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-glk8/igt@gem_userptr_blits@readonly-mmap-unsync.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-kbl:          [PASS][19] -> [DMESG-WARN][20] ([fdo#111870])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl1/igt@gem_userptr_blits@sync-unmap.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-kbl3/igt@gem_userptr_blits@sync-unmap.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-snb:          [PASS][21] -> [DMESG-WARN][22] ([fdo#111870]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-snb5/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@kms_color@pipe-b-gamma:
    - shard-snb:          [PASS][23] -> [SKIP][24] ([fdo#109271])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb6/igt@kms_color@pipe-b-gamma.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-snb7/igt@kms_color@pipe-b-gamma.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][25] -> [FAIL][26] ([fdo#102887])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@dpms-vs-vblank-race-interruptible:
    - shard-apl:          [PASS][27] -> [FAIL][28] ([fdo#111609])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl8/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103167]) +5 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb7/igt@kms_frontbuffer_tracking@basic.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb8/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][33] -> [FAIL][34] ([fdo#99912])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl6/igt@kms_setmode@basic.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl6/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +7 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  
#### Possible fixes ####

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][37] ([fdo#111325]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_request_retire@retire-vma-not-inactive:
    - shard-hsw:          [INCOMPLETE][39] ([fdo#103540]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw4/igt@gem_request_retire@retire-vma-not-inactive.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-hsw7/igt@gem_request_retire@retire-vma-not-inactive.html

  * igt@gem_userptr_blits@coherency-sync:
    - shard-hsw:          [DMESG-WARN][41] ([fdo#111870]) -> [PASS][42] +3 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw5/igt@gem_userptr_blits@coherency-sync.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-hsw6/igt@gem_userptr_blits@coherency-sync.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-kbl:          [DMESG-WARN][43] ([fdo#111870]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl3/igt@gem_userptr_blits@dmabuf-unsync.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-kbl2/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-apl:          [DMESG-WARN][45] ([fdo#109385] / [fdo#111870]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl3/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-snb:          [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
    - shard-iclb:         [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-snb:          [DMESG-WARN][51] ([fdo#110789] / [fdo#111870]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-glk:          [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54] +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk8/igt@gem_userptr_blits@sync-unmap-cycles.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-glk2/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][55] ([fdo#108566]) -> [PASS][56] +3 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@i915_suspend@sysfs-reader:
    - shard-kbl:          [INCOMPLETE][57] ([fdo#103665] / [fdo#108767]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@i915_suspend@sysfs-reader.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-kbl2/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
    - shard-hsw:          [DMESG-FAIL][59] ([fdo#102614]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw5/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-hsw4/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
    - shard-iclb:         [FAIL][61] ([fdo#103167]) -> [PASS][62] +3 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][63] ([fdo#109441]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [INCOMPLETE][65] ([fdo#103665]) -> [PASS][66] +1 similar issue
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [SKIP][67] ([fdo#109276]) -> [PASS][68] +13 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb3/igt@prime_busy@hang-bsd2.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb1/igt@prime_busy@hang-bsd2.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][69] ([fdo#109276]) -> [FAIL][70] ([fdo#111329])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_mocs_settings@mocs-reset-bsd2:
    - shard-iclb:         [FAIL][71] ([fdo#111330]) -> [SKIP][72] ([fdo#109276])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (16 -> 6)
------------------------------

  ERROR: It appears as if the changes made in IGTPW_3523_full prevented too many machines from booting.

  Missing    (10): shard-skl pig-hsw-4770r shard-tglb1 shard-tglb2 shard-tglb3 shard-tglb4 shard-tglb5 shard-tglb6 pig-glk-j5005 pig-skl-6260u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5208 -> IGTPW_3523
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_6986: 9300459553e8c1032f10ec1953e1a375a99aba13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3523: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html
  IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3523/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
  2019-10-01 19:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-10-02  5:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-10-02  8:42 ` Tvrtko Ursulin
  2019-10-02  8:47   ` Chris Wilson
  2019-10-02  8:50 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 9+ messages in thread
From: Tvrtko Ursulin @ 2019-10-02  8:42 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin


On 01/10/2019 18:49, Chris Wilson wrote:
> Having decided to close the GTT mmap of userptr objects loophole in the
> kernel, we need to adjust the test suite to avoid tripping over GTT
> mmaps when required.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   tests/i915/gem_userptr_blits.c | 32 ++++++++++++++++++++++++++++----
>   1 file changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index 3fad7d1b3..3f5edaeab 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -69,11 +69,33 @@
>   
>   static uint32_t userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
>   
> +static bool can_gtt_mmap;
> +
>   #define WIDTH 512
>   #define HEIGHT 512
>   
>   static uint32_t linear[WIDTH*HEIGHT];
>   
> +static bool has_gtt_mmap(int i915)
> +{
> +	void *ptr, *map;
> +	uint32_t handle;
> +
> +	igt_assert(posix_memalign(&ptr, PAGE_SIZE, PAGE_SIZE) == 0);
> +
> +	gem_userptr(i915, ptr, 4096, 0, 0, &handle);
> +	igt_assert(handle != 0);
> +
> +	map = __gem_mmap__gtt(i915, handle, 4096, PROT_WRITE);
> +	if (map)
> +		munmap(map, 4096);
> +
> +	gem_close(i915, handle);
> +	free(ptr);
> +
> +	return map != NULL;
> +}
> +
>   static void gem_userptr_test_unsynchronized(void)
>   {
>   	userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
> @@ -853,7 +875,7 @@ static void *umap(int fd, uint32_t handle)
>   {
>   	void *ptr;
>   
> -	if (gem_has_llc(fd)) {
> +	if (can_gtt_mmap) {
>   		ptr = gem_mmap__gtt(fd, handle, sizeof(linear),
>   				    PROT_READ | PROT_WRITE);
>   	} else {
> @@ -884,7 +906,7 @@ check_bo(int fd1, uint32_t handle1, int is_userptr, int fd2, uint32_t handle2)
>   	sigbus_start = (unsigned long)ptr2;
>   	igt_assert(memcmp(ptr1, ptr2, sizeof(linear)) == 0);
>   
> -	if (gem_has_llc(fd1)) {
> +	if (can_gtt_mmap) {
>   		counter++;
>   		memset(ptr1, counter, size);
>   		memset(ptr2, counter, size);
> @@ -971,7 +993,7 @@ static int test_dmabuf(void)
>   	free_userptr_bo(fd1, handle);
>   	close(fd1);
>   
> -	if (gem_has_llc(fd2)) {
> +	if (can_gtt_mmap) {

Kudos to myself I think for coming up with this convoluted test which I 
needed 15 minutes to reverse engineer. :) Okay it was many years ago so 
that's my excuse. In all cases mmap__gtt is either on userptr or on 
dmabuf import of userptr so I think it's correct.

>   		struct sigaction sigact, orig_sigact;
>   
>   		memset(&sigact, 0, sizeof(sigact));
> @@ -1225,7 +1247,7 @@ static void test_readonly_mmap(int i915)
>   	original = g_compute_checksum_for_data(G_CHECKSUM_SHA1, pages, sz);
>   
>   	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_WRITE);
> -	igt_assert(ptr == NULL);
> +	igt_require(ptr != NULL);

This should be able to stay unchanged, no? Whether read-only or mmap_gtt 
is disallowed it must always be NULL here. Non-NULL should be test fail.

>   
>   	ptr = gem_mmap__gtt(i915, handle, sz, PROT_READ);
>   	gem_close(i915, handle);
> @@ -1834,6 +1856,8 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
>   		igt_require_gem(fd);
>   		gem_require_blitter(fd);
>   
> +		can_gtt_mmap = has_gtt_mmap(fd) && gem_has_llc(fd);
> +
>   		size = sizeof(linear);
>   
>   		aperture_size = gem_aperture_size(fd);
> 

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-02  8:42 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
@ 2019-10-02  8:47   ` Chris Wilson
  0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2019-10-02  8:47 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin

Quoting Tvrtko Ursulin (2019-10-02 09:42:01)
> 
> On 01/10/2019 18:49, Chris Wilson wrote:
> > @@ -1225,7 +1247,7 @@ static void test_readonly_mmap(int i915)
> >       original = g_compute_checksum_for_data(G_CHECKSUM_SHA1, pages, sz);
> >   
> >       ptr = __gem_mmap__gtt(i915, handle, sz, PROT_WRITE);
> > -     igt_assert(ptr == NULL);
> > +     igt_require(ptr != NULL);
> 
> This should be able to stay unchanged, no? Whether read-only or mmap_gtt 
> is disallowed it must always be NULL here. Non-NULL should be test fail.

The test is also checking that readonly is honoured through the GTT mmap
interface, i.e. that you cannot write into imported memory, thereby
circumventing userptr(mmap("/etc/passwd", PROT_READ)).

I stuck the require in the wrong spot...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Intel-gfx] [PATCH i-g-t v2] i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
                   ` (2 preceding siblings ...)
  2019-10-02  8:42 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
@ 2019-10-02  8:50 ` Chris Wilson
  2019-10-02  9:18   ` [igt-dev] " Tvrtko Ursulin
  2019-10-02  9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2) Patchwork
  2019-10-02 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  5 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-10-02  8:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Having decided to close the GTT mmap of userptr objects loophole in the
kernel, we need to adjust the test suite to avoid tripping over GTT
mmaps when required.

v2: Refine read-only test to only skip checking GTT mmap interface.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/i915/gem_userptr_blits.c | 78 ++++++++++++++++++++++------------
 1 file changed, 52 insertions(+), 26 deletions(-)

diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
index 3fad7d1b3..2359c13f4 100644
--- a/tests/i915/gem_userptr_blits.c
+++ b/tests/i915/gem_userptr_blits.c
@@ -69,11 +69,33 @@
 
 static uint32_t userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
 
+static bool can_gtt_mmap;
+
 #define WIDTH 512
 #define HEIGHT 512
 
 static uint32_t linear[WIDTH*HEIGHT];
 
+static bool has_gtt_mmap(int i915)
+{
+	void *ptr, *map;
+	uint32_t handle;
+
+	igt_assert(posix_memalign(&ptr, PAGE_SIZE, PAGE_SIZE) == 0);
+
+	gem_userptr(i915, ptr, 4096, 0, 0, &handle);
+	igt_assert(handle != 0);
+
+	map = __gem_mmap__gtt(i915, handle, 4096, PROT_WRITE);
+	if (map)
+		munmap(map, 4096);
+
+	gem_close(i915, handle);
+	free(ptr);
+
+	return map != NULL;
+}
+
 static void gem_userptr_test_unsynchronized(void)
 {
 	userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
@@ -617,7 +639,7 @@ static int test_invalid_gtt_mapping(int fd)
 static void test_process_exit(int fd, int flags)
 {
 	if (flags & PE_GTT_MAP)
-		igt_require(gem_has_llc(fd));
+		igt_require(can_gtt_mmap);
 
 	igt_fork(child, 1) {
 		uint32_t handle;
@@ -853,7 +875,7 @@ static void *umap(int fd, uint32_t handle)
 {
 	void *ptr;
 
-	if (gem_has_llc(fd)) {
+	if (can_gtt_mmap) {
 		ptr = gem_mmap__gtt(fd, handle, sizeof(linear),
 				    PROT_READ | PROT_WRITE);
 	} else {
@@ -884,7 +906,7 @@ check_bo(int fd1, uint32_t handle1, int is_userptr, int fd2, uint32_t handle2)
 	sigbus_start = (unsigned long)ptr2;
 	igt_assert(memcmp(ptr1, ptr2, sizeof(linear)) == 0);
 
-	if (gem_has_llc(fd1)) {
+	if (can_gtt_mmap) {
 		counter++;
 		memset(ptr1, counter, size);
 		memset(ptr2, counter, size);
@@ -971,7 +993,7 @@ static int test_dmabuf(void)
 	free_userptr_bo(fd1, handle);
 	close(fd1);
 
-	if (gem_has_llc(fd2)) {
+	if (can_gtt_mmap) {
 		struct sigaction sigact, orig_sigact;
 
 		memset(&sigact, 0, sizeof(sigact));
@@ -1227,31 +1249,33 @@ static void test_readonly_mmap(int i915)
 	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_WRITE);
 	igt_assert(ptr == NULL);
 
-	ptr = gem_mmap__gtt(i915, handle, sz, PROT_READ);
+	/* Optional kernel support for GTT mmaps of userptr */
+	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_READ);
 	gem_close(i915, handle);
 
-	/* Check that a write into the GTT readonly map fails */
-	if (!(sig = sigsetjmp(sigjmp, 1))) {
-		signal(SIGBUS, sigjmp_handler);
-		signal(SIGSEGV, sigjmp_handler);
-		memset(ptr, 0x5a, sz);
-		igt_assert(0);
-	}
-	igt_assert_eq(sig, SIGSEGV);
-
-	/* Check that we disallow removing the readonly protection */
-	igt_assert(mprotect(ptr, sz, PROT_WRITE));
-	if (!(sig = sigsetjmp(sigjmp, 1))) {
-		signal(SIGBUS, sigjmp_handler);
-		signal(SIGSEGV, sigjmp_handler);
-		memset(ptr, 0x5a, sz);
-		igt_assert(0);
-	}
-	igt_assert_eq(sig, SIGSEGV);
+	if (ptr) { /* Check that a write into the GTT readonly map fails */
+		if (!(sig = sigsetjmp(sigjmp, 1))) {
+			signal(SIGBUS, sigjmp_handler);
+			signal(SIGSEGV, sigjmp_handler);
+			memset(ptr, 0x5a, sz);
+			igt_assert(0);
+		}
+		igt_assert_eq(sig, SIGSEGV);
+
+		/* Check that we disallow removing the readonly protection */
+		igt_assert(mprotect(ptr, sz, PROT_WRITE));
+		if (!(sig = sigsetjmp(sigjmp, 1))) {
+			signal(SIGBUS, sigjmp_handler);
+			signal(SIGSEGV, sigjmp_handler);
+			memset(ptr, 0x5a, sz);
+			igt_assert(0);
+		}
+		igt_assert_eq(sig, SIGSEGV);
 
-	/* A single read from the GTT pointer to prove that works */
-	igt_assert_eq_u32(*(uint8_t *)ptr, 0xa5);
-	munmap(ptr, sz);
+		/* A single read from the GTT pointer to prove that works */
+		igt_assert_eq_u32(*(uint8_t *)ptr, 0xa5);
+		munmap(ptr, sz);
+	}
 
 	/* Double check that the kernel did indeed not let any writes through */
 	igt_clflush_range(pages, sz);
@@ -1834,6 +1858,8 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
 		igt_require_gem(fd);
 		gem_require_blitter(fd);
 
+		can_gtt_mmap = has_gtt_mmap(fd) && gem_has_llc(fd);
+
 		size = sizeof(linear);
 
 		aperture_size = gem_aperture_size(fd);
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v2] i915/gem_userptr_blits: Check for allowed GTT mmaps
  2019-10-02  8:50 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
@ 2019-10-02  9:18   ` Tvrtko Ursulin
  0 siblings, 0 replies; 9+ messages in thread
From: Tvrtko Ursulin @ 2019-10-02  9:18 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin


On 02/10/2019 09:50, Chris Wilson wrote:
> Having decided to close the GTT mmap of userptr objects loophole in the
> kernel, we need to adjust the test suite to avoid tripping over GTT
> mmaps when required.
> 
> v2: Refine read-only test to only skip checking GTT mmap interface.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   tests/i915/gem_userptr_blits.c | 78 ++++++++++++++++++++++------------
>   1 file changed, 52 insertions(+), 26 deletions(-)
> 
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index 3fad7d1b3..2359c13f4 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -69,11 +69,33 @@
>   
>   static uint32_t userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
>   
> +static bool can_gtt_mmap;
> +
>   #define WIDTH 512
>   #define HEIGHT 512
>   
>   static uint32_t linear[WIDTH*HEIGHT];
>   
> +static bool has_gtt_mmap(int i915)
> +{
> +	void *ptr, *map;
> +	uint32_t handle;
> +
> +	igt_assert(posix_memalign(&ptr, PAGE_SIZE, PAGE_SIZE) == 0);
> +
> +	gem_userptr(i915, ptr, 4096, 0, 0, &handle);
> +	igt_assert(handle != 0);
> +
> +	map = __gem_mmap__gtt(i915, handle, 4096, PROT_WRITE);
> +	if (map)
> +		munmap(map, 4096);
> +
> +	gem_close(i915, handle);
> +	free(ptr);
> +
> +	return map != NULL;
> +}
> +
>   static void gem_userptr_test_unsynchronized(void)
>   {
>   	userptr_flags = LOCAL_I915_USERPTR_UNSYNCHRONIZED;
> @@ -617,7 +639,7 @@ static int test_invalid_gtt_mapping(int fd)
>   static void test_process_exit(int fd, int flags)
>   {
>   	if (flags & PE_GTT_MAP)
> -		igt_require(gem_has_llc(fd));
> +		igt_require(can_gtt_mmap);
>   
>   	igt_fork(child, 1) {
>   		uint32_t handle;
> @@ -853,7 +875,7 @@ static void *umap(int fd, uint32_t handle)
>   {
>   	void *ptr;
>   
> -	if (gem_has_llc(fd)) {
> +	if (can_gtt_mmap) {
>   		ptr = gem_mmap__gtt(fd, handle, sizeof(linear),
>   				    PROT_READ | PROT_WRITE);
>   	} else {
> @@ -884,7 +906,7 @@ check_bo(int fd1, uint32_t handle1, int is_userptr, int fd2, uint32_t handle2)
>   	sigbus_start = (unsigned long)ptr2;
>   	igt_assert(memcmp(ptr1, ptr2, sizeof(linear)) == 0);
>   
> -	if (gem_has_llc(fd1)) {
> +	if (can_gtt_mmap) {
>   		counter++;
>   		memset(ptr1, counter, size);
>   		memset(ptr2, counter, size);
> @@ -971,7 +993,7 @@ static int test_dmabuf(void)
>   	free_userptr_bo(fd1, handle);
>   	close(fd1);
>   
> -	if (gem_has_llc(fd2)) {
> +	if (can_gtt_mmap) {
>   		struct sigaction sigact, orig_sigact;
>   
>   		memset(&sigact, 0, sizeof(sigact));
> @@ -1227,31 +1249,33 @@ static void test_readonly_mmap(int i915)
>   	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_WRITE);
>   	igt_assert(ptr == NULL);
>   
> -	ptr = gem_mmap__gtt(i915, handle, sz, PROT_READ);
> +	/* Optional kernel support for GTT mmaps of userptr */
> +	ptr = __gem_mmap__gtt(i915, handle, sz, PROT_READ);
>   	gem_close(i915, handle);
>   
> -	/* Check that a write into the GTT readonly map fails */
> -	if (!(sig = sigsetjmp(sigjmp, 1))) {
> -		signal(SIGBUS, sigjmp_handler);
> -		signal(SIGSEGV, sigjmp_handler);
> -		memset(ptr, 0x5a, sz);
> -		igt_assert(0);
> -	}
> -	igt_assert_eq(sig, SIGSEGV);
> -
> -	/* Check that we disallow removing the readonly protection */
> -	igt_assert(mprotect(ptr, sz, PROT_WRITE));
> -	if (!(sig = sigsetjmp(sigjmp, 1))) {
> -		signal(SIGBUS, sigjmp_handler);
> -		signal(SIGSEGV, sigjmp_handler);
> -		memset(ptr, 0x5a, sz);
> -		igt_assert(0);
> -	}
> -	igt_assert_eq(sig, SIGSEGV);
> +	if (ptr) { /* Check that a write into the GTT readonly map fails */
> +		if (!(sig = sigsetjmp(sigjmp, 1))) {
> +			signal(SIGBUS, sigjmp_handler);
> +			signal(SIGSEGV, sigjmp_handler);
> +			memset(ptr, 0x5a, sz);
> +			igt_assert(0);
> +		}
> +		igt_assert_eq(sig, SIGSEGV);
> +
> +		/* Check that we disallow removing the readonly protection */
> +		igt_assert(mprotect(ptr, sz, PROT_WRITE));
> +		if (!(sig = sigsetjmp(sigjmp, 1))) {
> +			signal(SIGBUS, sigjmp_handler);
> +			signal(SIGSEGV, sigjmp_handler);
> +			memset(ptr, 0x5a, sz);
> +			igt_assert(0);
> +		}
> +		igt_assert_eq(sig, SIGSEGV);
>   
> -	/* A single read from the GTT pointer to prove that works */
> -	igt_assert_eq_u32(*(uint8_t *)ptr, 0xa5);
> -	munmap(ptr, sz);
> +		/* A single read from the GTT pointer to prove that works */
> +		igt_assert_eq_u32(*(uint8_t *)ptr, 0xa5);
> +		munmap(ptr, sz);
> +	}
>   
>   	/* Double check that the kernel did indeed not let any writes through */
>   	igt_clflush_range(pages, sz);
> @@ -1834,6 +1858,8 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
>   		igt_require_gem(fd);
>   		gem_require_blitter(fd);
>   
> +		can_gtt_mmap = has_gtt_mmap(fd) && gem_has_llc(fd);
> +
>   		size = sizeof(linear);
>   
>   		aperture_size = gem_aperture_size(fd);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2)
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
                   ` (3 preceding siblings ...)
  2019-10-02  8:50 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
@ 2019-10-02  9:40 ` Patchwork
  2019-10-02 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-02  9:40 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2)
URL   : https://patchwork.freedesktop.org/series/67464/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6986 -> IGTPW_3525
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html

Known issues
------------

  Here are the changes found in IGTPW_3525 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap@basic:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u3/igt@gem_mmap@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/fi-icl-u3/igt@gem_mmap@basic.html

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#109483])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_linear_blits@basic:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u3/igt@gem_linear_blits@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/fi-icl-u3/igt@gem_linear_blits@basic.html

  * igt@kms_chamelium@hdmi-edid-read:
    - {fi-icl-u4}:        [FAIL][9] ([fdo#111045]) -> [PASS][10] +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
  [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
  [fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831


Participating hosts (54 -> 43)
------------------------------

  Missing    (11): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-skl-lmem fi-byt-clapper fi-bdw-samus fi-kbl-r 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5208 -> IGTPW_3525

  CI-20190529: 20190529
  CI_DRM_6986: 9300459553e8c1032f10ec1953e1a375a99aba13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3525: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html
  IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2)
  2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
                   ` (4 preceding siblings ...)
  2019-10-02  9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2) Patchwork
@ 2019-10-02 13:51 ` Patchwork
  5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-02 13:51 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2)
URL   : https://patchwork.freedesktop.org/series/67464/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6986_full -> IGTPW_3525_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3525_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3525_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3525_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
    - shard-iclb:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb8/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html

  
Known issues
------------

  Here are the changes found in IGTPW_3525_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110841])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_eio@in-flight-suspend:
    - shard-kbl:          [PASS][7] -> [INCOMPLETE][8] ([fdo#103665])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl7/igt@gem_eio@in-flight-suspend.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-kbl3/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          [PASS][9] -> [FAIL][10] ([fdo#109661])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb1/igt@gem_eio@unwedge-stress.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-snb1/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#111325]) +2 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb6/igt@gem_exec_schedule@in-order-bsd.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_fence_thrash@bo-write-verify-threaded-x:
    - shard-apl:          [PASS][13] -> [INCOMPLETE][14] ([fdo#103927])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl8/igt@gem_fence_thrash@bo-write-verify-threaded-x.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl7/igt@gem_fence_thrash@bo-write-verify-threaded-x.html

  * igt@gem_partial_pwrite_pread@write-uncached:
    - shard-iclb:         [PASS][15] -> [INCOMPLETE][16] ([fdo#107713]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb8/igt@gem_partial_pwrite_pread@write-uncached.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb7/igt@gem_partial_pwrite_pread@write-uncached.html

  * igt@gem_softpin@noreloc-s3:
    - shard-apl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +7 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl4/igt@gem_softpin@noreloc-s3.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl7/igt@gem_softpin@noreloc-s3.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-glk:          [PASS][19] -> [DMESG-WARN][20] ([fdo#111870])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk3/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-glk3/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-snb:          [PASS][21] -> [DMESG-WARN][22] ([fdo#111870]) +2 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-snb7/igt@gem_userptr_blits@sync-unmap.html

  * igt@kms_atomic_transition@plane-all-transition-fencing:
    - shard-snb:          [PASS][23] -> [SKIP][24] ([fdo#109271])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb6/igt@kms_atomic_transition@plane-all-transition-fencing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-snb2/igt@kms_atomic_transition@plane-all-transition-fencing.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
    - shard-apl:          [PASS][25] -> [DMESG-WARN][26] ([fdo#109385])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl4/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html

  * igt@kms_flip@2x-flip-vs-suspend-interruptible:
    - shard-hsw:          [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw7/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html

  * igt@kms_flip@modeset-vs-vblank-race:
    - shard-glk:          [PASS][29] -> [FAIL][30] ([fdo#111609])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk3/igt@kms_flip@modeset-vs-vblank-race.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-glk9/igt@kms_flip@modeset-vs-vblank-race.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
    - shard-iclb:         [PASS][31] -> [FAIL][32] ([fdo#103167]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][33] -> [FAIL][34] ([fdo#103166])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][37] -> [FAIL][38] ([fdo#99912])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl6/igt@kms_setmode@basic.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl1/igt@kms_setmode@basic.html

  * igt@prime_vgem@fence-wait-bsd2:
    - shard-iclb:         [PASS][39] -> [SKIP][40] ([fdo#109276]) +10 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html

  
#### Possible fixes ####

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][41] ([fdo#111325]) -> [PASS][42] +2 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_request_retire@retire-vma-not-inactive:
    - shard-hsw:          [INCOMPLETE][43] ([fdo#103540]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw4/igt@gem_request_retire@retire-vma-not-inactive.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-hsw6/igt@gem_request_retire@retire-vma-not-inactive.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-kbl:          [DMESG-WARN][45] ([fdo#111870]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@gem_userptr_blits@dmabuf-sync.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-kbl2/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-glk:          [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-glk3/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-glk7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-iclb:         [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
    - shard-snb:          [DMESG-WARN][51] ([fdo#110789] / [fdo#111870]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54] +3 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
    - shard-hsw:          [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56] +2 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw4/igt@gem_userptr_blits@sync-unmap-cycles.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-hsw8/igt@gem_userptr_blits@sync-unmap-cycles.html
    - shard-apl:          [DMESG-WARN][57] ([fdo#109385] / [fdo#111870]) -> [PASS][58] +2 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl1/igt@gem_userptr_blits@sync-unmap-cycles.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl4/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +3 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-apl8/igt@i915_suspend@sysfs-reader.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-apl4/igt@i915_suspend@sysfs-reader.html
    - shard-kbl:          [INCOMPLETE][61] ([fdo#103665] / [fdo#108767]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@i915_suspend@sysfs-reader.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-kbl7/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
    - shard-hsw:          [DMESG-FAIL][63] ([fdo#102614]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-hsw5/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-hsw6/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
    - shard-iclb:         [FAIL][65] ([fdo#103167]) -> [PASS][66] +4 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][67] ([fdo#109441]) -> [PASS][68] +3 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [INCOMPLETE][69] ([fdo#103665]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [SKIP][71] ([fdo#109276]) -> [PASS][72] +13 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb3/igt@prime_busy@hang-bsd2.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb2/igt@prime_busy@hang-bsd2.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][73] ([fdo#109276]) -> [FAIL][74] ([fdo#111329])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_mocs_settings@mocs-isolation-bsd2:
    - shard-iclb:         [SKIP][75] ([fdo#109276]) -> [FAIL][76] ([fdo#111330])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb7/igt@gem_mocs_settings@mocs-isolation-bsd2.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html

  * igt@gem_mocs_settings@mocs-settings-bsd2:
    - shard-iclb:         [FAIL][77] ([fdo#111330]) -> [SKIP][78] ([fdo#109276])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6986/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/shard-iclb8/igt@gem_mocs_settings@mocs-settings-bsd2.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (11 -> 6)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-tglb pig-skl-6260u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5208 -> IGTPW_3525
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_6986: 9300459553e8c1032f10ec1953e1a375a99aba13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3525: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html
  IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3525/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-10-02 13:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-01 17:49 [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps Chris Wilson
2019-10-01 19:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-10-02  5:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-10-02  8:42 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2019-10-02  8:47   ` Chris Wilson
2019-10-02  8:50 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
2019-10-02  9:18   ` [igt-dev] " Tvrtko Ursulin
2019-10-02  9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_userptr_blits: Check for allowed GTT mmaps (rev2) Patchwork
2019-10-02 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox