Re: [igt-dev] [PATCH 0/6] tests/kms_vrr: Modify kms_vrr to allow flicker

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

Hi Sean Paul,

On Sat-26-08-2023 12:06 am, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Do some cleanup in the kms_vrr test and add some optional command line
> arguments to alter the target refresh rate for the test. This allows us
> to profile VRR flicker on panels at the low end of the refresh range.

Overall, this series makes sense to me. I have dropped few comments & my 
R-b too. But with this series, there is a crash in Negative test [1]. 
Please fix that.

And I can feel it is better to check the health of these kms_vrr tests 
by adding them to the BAT [2] & [3] with a HAX patch.

[1]: 
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9666/shard-mtlp-1/igt@kms_vrr@negative-basic@pipe-a-edp-1.html
[2]: tests/intel-ci/fast-feedback.testlist
[3]: tests/intel-ci/xe-fast-feedback.testlist

- Bhanu

> 
> Sean Paul (6):
>    tests/kms_vrr: Move fb0 and fb1 to an array
>    tests/kms_vrr: Move vtest_ns into data_t
>    tests/kms_vrr: Allow test rate to be altered from the command line
>    tests/kms_vrr: Allow test duration to be specified from the command
>      line
>    tests/kms_vrr: Change the pattern displayed in the test
>    test/kms_vrr: Add ability to flip static image for flicker profiling
> 
>   tests/kms_vrr.c | 138 ++++++++++++++++++++++++++++++++----------------
>   1 file changed, 92 insertions(+), 46 deletions(-)
>