From: Sean Paul <sean@poorly.run>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [igt-dev] [PATCH 4/6] tests/kms_vrr: Allow test duration to be specified from the command line
Date: Fri, 25 Aug 2023 18:36:19 +0000 [thread overview]
Message-ID: <20230825183934.1271156-5-sean@poorly.run> (raw)
In-Reply-To: <20230825183934.1271156-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
Using --duration argument, otherwise use default.
Cc: Mark Yacoub <markyacoub@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
tests/kms_vrr.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index d62ded180..67d13d4bf 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -114,6 +114,7 @@ typedef struct data {
igt_fb_t fb[2];
range_t range;
vtest_ns_t vtest_ns;
+ uint64_t duration_ns;
} data_t;
typedef void (*test_t)(data_t*, enum pipe, igt_output_t*, uint32_t);
@@ -262,6 +263,9 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
data->vtest_ns.rate_ns >= data->vtest_ns.max,
"Invalid test rate specified!\n");
+ if (data->duration_ns == 0)
+ data->duration_ns = TEST_DURATION_NS;
+
/* Override mode with max vrefresh.
* - vrr_min range should be less than the override mode vrefresh.
* - Limit the vrr_max range with the override mode vrefresh.
@@ -458,7 +462,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
*/
if (flags & TEST_FLIPLINE) {
rate = rate_from_refresh(range.max + 5);
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
(range.max + 5), rate, result);
@@ -466,7 +470,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
if (flags & ~TEST_NEGATIVE) {
rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
((range.max + range.min) / 2), rate, result);
@@ -474,7 +478,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
if (flags & TEST_FLIPLINE) {
rate = rate_from_refresh(range.min - 5);
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result < 50,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
(range.min - 5), rate, result);
@@ -487,7 +491,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
*/
set_vrr_on_pipe(data, pipe, (flags & TEST_NEGATIVE)? true : false);
rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result < 10,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold exceeded, result was %u%%\n",
((range.max + range.min) / 2), rate, (flags & TEST_NEGATIVE)? "on" : "off", result);
@@ -543,6 +547,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
data_t *data = _data;
switch (opt) {
+ case 'd':
+ data->duration_ns = atoi(optarg) * NSECS_PER_SEC;
+ break;
case 'r':
data->vtest_ns.rate_ns = rate_from_refresh(atoi(optarg));
break;
@@ -551,11 +558,13 @@ static int opt_handler(int opt, int opt_index, void *_data)
}
static const struct option long_opts[] = {
+ { .name = "duration", .has_arg = true, .val = 'd', },
{ .name = "refresh-rate", .has_arg = true, .val = 'r', },
{}
};
static const char help_str[] =
+ " --duration <duration-seconds>\t\tHow long to run the test for\n"
" --refresh-rate <refresh-hz>\t\tThe refresh rate to flip at\n";
static data_t data;
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2023-08-25 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 18:36 [igt-dev] [PATCH 0/6] tests/kms_vrr: Modify kms_vrr to allow flicker Sean Paul
2023-08-25 18:36 ` [igt-dev] [PATCH 1/6] tests/kms_vrr: Move fb0 and fb1 to an array Sean Paul
2023-09-06 19:07 ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 2/6] tests/kms_vrr: Move vtest_ns into data_t Sean Paul
2023-09-06 19:07 ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 3/6] tests/kms_vrr: Allow test rate to be altered from the command line Sean Paul
2023-09-06 19:07 ` Modem, Bhanuprakash
2023-08-25 18:36 ` Sean Paul [this message]
2023-09-06 19:08 ` [igt-dev] [PATCH 4/6] tests/kms_vrr: Allow test duration to be specified " Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 5/6] tests/kms_vrr: Change the pattern displayed in the test Sean Paul
2023-09-06 19:08 ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 6/6] test/kms_vrr: Add ability to flip static image for flicker profiling Sean Paul
2023-08-25 19:30 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_vrr: Modify kms_vrr to allow flicker Patchwork
2023-08-25 19:46 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-08-25 19:55 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-08-26 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-31 17:15 ` [igt-dev] [PATCH 0/6] " Sean Paul
2023-09-06 19:08 ` Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825183934.1271156-5-sean@poorly.run \
--to=sean@poorly.run \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox