Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [igt-dev] [PATCH 1/6] tests/kms_vrr: Move fb0 and fb1 to an array
Date: Fri, 25 Aug 2023 18:36:16 +0000	[thread overview]
Message-ID: <20230825183934.1271156-2-sean@poorly.run> (raw)
In-Reply-To: <20230825183934.1271156-1-sean@poorly.run>

From: Sean Paul <seanpaul@chromium.org>

A bit of cleanup, no functional changes.

Cc: Mark Yacoub <markyacoub@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 tests/kms_vrr.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index d7ede6513..83a91b543 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -105,8 +105,7 @@ typedef struct data {
 	igt_display_t display;
 	int drm_fd;
 	igt_plane_t *primary;
-	igt_fb_t fb0;
-	igt_fb_t fb1;
+	igt_fb_t fb[2];
 	range_t range;
 } data_t;
 
@@ -273,13 +272,13 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 	/* Prepare resources */
 	igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
 			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
-			    0.50, 0.50, 0.50, &data->fb0);
+			    0.50, 0.50, 0.50, &data->fb[0]);
 
 	igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
 			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
-			    0.50, 0.50, 0.50, &data->fb1);
+			    0.50, 0.50, 0.50, &data->fb[1]);
 
-	cr = igt_get_cairo_ctx(data->drm_fd, &data->fb0);
+	cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[0]);
 
 	igt_paint_color(cr, 0, 0, mode.hdisplay / 10, mode.vdisplay / 10,
 			1.00, 0.00, 0.00);
@@ -288,7 +287,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 
 	/* Take care of any required modesetting before the test begins. */
 	data->primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-	igt_plane_set_fb(data->primary, &data->fb0);
+	igt_plane_set_fb(data->primary, &data->fb[0]);
 
 	/* Clear vrr_enabled state before enabling it, because
 	 * it might be left enabled if the previous test fails.
@@ -338,7 +337,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 	vtest_ns_t vtest_ns = get_test_rate_ns(data->range);
 
 	/* Align with the flip completion event to speed up convergence. */
-	do_flip(data, &data->fb0);
+	do_flip(data, &data->fb[0]);
 	start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
 							DRM_EVENT_FLIP_COMPLETE);
 
@@ -347,7 +346,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
 		int64_t diff_ns;
 
 		front = !front;
-		do_flip(data, front ? &data->fb1 : &data->fb0);
+		do_flip(data, front ? &data->fb[1] : &data->fb[0]);
 
 		/* We need to cpture flip event instead of vblank event,
 		 * because vblank is triggered after each frame, but depending
@@ -497,8 +496,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	igt_output_override_mode(output, NULL);
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
-	igt_remove_fb(data->drm_fd, &data->fb1);
-	igt_remove_fb(data->drm_fd, &data->fb0);
+	igt_remove_fb(data->drm_fd, &data->fb[1]);
+	igt_remove_fb(data->drm_fd, &data->fb[0]);
 }
 
 /* Runs tests on outputs that are VRR capable. */
-- 
Sean Paul, Software Engineer, Google / Chromium OS

  reply	other threads:[~2023-08-25 18:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 18:36 [igt-dev] [PATCH 0/6] tests/kms_vrr: Modify kms_vrr to allow flicker Sean Paul
2023-08-25 18:36 ` Sean Paul [this message]
2023-09-06 19:07   ` [igt-dev] [PATCH 1/6] tests/kms_vrr: Move fb0 and fb1 to an array Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 2/6] tests/kms_vrr: Move vtest_ns into data_t Sean Paul
2023-09-06 19:07   ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 3/6] tests/kms_vrr: Allow test rate to be altered from the command line Sean Paul
2023-09-06 19:07   ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 4/6] tests/kms_vrr: Allow test duration to be specified " Sean Paul
2023-09-06 19:08   ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 5/6] tests/kms_vrr: Change the pattern displayed in the test Sean Paul
2023-09-06 19:08   ` Modem, Bhanuprakash
2023-08-25 18:36 ` [igt-dev] [PATCH 6/6] test/kms_vrr: Add ability to flip static image for flicker profiling Sean Paul
2023-08-25 19:30 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_vrr: Modify kms_vrr to allow flicker Patchwork
2023-08-25 19:46 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-08-25 19:55 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-08-26 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-31 17:15 ` [igt-dev] [PATCH 0/6] " Sean Paul
2023-09-06 19:08 ` Modem, Bhanuprakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825183934.1271156-2-sean@poorly.run \
    --to=sean@poorly.run \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox