public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>,
	ville.syrjala@intel.com, petri.latvala@intel.com,
	daniel.vetter@intel.com
Subject: [igt-dev] [PATCH i-g-t v4 0/4] validate color tests using chamelium.
Date: Thu, 23 Jan 2020 13:30:38 +0530	[thread overview]
Message-ID: <1579766442-20285-1-git-send-email-kunal1.joshi@intel.com> (raw)

For gen11+ platforms, there are frequent crc mismatch issues observed
in color tests. This is happening due to hardware limitation
(pipe rounding). One of the solutions to fix this is by rewriting
color tests and making them compatible with chamelium.

In this patch series, color tests are modified to have frame dump
comparison instead of crc comparison using chamelium hooks. This
will be useful even for future platforms. Also, with this approach
we could enable limited-range subtest which was commented in kms_color
because of crc mismatch.

Kunal Joshi (4):
  lib/igt_chamelium Added chamelium_frame_match_or_dumpn which returns
    bool that the captured frame matches with reference framebuffer
  Moved common function in kms_color and kms_color_chamelium to
    kms_color_helper.c
  tests/kms_color_chamelium: add subtests to validate color
  HAX: Run in BAT

 lib/igt_chamelium.c                   |  25 +-
 lib/igt_chamelium.h                   |   5 +
 tests/Makefile.am                     |   3 +
 tests/Makefile.sources                |  13 +-
 tests/intel-ci/fast-feedback.testlist |  66 +++
 tests/kms_color.c                     | 383 +----------------
 tests/kms_color.h                     | 105 +++++
 tests/kms_color_chamelium.c           | 759 ++++++++++++++++++++++++++++++++++
 tests/kms_color_helper.c              | 386 +++++++++++++++++
 tests/meson.build                     |  19 +-
 10 files changed, 1378 insertions(+), 386 deletions(-)
 create mode 100644 tests/kms_color.h
 create mode 100644 tests/kms_color_chamelium.c
 create mode 100644 tests/kms_color_helper.c

-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-01-23 14:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23  8:00 Kunal Joshi [this message]
2020-01-23  8:00 ` [igt-dev] [PATCH i-g-t v4 1/4] lib/igt_chamelium Added chamelium_frame_match_or_dumpn which returns bool that the captured frame matches with reference framebuffer Kunal Joshi
2020-01-24 10:01   ` Petri Latvala
2020-01-23  8:00 ` [igt-dev] [PATCH i-g-t v4 2/4] Moved common function in kms_color and kms_color_chamelium to kms_color_helper.c Kunal Joshi
2020-01-24 10:07   ` Petri Latvala
2020-01-24 10:38     ` Petri Latvala
2020-01-23  8:00 ` [igt-dev] [PATCH i-g-t v4 3/4] tests/kms_color_chamelium: add subtests to validate color Kunal Joshi
2020-01-24 10:11   ` Petri Latvala
2020-01-23  8:00 ` [igt-dev] [PATCH i-g-t v4 4/4] HAX: Run in BAT Kunal Joshi
2020-01-23 16:04 ` [igt-dev] ✓ Fi.CI.BAT: success for validate color tests using chamelium. (rev4) Patchwork
2020-01-24 10:15   ` Petri Latvala
2020-01-25  0:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1579766442-20285-1-git-send-email-kunal1.joshi@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox