From: Petri Latvala <petri.latvala@intel.com>
To: Kunal Joshi <kunal1.joshi@intel.com>
Cc: igt-dev@lists.freedesktop.org, daniel.vetter@intel.com,
ville.syrjala@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t v4 2/4] Moved common function in kms_color and kms_color_chamelium to kms_color_helper.c
Date: Fri, 24 Jan 2020 12:38:24 +0200 [thread overview]
Message-ID: <20200124103824.GQ25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200124100754.GN25209@platvala-desk.ger.corp.intel.com>
On Fri, Jan 24, 2020 at 12:07:54PM +0200, Petri Latvala wrote:
> On Thu, Jan 23, 2020 at 01:30:40PM +0530, Kunal Joshi wrote:
> > kms_color and kms_color_chamelium shared common functions.
> > Moved them to tests/kms_color_helper.c to avoid code duplication.
> >
> > (v4)
> > Made a library kms_color_helper.c which is specific to
> > kms_color and kms_color_chamelium.
> >
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> > Suggested-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> > tests/Makefile.am | 3 +
> > tests/Makefile.sources | 13 +-
> > tests/kms_color.c | 383 +---------------------------------------------
> > tests/kms_color.h | 105 +++++++++++++
> > tests/kms_color_helper.c | 386 +++++++++++++++++++++++++++++++++++++++++++++++
> > tests/meson.build | 19 ++-
> > 6 files changed, 525 insertions(+), 384 deletions(-)
> > create mode 100644 tests/kms_color.h
> > create mode 100644 tests/kms_color_helper.c
> >
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index fc30524..87ffec2 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -13,11 +13,14 @@ endif
> > if HAVE_CHAMELIUM
> > TESTS_progs += \
> > kms_chamelium \
> > + kms_color_chamelium \
Well, this I missed: The build system changes related to
kms_color_chamelium need to be moved to the patch that adds
kms_color_chamelium.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-24 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 8:00 [igt-dev] [PATCH i-g-t v4 0/4] validate color tests using chamelium Kunal Joshi
2020-01-23 8:00 ` [igt-dev] [PATCH i-g-t v4 1/4] lib/igt_chamelium Added chamelium_frame_match_or_dumpn which returns bool that the captured frame matches with reference framebuffer Kunal Joshi
2020-01-24 10:01 ` Petri Latvala
2020-01-23 8:00 ` [igt-dev] [PATCH i-g-t v4 2/4] Moved common function in kms_color and kms_color_chamelium to kms_color_helper.c Kunal Joshi
2020-01-24 10:07 ` Petri Latvala
2020-01-24 10:38 ` Petri Latvala [this message]
2020-01-23 8:00 ` [igt-dev] [PATCH i-g-t v4 3/4] tests/kms_color_chamelium: add subtests to validate color Kunal Joshi
2020-01-24 10:11 ` Petri Latvala
2020-01-23 8:00 ` [igt-dev] [PATCH i-g-t v4 4/4] HAX: Run in BAT Kunal Joshi
2020-01-23 16:04 ` [igt-dev] ✓ Fi.CI.BAT: success for validate color tests using chamelium. (rev4) Patchwork
2020-01-24 10:15 ` Petri Latvala
2020-01-25 0:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124103824.GQ25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox