Re: [igt-dev] [PATCH i-g-t v4 1/4] lib/igt_chamelium Added chamelium_frame_match_or_dumpn which returns bool that the captured frame matches with reference framebuffer

[Petri Latvala <petri.latvala@intel.com>]

The subject line needs to be shortened.

How about

lib/chamelium: Add a non-asserting frame match function

On Thu, Jan 23, 2020 at 01:30:39PM +0530, Kunal Joshi wrote:
> Added chamelium_frame_match_or_dump which returns bool that the captured
> frame matches with reference framebuffer.
> 
> (v2)
>         Removed previously added function chamelium_assert_frame_dump_eq.
> 
> (v3)
>         No change.
> 
> (v4)
>         Removed duplicate function code chamelium_assert_frame_dump_match
> 
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Suggested-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  lib/igt_chamelium.c | 25 +++++++++++++++++++++++--
>  lib/igt_chamelium.h |  5 +++++
>  2 files changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index 9971f51..95166e2 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -1583,6 +1583,27 @@ void chamelium_assert_frame_match_or_dump(struct chamelium *chamelium,
>  					  struct igt_fb *fb,
>  					  enum chamelium_check check)
>  {
> +	igt_assert(chamelium_frame_match_or_dump(chamelium, port,
> +						 frame, fb, check));
> +}
> +
> +/**
> + * chamelium_assert_frame_match_or_dump:
               ^^^^^^^
	       wrong name here



Otherwise LGTM.

With those fixed,
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev