Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [[PATCH i-g-t]] tests/kms_setmode: disable DRRS if eDP support variable refresh rate
@ 2023-10-18  7:59 Lee Shawn C
  2023-10-18  8:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for ] " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Lee Shawn C @ 2023-10-18  7:59 UTC (permalink / raw)
  To: igt-dev; +Cc: Lee Shawn C

Below is a failed case while testing kms_setmode.

CRTC[80] [Pipe A] Mode: 1920x1200@60Hz Connectors: eDP-1[236]
Expected frametime: 16659us; measured 20824.4us +- 4.799us accuracy 0.01% [0.10 scanlines]

The expected frame time is 16659us (60Hz refresh rate).
But kms_setmode report measured time was 20824.4us (48Hz) then
it failed. We found legacy DRRS mode was active at that time
then refresh rate fall into lower RR automatically to cause this problem.
Disable DRRS after crtc setmode can avoid driver switch to lower RR mode
and get pass for this test as well.

Issue: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/148
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
 tests/kms_setmode.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 5fc4421c0080..b6fe3f9c159a 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -31,6 +31,7 @@
 #include <sys/time.h>
 #include <math.h>
 #include "xe/xe_query.h"
+#include "i915/intel_drrs.h"
 /**
  * TEST: kms setmode
  * Category: Display
@@ -651,6 +652,9 @@ retry:
 					     crtc->fb_info.fb_id, 0, 0, ids,
 					     crtc->connector_count, &crtc->mode);
 
+		if (is_intel_device(drm_fd))
+			intel_drrs_disable(drm_fd, crtc->pipe_id);
+
 		free(ids);
 
 		if (ret < 0) {
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-10-25  8:30 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18  7:59 [igt-dev] [[PATCH i-g-t]] tests/kms_setmode: disable DRRS if eDP support variable refresh rate Lee Shawn C
2023-10-18  8:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for ] " Patchwork
2023-10-18  9:45 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-10-18 17:04 ` [igt-dev] [[PATCH i-g-t]] " Mark Yacoub
2023-10-19  9:55   ` Lee, Shawn C
2023-10-19 10:39 ` Kamil Konieczny
2023-10-19 10:53   ` Lee, Shawn C
2023-10-19 11:27 ` [igt-dev] [PATCH] " Lee Shawn C
2023-10-20 14:02   ` Juha-Pekka Heikkila
2023-10-23  5:22   ` Modem, Bhanuprakash
2023-10-23  5:59     ` Lee, Shawn C
2023-10-25  8:29       ` Modem, Bhanuprakash
2023-10-23 17:40 ` [igt-dev] ✓ Fi.CI.BAT: success for ] tests/kms_setmode: disable DRRS if eDP support variable refresh rate (rev2) Patchwork
2023-10-23 18:44 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-24  1:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox