Re: [igt-dev] [i-g-t V3 5/7] tests/kms_invalid_mode: Use helpers from IGT lib

[Karthik B S <karthik.b.s@intel.com>]

On 3/31/2023 12:20 PM, Bhanuprakash Modem wrote:
> Instead of writing own logic at test level, use existing IGT
> helper to read the max dot clock.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_invalid_mode.c | 23 +----------------------
>   1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 86f529e88b1..ec048305567 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -213,27 +213,6 @@ test_output(data_t *data)
>   	igt_remove_fb(data->drm_fd, &fb);
>   }
>   
> -static int i915_max_dotclock(data_t *data)
> -{
> -	char buf[4096];
> -	char *s;
> -	int max_dotclock = 0;
> -
> -	if (!is_i915_device(data->drm_fd))
> -		return 0;
> -
> -	igt_debugfs_read(data->drm_fd, "i915_frequency_info", buf);
> -	s = strstr(buf, "Max pixel clock frequency:");
> -	igt_assert(s);
> -	igt_assert_eq(sscanf(s, "Max pixel clock frequency: %d kHz", &max_dotclock), 1);
> -
> -	/* 100 Mhz to 5 GHz seem like reasonable values to expect */
> -	igt_assert_lt(max_dotclock, 5000000);
> -	igt_assert_lt(100000, max_dotclock);
> -
> -	return max_dotclock;
> -}
> -
>   static const struct {
>   	const char *name;
>   	bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> @@ -293,7 +272,7 @@ igt_main
>   		data.res = drmModeGetResources(data.drm_fd);
>   		igt_assert(data.res);
>   
> -		data.max_dotclock = i915_max_dotclock(&data);
> +		data.max_dotclock = igt_get_max_dotclock(data.drm_fd);
>   		igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
>   	}
>