Re: [igt-dev] [i-g-t V3 4/7] tests/i915/kms_dsc: Drop bigjoiner check

[Karthik B S <karthik.b.s@intel.com>]

On 3/31/2023 12:20 PM, Bhanuprakash Modem wrote:
> Drop bigjoiner specific check, instead use the generic check
> i915_pipe_output_combo_valid() which will take care of bigjoiner
> too.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_dsc.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> index 9c6a7780acd..2c49ded4dfc 100644
> --- a/tests/i915/kms_dsc.c
> +++ b/tests/i915/kms_dsc.c
> @@ -71,7 +71,7 @@ static drmModeModeInfo *get_highres_mode(igt_output_t *output)
>   	return highest_mode;
>   }
>   
> -static bool check_big_joiner_pipe_constraint(data_t *data)
> +static bool pipe_output_combo_valid(data_t *data)
>   {
>   	igt_output_t *output = data->output;
>   	drmModeModeInfo *mode = get_highres_mode(output);
> @@ -80,11 +80,9 @@ static bool check_big_joiner_pipe_constraint(data_t *data)
>   	igt_output_set_pipe(output, data->pipe);
>   	igt_output_override_mode(output, mode);
>   
> -	if (!igt_check_bigjoiner_support(&data->display)) {

Hi,

This check is added in patch 3 of this series and removed in this patch. 
Is patch 3 necessary in this case?

Thanks,
Karthik.B.S
> -		igt_debug("Pipe-%s not supported due to bigjoiner limitation\n",
> -			   kmstest_pipe_name(data->pipe));
> +	if (!i915_pipe_output_combo_valid(&data->display))
>   		ret = false;
> -	}
> +
>   	igt_output_set_pipe(output, PIPE_NONE);
>   
>   	return ret;
> @@ -193,7 +191,7 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
>   		if (!check_gen11_bpc_constraint(data->drm_fd, data->output, data->input_bpc))
>   			continue;
>   
> -		if (!check_big_joiner_pipe_constraint(data))
> +		if (!pipe_output_combo_valid(data))
>   			continue;
>   
>   		if (test_type == TEST_DSC_BPC)