Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, swati2.sharma@intel.com
Subject: [igt-dev] [i-g-t V3 4/7] tests/i915/kms_dsc: Drop bigjoiner check
Date: Fri, 31 Mar 2023 12:20:26 +0530	[thread overview]
Message-ID: <20230331065029.3869109-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230331065029.3869109-1-bhanuprakash.modem@intel.com>

Drop bigjoiner specific check, instead use the generic check
i915_pipe_output_combo_valid() which will take care of bigjoiner
too.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_dsc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
index 9c6a7780acd..2c49ded4dfc 100644
--- a/tests/i915/kms_dsc.c
+++ b/tests/i915/kms_dsc.c
@@ -71,7 +71,7 @@ static drmModeModeInfo *get_highres_mode(igt_output_t *output)
 	return highest_mode;
 }
 
-static bool check_big_joiner_pipe_constraint(data_t *data)
+static bool pipe_output_combo_valid(data_t *data)
 {
 	igt_output_t *output = data->output;
 	drmModeModeInfo *mode = get_highres_mode(output);
@@ -80,11 +80,9 @@ static bool check_big_joiner_pipe_constraint(data_t *data)
 	igt_output_set_pipe(output, data->pipe);
 	igt_output_override_mode(output, mode);
 
-	if (!igt_check_bigjoiner_support(&data->display)) {
-		igt_debug("Pipe-%s not supported due to bigjoiner limitation\n",
-			   kmstest_pipe_name(data->pipe));
+	if (!i915_pipe_output_combo_valid(&data->display))
 		ret = false;
-	}
+
 	igt_output_set_pipe(output, PIPE_NONE);
 
 	return ret;
@@ -193,7 +191,7 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
 		if (!check_gen11_bpc_constraint(data->drm_fd, data->output, data->input_bpc))
 			continue;
 
-		if (!check_big_joiner_pipe_constraint(data))
+		if (!pipe_output_combo_valid(data))
 			continue;
 
 		if (test_type == TEST_DSC_BPC)
-- 
2.40.0

  parent reply	other threads:[~2023-03-31  6:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  6:50 [igt-dev] [i-g-t V3 0/7] Fix Bigjoiner checks Bhanuprakash Modem
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 1/7] lib/igt_kms: " Bhanuprakash Modem
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 2/7] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-05  9:45   ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
2023-04-12  9:32     ` Karthik B S
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 3/7] tests/i915/kms_dsc: Update bigjoiner pipe constraint Bhanuprakash Modem
2023-03-31  6:50 ` Bhanuprakash Modem [this message]
2023-04-13  9:49   ` [igt-dev] [i-g-t V3 4/7] tests/i915/kms_dsc: Drop bigjoiner check Karthik B S
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 5/7] tests/kms_invalid_mode: Use helpers from IGT lib Bhanuprakash Modem
2023-04-05  7:43   ` Karthik B S
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 6/7] tests/kms_flip: Fix Bigjoiner checks Bhanuprakash Modem
2023-03-31  6:50 ` [igt-dev] [i-g-t V3 7/7] tests/kms_setmode: " Bhanuprakash Modem
2023-03-31  7:29 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix Bigjoiner checks (rev3) Patchwork
2023-04-01  5:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-05 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix Bigjoiner checks (rev4) Patchwork
2023-04-06  4:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331065029.3869109-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox