* [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
@ 2018-01-30 15:49 Ville Syrjala
2018-01-30 15:51 ` Maarten Lankhorst
2018-01-30 21:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Ville Syrjala @ 2018-01-30 15:49 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Since kernel commit e995ca0b8139 ("drm/i915: Provide a device level
.mode_valid() hook") i915 will bluntly reject the HSKEW mode flag. Thus
we can't abuse it to force a modeset.
Since we don't particularly care about the visual results here we can
risk making the display unhappy by eg. flipping the hsync polarity
instead.
Also add a comment documenting why we're doing this.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104848
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_atomic_transition.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 798639393421..aa9a6f8439ea 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -410,7 +410,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
mode = igt_output_get_mode(output);
override_mode = *mode;
- override_mode.flags |= DRM_MODE_FLAG_HSKEW;
+ /* try to force a modeset */
+ override_mode.flags ^= DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC;
igt_create_fb(display->drm_fd, mode->hdisplay, mode->vdisplay,
DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
--
2.13.6
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
2018-01-30 15:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset Ville Syrjala
@ 2018-01-30 15:51 ` Maarten Lankhorst
2018-01-30 16:57 ` Ville Syrjälä
2018-01-30 21:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Maarten Lankhorst @ 2018-01-30 15:51 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Op 30-01-18 om 16:49 schreef Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Since kernel commit e995ca0b8139 ("drm/i915: Provide a device level
> .mode_valid() hook") i915 will bluntly reject the HSKEW mode flag. Thus
> we can't abuse it to force a modeset.
>
> Since we don't particularly care about the visual results here we can
> risk making the display unhappy by eg. flipping the hsync polarity
> instead.
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Also add a comment documenting why we're doing this.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104848
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_atomic_transition.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 798639393421..aa9a6f8439ea 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -410,7 +410,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
>
> mode = igt_output_get_mode(output);
> override_mode = *mode;
> - override_mode.flags |= DRM_MODE_FLAG_HSKEW;
> + /* try to force a modeset */
> + override_mode.flags ^= DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC;
>
> igt_create_fb(display->drm_fd, mode->hdisplay, mode->vdisplay,
> DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
2018-01-30 15:51 ` Maarten Lankhorst
@ 2018-01-30 16:57 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2018-01-30 16:57 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
On Tue, Jan 30, 2018 at 04:51:09PM +0100, Maarten Lankhorst wrote:
> Op 30-01-18 om 16:49 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Since kernel commit e995ca0b8139 ("drm/i915: Provide a device level
> > .mode_valid() hook") i915 will bluntly reject the HSKEW mode flag. Thus
> > we can't abuse it to force a modeset.
> >
> > Since we don't particularly care about the visual results here we can
> > risk making the display unhappy by eg. flipping the hsync polarity
> > instead.
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Pushed, thanks.
> > Also add a comment documenting why we're doing this.
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104848
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/kms_atomic_transition.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> > index 798639393421..aa9a6f8439ea 100644
> > --- a/tests/kms_atomic_transition.c
> > +++ b/tests/kms_atomic_transition.c
> > @@ -410,7 +410,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
> >
> > mode = igt_output_get_mode(output);
> > override_mode = *mode;
> > - override_mode.flags |= DRM_MODE_FLAG_HSKEW;
> > + /* try to force a modeset */
> > + override_mode.flags ^= DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC;
> >
> > igt_create_fb(display->drm_fd, mode->hdisplay, mode->vdisplay,
> > DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
>
--
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
2018-01-30 15:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset Ville Syrjala
2018-01-30 15:51 ` Maarten Lankhorst
@ 2018-01-30 21:05 ` Patchwork
2018-02-28 12:20 ` Arkadiusz Hiler
1 sibling, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-01-30 21:05 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
URL : https://patchwork.freedesktop.org/series/37353/
State : failure
== Summary ==
Series 37353 revision 1 was fully merged or fully failed: no git log
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-28 12:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-30 15:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset Ville Syrjala
2018-01-30 15:51 ` Maarten Lankhorst
2018-01-30 16:57 ` Ville Syrjälä
2018-01-30 21:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-02-28 12:20 ` Arkadiusz Hiler
2018-02-28 12:46 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox