[igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

I missed these when sprinkling the memsets. Using stack garbage as the
aux surface state isn't a good idea. Causes kms_front_buffer_tracking
to fail on skl+.

Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index ebae915113da..c7d5770dca28 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 	drm_intel_bo *src, *dst;
 	uint32_t devid = intel_get_drm_devid(fd);
 	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
-	struct igt_buf src_buf, dst_buf;
+	struct igt_buf src_buf = {}, dst_buf = {};
 	struct intel_batchbuffer *batch;
 	uint32_t tiling, swizzle;
 	struct buf_data tmp;
-- 
2.16.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Chris Wilson]

Quoting Ville Syrjala (2018-07-06 17:39:40)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

And I'm still being lazy and only reviewing the patch in front of me...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Antonio Argenziano]

On 06/07/18 09:39, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   lib/igt_draw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index ebae915113da..c7d5770dca28 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>   	drm_intel_bo *src, *dst;
>   	uint32_t devid = intel_get_drm_devid(fd);
>   	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
> -	struct igt_buf src_buf, dst_buf;
> +	struct igt_buf src_buf = {}, dst_buf = {};
>   	struct intel_batchbuffer *batch;
>   	uint32_t tiling, swizzle;
>   	struct buf_data tmp;
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_draw: Zero initalize the igt_bufs

[Patchwork]

== Series Details ==

Series: lib/igt_draw: Zero initalize the igt_bufs
URL   : https://patchwork.freedesktop.org/series/46083/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4445 -> IGTPW_1541 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46083/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1541 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s3:
      {fi-cfl-8109u}:     INCOMPLETE -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).



== Participating hosts (47 -> 42) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4540 -> IGTPW_1541

  CI_DRM_4445: 366234e5605ce58f732d2aeb83c713dde6b7c85c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1541: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1541/
  IGT_4540: 78071c2fa53db2f04b8eddc6e6118be4fbc5c2fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1541/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_draw: Zero initalize the igt_bufs

[Patchwork]

== Series Details ==

Series: lib/igt_draw: Zero initalize the igt_bufs
URL   : https://patchwork.freedesktop.org/series/46083/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4540_full -> IGTPW_1541_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1541_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1541_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46083/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1541_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_cursor_legacy@pipe-b-torture-move:
      shard-apl:          PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS +1

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1541_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-glk:          PASS -> FAIL (fdo#107127, fdo#105347)

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> FAIL (fdo#106886)

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#105763, fdo#106538)

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#102887, fdo#105363)

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +2

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#105454, fdo#106509) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#102887, fdo#105363) -> PASS

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#103822) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-apl:          FAIL (fdo#107127, fdo#105347) -> INCOMPLETE (fdo#107127, fdo#103927)

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4540 -> IGTPW_1541
    * Linux: CI_DRM_4443 -> CI_DRM_4445

  CI_DRM_4443: 5c43ea095bbd1469a9c767529537ddf0434acc60 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4445: 366234e5605ce58f732d2aeb83c713dde6b7c85c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1541: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1541/
  IGT_4540: 78071c2fa53db2f04b8eddc6e6118be4fbc5c2fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1541/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_draw: Zero initalize the igt_bufs

[Patchwork]

== Series Details ==

Series: lib/igt_draw: Zero initalize the igt_bufs
URL   : https://patchwork.freedesktop.org/series/46083/
State : failure

== Summary ==

Series 46083 revision 1 was fully merged or fully failed: no git log

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1541/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev