[igt-dev] [PATCH i-g-t] igt/pm_backlight: Require a connected output for the backlight

[igt-dev] [PATCH i-g-t] igt/pm_backlight: Require a connected output for the backlight

[Chris Wilson]

We cannot control the backlight if its attached output is not connected.
Don't assert, but require.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/pm_backlight.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
index 33614e969..e94340a2b 100644
--- a/tests/pm_backlight.c
+++ b/tests/pm_backlight.c
@@ -225,7 +225,9 @@ igt_main
 			break;
 		}
 
-		igt_assert_f(found, "Could not map \"%s\" to output (%s?)\n", name, name + 6);
+		igt_require_f(found,
+			      "Could not map backlight for \"%s\" to connected output\n",
+			      name);
 
 		igt_output_set_pipe(output, pipe);
 		mode = igt_output_get_mode(output);
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_backlight: Require a connected output for the backlight

[Patchwork]

== Series Details ==

Series: igt/pm_backlight: Require a connected output for the backlight
URL   : https://patchwork.freedesktop.org/series/49154/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4767 -> IGTPW_1787 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1787 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1787, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49154/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1787:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@module-reload:
      fi-skl-6600u:       PASS -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_1787 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-kbl-soraka:      NOTRUN -> INCOMPLETE (fdo#107774, fdo#107556)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s3:
      fi-cfl-8109u:       DMESG-WARN (fdo#107345) -> PASS +1

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#107139, fdo#105128) -> PASS

    igt@kms_flip@basic-flip-vs-modeset:
      fi-cfl-8109u:       INCOMPLETE (fdo#107468) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         FAIL (fdo#107336) -> PASS

    igt@pm_rpm@module-reload:
      fi-bsw-kefka:       DMESG-WARN (fdo#107704) -> PASS
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> PASS
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> PASS
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107468 https://bugs.freedesktop.org/show_bug.cgi?id=107468
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774


== Participating hosts (50 -> 45) ==

  Additional (1): fi-kbl-soraka 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-caroline 


== Build changes ==

    * IGT: IGT_4626 -> IGTPW_1787

  CI_DRM_4767: e9b69bafd3c2c13a8b9fa8e7a410f5d5ef32e328 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1787: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1787/
  IGT_4626: bfce01d8c93dbd86e6ab04ca1afb844e0cbc8078 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1787/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] igt/pm_backlight: Require a connected output for the backlight

[Dhinakaran Pandiyan]

On Tue, 2018-09-04 at 22:34 +0100, Chris Wilson wrote:
> We cannot control the backlight if its attached output is not
> connected.
> Don't assert, but require.
Makes sense.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/pm_backlight.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
> index 33614e969..e94340a2b 100644
> --- a/tests/pm_backlight.c
> +++ b/tests/pm_backlight.c
> @@ -225,7 +225,9 @@ igt_main
>  			break;
>  		}
>  
> -		igt_assert_f(found, "Could not map \"%s\" to output
> (%s?)\n", name, name + 6);
> +		igt_require_f(found,
> +			      "Could not map backlight for \"%s\" to
> connected output\n",
> +			      name);
>  
>  		igt_output_set_pipe(output, pipe);
>  		mode = igt_output_get_mode(output);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev