[igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.

[igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.

[Stanislav Lisovskiy]

Despite the comment temporary buf is not
used anywhere in convert_nv12_to_rgb24,
so it has to be either removed or used instead
of cvt->src.ptr.

v2: Put it in use instead of removing as other
functions seem to use it.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 lib/igt_fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4700b152..5e775c44 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1538,8 +1538,8 @@ static void convert_nv12_to_rgb24(struct fb_convert *cvt)
 	 * from there.
 	 */
 	igt_memcpy_from_wc(buf, cvt->src.ptr, cvt->src.fb->size);
-	y = cvt->src.ptr + cvt->src.fb->offsets[0];
-	uv = cvt->src.ptr + cvt->src.fb->offsets[1];
+	y = buf + cvt->src.fb->offsets[0];
+	uv = buf + cvt->src.fb->offsets[1];
 
 	for (i = 0; i < cvt->dst.fb->height / 2; i++) {
 		for (j = 0; j < cvt->dst.fb->width / 2; j++) {
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Fix unused variable buf.

[Patchwork]

== Series Details ==

Series: lib/igt_fb: Fix unused variable buf.
URL   : https://patchwork.freedesktop.org/series/51595/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5041 -> IGTPW_1998 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1998 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1998, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51595/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1998:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         PASS -> DMESG-FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1998 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       PASS -> FAIL (fdo#103928)

    igt@kms_flip@basic-plain-flip:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106097)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362)

    igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)

    igt@pm_rpm@basic-rte:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (44 -> 43) ==

  Additional (1): fi-byt-j1900 
  Missing    (2): fi-ilk-m540 fi-bsw-cyan 


== Build changes ==

    * IGT: IGT_4695 -> IGTPW_1998

  CI_DRM_5041: a45f611eae66546bb297a81c88e89bfd409bf199 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1998: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1998/
  IGT_4695: 81b66cf2806d6a8e9516580fb31879677487d32b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1998/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Fix unused variable buf.

[Patchwork]

== Series Details ==

Series: lib/igt_fb: Fix unused variable buf.
URL   : https://patchwork.freedesktop.org/series/51595/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5042 -> IGTPW_2000 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2000 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2000, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51595/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2000:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_contexts:
      fi-icl-u2:          NOTRUN -> DMESG-FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_2000 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#108070)

    igt@gem_exec_suspend@basic-s3:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#106612)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-icl-u2:          NOTRUN -> FAIL (fdo#108559) +3

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7560u:       INCOMPLETE (fdo#108044) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-icl-u:           INCOMPLETE (fdo#107713) -> PASS

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#106612 https://bugs.freedesktop.org/show_bug.cgi?id=106612
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#108044 https://bugs.freedesktop.org/show_bug.cgi?id=108044
  fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
  fdo#108559 https://bugs.freedesktop.org/show_bug.cgi?id=108559


== Participating hosts (48 -> 43) ==

  Additional (1): fi-icl-u2 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005 


== Build changes ==

    * IGT: IGT_4696 -> IGTPW_2000

  CI_DRM_5042: 591c74093dc70bdceaa02441c494dd7090533564 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2000: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2000/
  IGT_4696: ff2db94acb53543acd7ba4e2badff59807069365 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2000/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.

[Maarten Lankhorst]

Op 26-10-18 om 14:03 schreef Stanislav Lisovskiy:
> Despite the comment temporary buf is not
> used anywhere in convert_nv12_to_rgb24,
> so it has to be either removed or used instead
> of cvt->src.ptr.
>
> v2: Put it in use instead of removing as other
> functions seem to use it.
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
>  lib/igt_fb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4700b152..5e775c44 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1538,8 +1538,8 @@ static void convert_nv12_to_rgb24(struct fb_convert *cvt)
>  	 * from there.
>  	 */
>  	igt_memcpy_from_wc(buf, cvt->src.ptr, cvt->src.fb->size);
> -	y = cvt->src.ptr + cvt->src.fb->offsets[0];
> -	uv = cvt->src.ptr + cvt->src.fb->offsets[1];
> +	y = buf + cvt->src.fb->offsets[0];
> +	uv = buf + cvt->src.fb->offsets[1];
>  
>  	for (i = 0; i < cvt->dst.fb->height / 2; i++) {
>  		for (j = 0; j < cvt->dst.fb->width / 2; j++) {

Much better!

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.

[Ville Syrjälä]

On Fri, Oct 26, 2018 at 05:57:16PM +0200, Maarten Lankhorst wrote:
> Op 26-10-18 om 14:03 schreef Stanislav Lisovskiy:
> > Despite the comment temporary buf is not
> > used anywhere in convert_nv12_to_rgb24,
> > so it has to be either removed or used instead
> > of cvt->src.ptr.
> >
> > v2: Put it in use instead of removing as other
> > functions seem to use it.
> >
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> >  lib/igt_fb.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 4700b152..5e775c44 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -1538,8 +1538,8 @@ static void convert_nv12_to_rgb24(struct fb_convert *cvt)
> >  	 * from there.
> >  	 */
> >  	igt_memcpy_from_wc(buf, cvt->src.ptr, cvt->src.fb->size);
> > -	y = cvt->src.ptr + cvt->src.fb->offsets[0];
> > -	uv = cvt->src.ptr + cvt->src.fb->offsets[1];
> > +	y = buf + cvt->src.fb->offsets[0];
> > +	uv = buf + cvt->src.fb->offsets[1];
> >  
> >  	for (i = 0; i < cvt->dst.fb->height / 2; i++) {
> >  		for (j = 0; j < cvt->dst.fb->width / 2; j++) {
> 
> Much better!
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Pushed. Thanks for the patch and review.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev