[igt-dev] [PATCH i-g-t] tests/gem_ctx_param: Missing igt_fixture

* [igt-dev] [PATCH i-g-t] tests/gem_ctx_param: Missing igt_fixture
@ 2018-11-26 14:24 Daniel Vetter
  2018-11-26 14:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-11-26 17:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-11-26 14:24 UTC (permalink / raw)
  To: IGT development; +Cc: Petri Latvala, Daniel Vetter

It's not cool to run an ioctl outside of igt_fixture.

Reported-by: Petri Latvala <petri.latvala@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/i915/gem_ctx_param.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
index c46fd709b0d7..0bbc5effbf9f 100644
--- a/tests/i915/gem_ctx_param.c
+++ b/tests/i915/gem_ctx_param.c
@@ -156,14 +156,14 @@ igt_main
 
 		gem_require_contexts(fd);
 		ctx = gem_context_create(fd);
-	}
 
-	arg.param = I915_CONTEXT_PARAM_BAN_PERIOD;
+		arg.param = I915_CONTEXT_PARAM_BAN_PERIOD;
 
-	/* XXX start to enforce ban period returning -EINVAL when
-	 * transition has been done */
-	if (__gem_context_get_param(fd, &arg) == -EINVAL)
-		arg.param = I915_CONTEXT_PARAM_BANNABLE;
+		/* XXX start to enforce ban period returning -EINVAL when
+		 * transition has been done */
+		if (__gem_context_get_param(fd, &arg) == -EINVAL)
+			arg.param = I915_CONTEXT_PARAM_BANNABLE;
+	}
 
 	igt_subtest("basic") {
 		arg.ctx_id = ctx;
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread