* [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion
@ 2018-12-07 9:01 Paul Kocialkowski
2018-12-07 9:12 ` Maxime Ripard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paul Kocialkowski @ 2018-12-07 9:01 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala, Thomas Petazzoni
Pixman requires buffer strides the be aligned to 32-bit words in order
to create internal representations of buffers. If this condition is not
met, it will fail and IGT will not be able to report the error cause,
making it hard to debug the issue.
Add an explicit check in our code prior to calling pixman when
converting buffer so that the error can be understood if it occurs.
---
lib/igt_fb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 2462d6ba..513a66b7 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1901,6 +1901,10 @@ static void convert_pixman(struct fb_convert *cvt)
igt_assert((src_pixman != PIXMAN_invalid) &&
(dst_pixman != PIXMAN_invalid));
+ /* Pixman requires the stride to be aligned to 32 bits. */
+ igt_assert((cvt->src.fb->strides[0] % sizeof(uint32_t)) == 0);
+ igt_assert((cvt->dst.fb->strides[0] % sizeof(uint32_t)) == 0);
+
src_ptr = convert_src_get(cvt);
src_image = pixman_image_create_bits(src_pixman,
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion
2018-12-07 9:01 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
@ 2018-12-07 9:12 ` Maxime Ripard
2018-12-07 9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-07 15:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-12-07 9:12 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: igt-dev, Petri Latvala, Thomas Petazzoni
[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]
On Fri, Dec 07, 2018 at 10:01:46AM +0100, Paul Kocialkowski wrote:
> Pixman requires buffer strides the be aligned to 32-bit words in order
> to create internal representations of buffers. If this condition is not
> met, it will fail and IGT will not be able to report the error cause,
> making it hard to debug the issue.
>
> Add an explicit check in our code prior to calling pixman when
> converting buffer so that the error can be understood if it occurs.
Missing SoB.
Otherwise,
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Add a check on stride alignment for pixman conversion
2018-12-07 9:01 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-07 9:12 ` Maxime Ripard
@ 2018-12-07 9:40 ` Patchwork
2018-12-07 15:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-12-07 9:40 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: igt-dev
== Series Details ==
Series: lib/igt_fb: Add a check on stride alignment for pixman conversion
URL : https://patchwork.freedesktop.org/series/53728/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5280 -> IGTPW_2132
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53728/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2132 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
Participating hosts (45 -> 43)
------------------------------
Additional (3): fi-skl-guc fi-skl-6600u fi-pnv-d510
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y
Build changes
-------------
* IGT: IGT_4743 -> IGTPW_2132
CI_DRM_5280: 6047933c2fafdfd42353d735b213e74826d5a939 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2132: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2132/
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2132/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_fb: Add a check on stride alignment for pixman conversion
2018-12-07 9:01 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-07 9:12 ` Maxime Ripard
2018-12-07 9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-07 15:10 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-12-07 15:10 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: igt-dev
== Series Details ==
Series: lib/igt_fb: Add a check on stride alignment for pixman conversion
URL : https://patchwork.freedesktop.org/series/53728/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5280_full -> IGTPW_2132_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2132_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2132_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53728/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2132_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@extended-semaphore-blt:
- shard-hsw: PASS -> FAIL
#### Warnings ####
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2132_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-render:
- shard-glk: NOTRUN -> FAIL [fdo#103158]
* igt@kms_atomic_transition@5x-modeset-transitions:
- shard-snb: SKIP -> INCOMPLETE [fdo#105411] / [fdo#107469]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +7
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166]
* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: PASS -> DMESG-WARN [fdo#105604]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-glk: NOTRUN -> FAIL [fdo#103166]
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
* igt@kms_busy@basic-modeset-a:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +8
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS +1
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-glk: FAIL [fdo#103167] -> PASS +2
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +2
- shard-apl: FAIL [fdo#103166] -> PASS
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
#### Warnings ####
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#103166]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4743 -> IGTPW_2132
* Piglit: piglit_4509 -> None
CI_DRM_5280: 6047933c2fafdfd42353d735b213e74826d5a939 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2132: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2132/
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2132/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-07 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-07 9:01 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-07 9:12 ` Maxime Ripard
2018-12-07 9:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-07 15:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox