public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding
@ 2019-01-03 16:54 Paul Kocialkowski
  2019-01-03 17:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Paul Kocialkowski @ 2019-01-03 16:54 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Thomas Petazzoni

Add missing parenthesis in the macro coding the vertical pulse high
bits. Without them, the shift takes precedence over the logical and
operation, which is not how these bits should be coded according to
the spec.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
 lib/igt_edid_template.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_edid_template.h b/lib/igt_edid_template.h
index de421e080a88..8dbd19caea4c 100644
--- a/lib/igt_edid_template.h
+++ b/lib/igt_edid_template.h
@@ -8,7 +8,7 @@
 #define op(ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \
 		(((vo) & 0xf) << 4) | ((vp) & 0xf), \
 		(((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \
-		| (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4)
+		| (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)
 
 static unsigned char EDID_NAME[EDID_LENGTH] = {
 	0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, /* header */
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-01-18 15:18 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-03 16:54 [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding Paul Kocialkowski
2019-01-03 17:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-03 18:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-07 14:39 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-01-14 14:20 ` Paul Kocialkowski
2019-01-14 19:25   ` Antonio Argenziano
2019-01-15  9:29   ` Jani Nikula
2019-01-18 15:17     ` Paul Kocialkowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox