From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Petri Latvala <petri.latvala@intel.com>,
Eben Upton <eben@raspberrypi.org>,
igt-dev@lists.freedesktop.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t v3 12/21] lib/igt_vc4: Add helper for checking SAND tiling support on plane
Date: Fri, 11 Jan 2019 16:15:18 +0100 [thread overview]
Message-ID: <20190111151518.u4bbdgpr3syflhbq@flea> (raw)
In-Reply-To: <20190111090532.19235-13-paul.kocialkowski@bootlin.com>
[-- Attachment #1.1: Type: text/plain, Size: 1663 bytes --]
On Fri, Jan 11, 2019 at 10:05:23AM +0100, Paul Kocialkowski wrote:
> This introduces a convenience helper for checking whether a plane
> supports SAND tiling for a given format.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> lib/igt_vc4.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/lib/igt_vc4.h b/lib/igt_vc4.h
> index 9118ae193f60..cb980541a61f 100644
> --- a/lib/igt_vc4.h
> +++ b/lib/igt_vc4.h
> @@ -33,6 +33,30 @@ static inline bool igt_vc4_plane_supports_t_tiling(igt_plane_t *plane,
> DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED);
> }
>
> +static inline bool igt_vc4_plane_supports_sand_tiling(igt_plane_t *plane,
> + uint32_t format,
> + size_t column_width_bytes)
> +{
> + uint64_t modifier;
> +
> + switch (column_width_bytes) {
> + case 32:
> + modifier = DRM_FORMAT_MOD_BROADCOM_SAND32;
> + break;
> + case 64:
> + modifier = DRM_FORMAT_MOD_BROADCOM_SAND64;
> + break;
> + case 128:
> + modifier = DRM_FORMAT_MOD_BROADCOM_SAND128;
> + break;
> + case 256:
> + modifier = DRM_FORMAT_MOD_BROADCOM_SAND256;
> + break;
> + }
> +
> + return igt_plane_has_format_mod(plane, format, modifier);
> +}
> +
I'm not quite sure what that function is supposed to be doing, or
rather, why do you need the column_width_bytes parameter.
If that function was just about checking whether the sand tiling is
supported, then you can just return an or'd igt_plane_has_format_mod
of all the modifiers supported, right?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-11 15:15 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:05 [igt-dev] [PATCH i-g-t v3 00/21] Chamelium VC4 plane fuzzy testing, with SAND and T-tiled mode Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 01/21] lib: drmtest: Add helpers to check and require the VC4 driver Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 02/21] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:39 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 03/21] lib/igt_fb: Add support for allocating T-tiled VC4 buffers Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:41 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 04/21] lib/igt_fb: Add support for VC4 SAND tiling modes Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:43 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 05/21] lib/igt_fb: Allow interpreting the tile height as a stride equivalent Paul Kocialkowski
2019-01-11 15:10 ` Maxime Ripard
2019-01-15 0:45 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 06/21] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 07/21] lib/igt_fb: Add a helper to retreive the plane bpp for a given format Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 08/21] lib/igt_fb: Add a helper to fill-in the available DRM formats Paul Kocialkowski
2019-01-15 20:49 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 09/21] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers Paul Kocialkowski
2019-01-11 15:25 ` Maxime Ripard
2019-01-14 14:57 ` Paul Kocialkowski
2019-01-15 21:20 ` Lyude Paul
2019-01-22 16:07 ` Paul Kocialkowski
2019-01-22 17:47 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 10/21] lib/igt_vc4: Add helper for checking T-tiling support on plane Paul Kocialkowski
2019-01-11 15:11 ` Maxime Ripard
2019-01-15 21:49 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 11/21] lib/igt_vc4: Add helpers for converting linear to SAND-tiled buffers Paul Kocialkowski
2019-01-15 21:53 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 12/21] lib/igt_vc4: Add helper for checking SAND tiling support on plane Paul Kocialkowski
2019-01-11 15:15 ` Maxime Ripard [this message]
2019-01-14 15:01 ` Paul Kocialkowski
2019-01-15 8:25 ` Maxime Ripard
2019-01-15 21:54 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 13/21] lib/igt_kms: Add helpers to count and iterate planes from pipe Paul Kocialkowski
2019-01-11 15:11 ` Maxime Ripard
2019-01-15 21:57 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 14/21] lib/igt_kms: Add helpers to count and iterate planes from output Paul Kocialkowski
2019-01-11 15:12 ` Maxime Ripard
2019-01-15 22:00 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 15/21] lib/igt_chamelium: Fixup resources liberation in comparison helpers Paul Kocialkowski
2019-01-11 15:15 ` Maxime Ripard
2019-01-15 22:01 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 16/21] lib/igt_chamelium: Split frames dump logic and rework surroundings Paul Kocialkowski
2019-01-11 15:16 ` Maxime Ripard
2019-01-15 22:05 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 17/21] lib/igt_chamelium: Generalize the frame match helper with check type Paul Kocialkowski
2019-01-11 15:17 ` Maxime Ripard
2019-01-15 22:07 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 18/21] lib/igt_frame: Add a checkerboard frame comparison method Paul Kocialkowski
2019-01-11 15:19 ` Maxime Ripard
2019-01-14 15:04 ` Paul Kocialkowski
2019-01-15 16:13 ` Maxime Ripard
2019-01-15 22:14 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 19/21] lib/igt_chamelium: Hook-in checkerboard comparison method in helpers Paul Kocialkowski
2019-01-11 15:19 ` Maxime Ripard
2019-01-15 22:14 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 20/21] chamelium: Move the YUV tests over to the checkerboard checking method Paul Kocialkowski
2019-01-11 15:20 ` Maxime Ripard
2019-01-15 22:15 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 21/21] chamelium: Add a display test for randomized planes Paul Kocialkowski
2019-01-11 15:23 ` Maxime Ripard
2019-01-15 22:56 ` Lyude Paul
2019-01-25 13:58 ` Paul Kocialkowski
2019-01-11 9:29 ` [igt-dev] ✗ Fi.CI.BAT: failure for Chamelium VC4 plane fuzzy testing, with SAND and T-tiled mode Patchwork
2019-01-15 0:46 ` [igt-dev] [PATCH i-g-t v3 00/21] " Lyude Paul
2019-01-15 9:34 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111151518.u4bbdgpr3syflhbq@flea \
--to=maxime.ripard@bootlin.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox