From: Lyude Paul <lyude@redhat.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
Eben Upton <eben@raspberrypi.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t v3 15/21] lib/igt_chamelium: Fixup resources liberation in comparison helpers
Date: Tue, 15 Jan 2019 17:01:11 -0500 [thread overview]
Message-ID: <5c17eb0157b6326f1871dff3d0c4ef19770a9601.camel@redhat.com> (raw)
In-Reply-To: <20190111090532.19235-16-paul.kocialkowski@bootlin.com>
Nice catch here!
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2019-01-11 at 10:05 +0100, Paul Kocialkowski wrote:
> This fixes a bunch of occurrences of memory not being properly
> liberated after its use in helpers revolving around frame/CRC
> comparison.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> lib/igt_chamelium.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index 32b859eac4a7..0b6ac37a3d89 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -1060,9 +1060,9 @@ void chamelium_assert_crc_eq_or_dump(struct chamelium
> *chamelium,
> free(reference_suffix);
> free(capture_suffix);
>
> - chamelium_destroy_frame_dump(frame);
> -
> + cairo_surface_destroy(reference);
> cairo_surface_destroy(capture);
> + chamelium_destroy_frame_dump(frame);
> }
>
> igt_assert(eq);
> @@ -1120,11 +1120,14 @@ void
> chamelium_assert_analog_frame_match_or_dump(struct chamelium *chamelium,
>
> free(reference_suffix);
> free(capture_suffix);
> + free(reference_crc);
> + free(capture_crc);
> }
>
> - cairo_surface_destroy(capture);
> -
> igt_assert(match);
> +
> + cairo_surface_destroy(reference);
> + cairo_surface_destroy(capture);
> }
>
>
> @@ -1323,6 +1326,8 @@ igt_crc_t *chamelium_calculate_fb_crc(int fd, struct
> igt_fb *fb)
>
> chamelium_do_calculate_fb_crc(fb_surface, ret);
>
> + cairo_surface_destroy(fb_surface);
> +
> return ret;
> }
>
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-15 22:01 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:05 [igt-dev] [PATCH i-g-t v3 00/21] Chamelium VC4 plane fuzzy testing, with SAND and T-tiled mode Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 01/21] lib: drmtest: Add helpers to check and require the VC4 driver Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 02/21] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:39 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 03/21] lib/igt_fb: Add support for allocating T-tiled VC4 buffers Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:41 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 04/21] lib/igt_fb: Add support for VC4 SAND tiling modes Paul Kocialkowski
2019-01-11 15:09 ` Maxime Ripard
2019-01-15 0:43 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 05/21] lib/igt_fb: Allow interpreting the tile height as a stride equivalent Paul Kocialkowski
2019-01-11 15:10 ` Maxime Ripard
2019-01-15 0:45 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 06/21] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 07/21] lib/igt_fb: Add a helper to retreive the plane bpp for a given format Paul Kocialkowski
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 08/21] lib/igt_fb: Add a helper to fill-in the available DRM formats Paul Kocialkowski
2019-01-15 20:49 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 09/21] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers Paul Kocialkowski
2019-01-11 15:25 ` Maxime Ripard
2019-01-14 14:57 ` Paul Kocialkowski
2019-01-15 21:20 ` Lyude Paul
2019-01-22 16:07 ` Paul Kocialkowski
2019-01-22 17:47 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 10/21] lib/igt_vc4: Add helper for checking T-tiling support on plane Paul Kocialkowski
2019-01-11 15:11 ` Maxime Ripard
2019-01-15 21:49 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 11/21] lib/igt_vc4: Add helpers for converting linear to SAND-tiled buffers Paul Kocialkowski
2019-01-15 21:53 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 12/21] lib/igt_vc4: Add helper for checking SAND tiling support on plane Paul Kocialkowski
2019-01-11 15:15 ` Maxime Ripard
2019-01-14 15:01 ` Paul Kocialkowski
2019-01-15 8:25 ` Maxime Ripard
2019-01-15 21:54 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 13/21] lib/igt_kms: Add helpers to count and iterate planes from pipe Paul Kocialkowski
2019-01-11 15:11 ` Maxime Ripard
2019-01-15 21:57 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 14/21] lib/igt_kms: Add helpers to count and iterate planes from output Paul Kocialkowski
2019-01-11 15:12 ` Maxime Ripard
2019-01-15 22:00 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 15/21] lib/igt_chamelium: Fixup resources liberation in comparison helpers Paul Kocialkowski
2019-01-11 15:15 ` Maxime Ripard
2019-01-15 22:01 ` Lyude Paul [this message]
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 16/21] lib/igt_chamelium: Split frames dump logic and rework surroundings Paul Kocialkowski
2019-01-11 15:16 ` Maxime Ripard
2019-01-15 22:05 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 17/21] lib/igt_chamelium: Generalize the frame match helper with check type Paul Kocialkowski
2019-01-11 15:17 ` Maxime Ripard
2019-01-15 22:07 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 18/21] lib/igt_frame: Add a checkerboard frame comparison method Paul Kocialkowski
2019-01-11 15:19 ` Maxime Ripard
2019-01-14 15:04 ` Paul Kocialkowski
2019-01-15 16:13 ` Maxime Ripard
2019-01-15 22:14 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 19/21] lib/igt_chamelium: Hook-in checkerboard comparison method in helpers Paul Kocialkowski
2019-01-11 15:19 ` Maxime Ripard
2019-01-15 22:14 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 20/21] chamelium: Move the YUV tests over to the checkerboard checking method Paul Kocialkowski
2019-01-11 15:20 ` Maxime Ripard
2019-01-15 22:15 ` Lyude Paul
2019-01-11 9:05 ` [igt-dev] [PATCH i-g-t v3 21/21] chamelium: Add a display test for randomized planes Paul Kocialkowski
2019-01-11 15:23 ` Maxime Ripard
2019-01-15 22:56 ` Lyude Paul
2019-01-25 13:58 ` Paul Kocialkowski
2019-01-11 9:29 ` [igt-dev] ✗ Fi.CI.BAT: failure for Chamelium VC4 plane fuzzy testing, with SAND and T-tiled mode Patchwork
2019-01-15 0:46 ` [igt-dev] [PATCH i-g-t v3 00/21] " Lyude Paul
2019-01-15 9:34 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c17eb0157b6326f1871dff3d0c4ef19770a9601.camel@redhat.com \
--to=lyude@redhat.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox