public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU)
@ 2019-01-11 16:19 Chris Wilson
  2019-01-11 17:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-01-11 16:19 UTC (permalink / raw)
  To: igt-dev; +Cc: Martin Peres

Just use the normal library function, with the normal warning message
for an unmatched GPU so that CI buglog can filter it.

References: https://bugs.freedesktop.org/show_bug.cgi?id=109315
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@free.fr>
---
 tests/amdgpu/amd_basic.c  | 3 +--
 tests/amdgpu/amd_cs_nop.c | 3 +--
 tests/amdgpu/amd_prime.c  | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
index 9f21de65b..d3c060e32 100644
--- a/tests/amdgpu/amd_basic.c
+++ b/tests/amdgpu/amd_basic.c
@@ -1384,8 +1384,7 @@ igt_main
 		uint32_t major, minor;
 		int err;
 
-		fd = __drm_open_driver(DRIVER_AMDGPU);
-		igt_require(fd >= 0);
+		fd = drm_open_driver(DRIVER_AMDGPU);
 
 		err = amdgpu_device_initialize(fd, &major, &minor, &device);
 		igt_require(err == 0);
diff --git a/tests/amdgpu/amd_cs_nop.c b/tests/amdgpu/amd_cs_nop.c
index c5ea66aa5..46f4b7c65 100644
--- a/tests/amdgpu/amd_cs_nop.c
+++ b/tests/amdgpu/amd_cs_nop.c
@@ -219,8 +219,7 @@ igt_main
 		uint32_t major, minor;
 		int err;
 
-		fd = __drm_open_driver(DRIVER_AMDGPU);
-		igt_require(fd >= 0);
+		fd = drm_open_driver(DRIVER_AMDGPU);
 
 		err = amdgpu_device_initialize(fd, &major, &minor, &device);
 		igt_require(err == 0);
diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
index 518c88963..dc71ac70c 100644
--- a/tests/amdgpu/amd_prime.c
+++ b/tests/amdgpu/amd_prime.c
@@ -437,7 +437,7 @@ igt_main
 		igt_require_gem(i915);
 		igt_require(gem_has_exec_fence(i915));
 
-		amd = __drm_open_driver(DRIVER_AMDGPU);
+		amd = drm_open_driver(DRIVER_AMDGPU);
 		err = amdgpu_device_initialize(amd, &major, &minor, &device);
 		igt_require(err == 0);
 	}
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for amd: Use drm_open_driver(AMDGPU)
  2019-01-11 16:19 [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU) Chris Wilson
@ 2019-01-11 17:01 ` Patchwork
  2019-01-11 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2019-01-14 10:55 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-11 17:01 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amd: Use drm_open_driver(AMDGPU)
URL   : https://patchwork.freedesktop.org/series/55077/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5404 -> IGTPW_2226
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/55077/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2226:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@amdgpu/amd_cs_nop@fork-gfx0:
    - fi-icl-u2:          NOTRUN -> {SKIP} +17

  
Known issues
------------

  Here are the changes found in IGTPW_2226 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-icl-u2:          NOTRUN -> DMESG-FAIL [fdo#108569]

  * igt@pm_rpm@module-reload:
    - fi-skl-6700hq:      PASS -> INCOMPLETE [fdo#107807]

  
#### Possible fixes ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       FAIL [fdo#108767] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316


Participating hosts (45 -> 43)
------------------------------

  Additional (3): fi-byt-j1900 fi-icl-u2 fi-hsw-peppy 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4763 -> IGTPW_2226

  CI_DRM_5404: c51dc608699b2dcfe6d2f6981773f98d1b9f0c86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2226: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2226/
  IGT_4763: 805a99409542d7d72dda3b6dcd284a8869a3de16 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2226/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for amd: Use drm_open_driver(AMDGPU)
  2019-01-11 16:19 [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU) Chris Wilson
  2019-01-11 17:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-11 21:48 ` Patchwork
  2019-01-14 10:55 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-11 21:48 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amd: Use drm_open_driver(AMDGPU)
URL   : https://patchwork.freedesktop.org/series/55077/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5404_full -> IGTPW_2226_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/55077/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2226_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          PASS -> FAIL [fdo#106641]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145] +1

  * igt@kms_color@pipe-c-legacy-gamma:
    - shard-apl:          PASS -> FAIL [fdo#104782]

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-256x256-sliding:
    - shard-glk:          PASS -> FAIL [fdo#103232] +6

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          PASS -> FAIL [fdo#103167] +7

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-glk:          PASS -> FAIL [fdo#108948]

  * igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
    - shard-apl:          PASS -> FAIL [fdo#108948] +1

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
    - shard-apl:          PASS -> FAIL [fdo#103166] +1

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
    - shard-glk:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-glk:          PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vecs0-dirty-switch:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_color@pipe-b-degamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-256x85-random:
    - shard-glk:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +7

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
    - shard-glk:          FAIL [fdo#107791] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          FAIL [fdo#103167] -> PASS +7

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - shard-glk:          FAIL [fdo#103167] / [fdo#105682] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
    - shard-glk:          FAIL [fdo#103167] -> PASS +4

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
    - shard-glk:          FAIL [fdo#108145] -> PASS +4

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          {SKIP} [fdo#109271] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#107791]: https://bugs.freedesktop.org/show_bug.cgi?id=107791
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 4)
------------------------------

  Missing    (3): shard-skl shard-kbl shard-iclb 


Build changes
-------------

    * IGT: IGT_4763 -> IGTPW_2226
    * Piglit: piglit_4509 -> None

  CI_DRM_5404: c51dc608699b2dcfe6d2f6981773f98d1b9f0c86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2226: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2226/
  IGT_4763: 805a99409542d7d72dda3b6dcd284a8869a3de16 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2226/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU)
  2019-01-11 16:19 [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU) Chris Wilson
  2019-01-11 17:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-01-11 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-14 10:55 ` Petri Latvala
  2 siblings, 0 replies; 4+ messages in thread
From: Petri Latvala @ 2019-01-14 10:55 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, Martin Peres

On Fri, Jan 11, 2019 at 04:19:42PM +0000, Chris Wilson wrote:
> Just use the normal library function, with the normal warning message
> for an unmatched GPU so that CI buglog can filter it.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109315
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@free.fr>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>

> ---
>  tests/amdgpu/amd_basic.c  | 3 +--
>  tests/amdgpu/amd_cs_nop.c | 3 +--
>  tests/amdgpu/amd_prime.c  | 2 +-
>  3 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
> index 9f21de65b..d3c060e32 100644
> --- a/tests/amdgpu/amd_basic.c
> +++ b/tests/amdgpu/amd_basic.c
> @@ -1384,8 +1384,7 @@ igt_main
>  		uint32_t major, minor;
>  		int err;
>  
> -		fd = __drm_open_driver(DRIVER_AMDGPU);
> -		igt_require(fd >= 0);
> +		fd = drm_open_driver(DRIVER_AMDGPU);
>  
>  		err = amdgpu_device_initialize(fd, &major, &minor, &device);
>  		igt_require(err == 0);
> diff --git a/tests/amdgpu/amd_cs_nop.c b/tests/amdgpu/amd_cs_nop.c
> index c5ea66aa5..46f4b7c65 100644
> --- a/tests/amdgpu/amd_cs_nop.c
> +++ b/tests/amdgpu/amd_cs_nop.c
> @@ -219,8 +219,7 @@ igt_main
>  		uint32_t major, minor;
>  		int err;
>  
> -		fd = __drm_open_driver(DRIVER_AMDGPU);
> -		igt_require(fd >= 0);
> +		fd = drm_open_driver(DRIVER_AMDGPU);
>  
>  		err = amdgpu_device_initialize(fd, &major, &minor, &device);
>  		igt_require(err == 0);
> diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
> index 518c88963..dc71ac70c 100644
> --- a/tests/amdgpu/amd_prime.c
> +++ b/tests/amdgpu/amd_prime.c
> @@ -437,7 +437,7 @@ igt_main
>  		igt_require_gem(i915);
>  		igt_require(gem_has_exec_fence(i915));
>  
> -		amd = __drm_open_driver(DRIVER_AMDGPU);
> +		amd = drm_open_driver(DRIVER_AMDGPU);
>  		err = amdgpu_device_initialize(amd, &major, &minor, &device);
>  		igt_require(err == 0);
>  	}
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-14 10:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-11 16:19 [igt-dev] [PATCH i-g-t] amd: Use drm_open_driver(AMDGPU) Chris Wilson
2019-01-11 17:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-11 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-14 10:55 ` [igt-dev] [PATCH i-g-t] " Petri Latvala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox