* [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling
@ 2019-01-18 21:18 Chris Wilson
2019-01-18 21:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-01-18 21:18 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
If the device has error capturing disabled, we still allow previous
error state to be cleared by a write to sysfs/error. To actually confirm
that we can capture a fresh error state, we have to perform a read().
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_capture.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
index f26b4102c..49394c311 100644
--- a/tests/i915/gem_exec_capture.c
+++ b/tests/i915/gem_exec_capture.c
@@ -544,6 +544,7 @@ igt_main
dir = igt_sysfs_open(fd, NULL);
igt_require(igt_sysfs_set(dir, "error", "Begone!"));
+ igt_require(igt_sysfs_get(dir, "error"));
}
for (e = intel_execution_engines; e->name; e++) {
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_capture: Really confirm error capturing is enabling
2019-01-18 21:18 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling Chris Wilson
@ 2019-01-18 21:59 ` Patchwork
2019-01-19 0:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-24 14:34 ` [igt-dev] [PATCH i-g-t] " Katarzyna Dec
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-18 21:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_capture: Really confirm error capturing is enabling
URL : https://patchwork.freedesktop.org/series/55428/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5450 -> IGTPW_2262
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55428/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2262 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@gem_basic@create-close:
- fi-skl-6770hq: PASS -> DMESG-WARN [fdo#105541]
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] +1
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602] / [fdo#108529] +1
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-7567u: PASS -> FAIL [fdo#108767] +2
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-kbl-7567u: PASS -> DMESG-FAIL [fdo#105079]
* igt@pm_rpm@module-reload:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#108529]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (47 -> 42)
------------------------------
Additional (1): fi-gdg-551
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-skl-6600u
Build changes
-------------
* IGT: IGT_4778 -> IGTPW_2262
CI_DRM_5450: e8e22735052e88c3a169acc3be7989041a64f338 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2262: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2262/
IGT_4778: 0c80bd7f2a964605f307e0220c6bb756685582b9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2262/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_capture: Really confirm error capturing is enabling
2019-01-18 21:18 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling Chris Wilson
2019-01-18 21:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-19 0:42 ` Patchwork
2019-01-24 14:34 ` [igt-dev] [PATCH i-g-t] " Katarzyna Dec
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-19 0:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_capture: Really confirm error capturing is enabling
URL : https://patchwork.freedesktop.org/series/55428/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5450_full -> IGTPW_2262_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55428/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2262_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@i915_suspend@debugfs-reader:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: PASS -> FAIL [fdo#103232] +8
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> FAIL [fdo#103167]
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +8
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +3
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +5
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-apl: DMESG-FAIL [fdo#108950] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4778 -> IGTPW_2262
* Piglit: piglit_4509 -> None
CI_DRM_5450: e8e22735052e88c3a169acc3be7989041a64f338 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2262: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2262/
IGT_4778: 0c80bd7f2a964605f307e0220c6bb756685582b9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2262/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling
2019-01-18 21:18 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling Chris Wilson
2019-01-18 21:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-19 0:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-24 14:34 ` Katarzyna Dec
2 siblings, 0 replies; 4+ messages in thread
From: Katarzyna Dec @ 2019-01-24 14:34 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On Fri, Jan 18, 2019 at 09:18:01PM +0000, Chris Wilson wrote:
> If the device has error capturing disabled, we still allow previous
> error state to be cleared by a write to sysfs/error. To actually confirm
> that we can capture a fresh error state, we have to perform a read().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_capture.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
> index f26b4102c..49394c311 100644
> --- a/tests/i915/gem_exec_capture.c
> +++ b/tests/i915/gem_exec_capture.c
> @@ -544,6 +544,7 @@ igt_main
>
> dir = igt_sysfs_open(fd, NULL);
> igt_require(igt_sysfs_set(dir, "error", "Begone!"));
> + igt_require(igt_sysfs_get(dir, "error"));
> }
LGTM.
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
>
> for (e = intel_execution_engines; e->name; e++) {
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-24 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-18 21:18 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling Chris Wilson
2019-01-18 21:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-19 0:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-24 14:34 ` [igt-dev] [PATCH i-g-t] " Katarzyna Dec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox