* [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed
@ 2019-01-28 10:14 Chris Wilson
2019-01-28 10:18 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-28 10:14 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
Check we can reset the GPU before running the reset test.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 21292bf3a..1fdbcc154 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1812,8 +1812,14 @@ igt_main
accuracy(fd, e, pct[i], 10);
}
- igt_subtest_f("busy-hang-%s", e->name)
+ igt_subtest_f("busy-hang-%s", e->name) {
+ igt_hang_t hang =
+ igt_allow_hang(fd, 0, e2ring(fd, e));
+
single(fd, e, TEST_BUSY | FLAG_HANG);
+
+ igt_disallow_hang(fd, hang);
+ }
}
/**
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed
2019-01-28 10:14 [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed Chris Wilson
@ 2019-01-28 10:18 ` Chris Wilson
2019-01-28 11:00 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-01-28 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Check for hangs allowed (rev2) Patchwork
2019-01-28 13:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-01-28 10:18 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
Check we can reset the GPU before running the reset test.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
Different meaning of flags, it's not the ring id!
---
tests/perf_pmu.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 21292bf3a..c9881e59f 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1812,8 +1812,13 @@ igt_main
accuracy(fd, e, pct[i], 10);
}
- igt_subtest_f("busy-hang-%s", e->name)
+ igt_subtest_f("busy-hang-%s", e->name) {
+ igt_hang_t hang = igt_allow_hang(fd, 0, 0);
+
single(fd, e, TEST_BUSY | FLAG_HANG);
+
+ igt_disallow_hang(fd, hang);
+ }
}
/**
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed
2019-01-28 10:18 ` Chris Wilson
@ 2019-01-28 11:00 ` Tvrtko Ursulin
2019-01-28 11:36 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2019-01-28 11:00 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 28/01/2019 10:18, Chris Wilson wrote:
> Check we can reset the GPU before running the reset test.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> Different meaning of flags, it's not the ring id!
> ---
> tests/perf_pmu.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 21292bf3a..c9881e59f 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -1812,8 +1812,13 @@ igt_main
> accuracy(fd, e, pct[i], 10);
> }
>
> - igt_subtest_f("busy-hang-%s", e->name)
> + igt_subtest_f("busy-hang-%s", e->name) {
> + igt_hang_t hang = igt_allow_hang(fd, 0, 0);
> +
> single(fd, e, TEST_BUSY | FLAG_HANG);
> +
> + igt_disallow_hang(fd, hang);
> + }
> }
>
> /**
>
So all IGTs which trigger hangs/resets should call this?
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed
2019-01-28 11:00 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
@ 2019-01-28 11:36 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-28 11:36 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev
Quoting Tvrtko Ursulin (2019-01-28 11:00:43)
>
> On 28/01/2019 10:18, Chris Wilson wrote:
> > Check we can reset the GPU before running the reset test.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > Different meaning of flags, it's not the ring id!
> > ---
> > tests/perf_pmu.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index 21292bf3a..c9881e59f 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -1812,8 +1812,13 @@ igt_main
> > accuracy(fd, e, pct[i], 10);
> > }
> >
> > - igt_subtest_f("busy-hang-%s", e->name)
> > + igt_subtest_f("busy-hang-%s", e->name) {
> > + igt_hang_t hang = igt_allow_hang(fd, 0, 0);
> > +
> > single(fd, e, TEST_BUSY | FLAG_HANG);
> > +
> > + igt_disallow_hang(fd, hang);
> > + }
> > }
> >
> > /**
> >
>
> So all IGTs which trigger hangs/resets should call this?
Yeah, aside from checking we have gpu-reset, it is meant to prep the
context to expect a hang. It just happens to work fine until we hit a
corner case (such as gen2, guc currently, or too many resets).
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Check for hangs allowed (rev2)
2019-01-28 10:14 [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed Chris Wilson
2019-01-28 10:18 ` Chris Wilson
@ 2019-01-28 10:54 ` Patchwork
2019-01-28 13:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-28 10:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/perf_pmu: Check for hangs allowed (rev2)
URL : https://patchwork.freedesktop.org/series/55828/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5491 -> IGTPW_2302
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55828/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2302 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: NOTRUN -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#102505] / [fdo#103558] / [fdo#105079] / [fdo#105602]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: NOTRUN -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-kbl-7567u: PASS -> FAIL [fdo#100368]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (39 -> 39)
------------------------------
Additional (6): fi-byt-j1900 fi-skl-guc fi-cfl-8700k fi-kbl-7500u fi-skl-iommu fi-kbl-8809g
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus
Build changes
-------------
* IGT: IGT_4791 -> IGTPW_2302
CI_DRM_5491: dd267cfc364dc918cdacf7f11e92d40dcd3684fc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2302: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2302/
IGT_4791: cf1222ced94328b6c7be9256e6101505b5d3d143 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2302/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for i915/perf_pmu: Check for hangs allowed (rev2)
2019-01-28 10:14 [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed Chris Wilson
2019-01-28 10:18 ` Chris Wilson
2019-01-28 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Check for hangs allowed (rev2) Patchwork
@ 2019-01-28 13:04 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-28 13:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/perf_pmu: Check for hangs allowed (rev2)
URL : https://patchwork.freedesktop.org/series/55828/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5491_full -> IGTPW_2302_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55828/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2302_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-1us:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#109467]
- shard-apl: NOTRUN -> DMESG-WARN [fdo#109467]
- shard-glk: NOTRUN -> DMESG-WARN [fdo#109467]
* igt@gem_linear_blits@normal:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@gem_mmap_gtt@hang:
- shard-kbl: NOTRUN -> FAIL [fdo#109469]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-glk: PASS -> FAIL [fdo#106641]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +1
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@gem_eio@in-flight-immediate:
- shard-kbl: DMESG-FAIL [fdo#109467] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-flip-vs-panning-vs-hang-interruptible:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +3
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@perf_pmu@rc6:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-glk: INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133] -> DMESG-WARN [fdo#109244]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#109467]: https://bugs.freedesktop.org/show_bug.cgi?id=109467
[fdo#109469]: https://bugs.freedesktop.org/show_bug.cgi?id=109469
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4791 -> IGTPW_2302
* Piglit: piglit_4509 -> None
CI_DRM_5491: dd267cfc364dc918cdacf7f11e92d40dcd3684fc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2302: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2302/
IGT_4791: cf1222ced94328b6c7be9256e6101505b5d3d143 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2302/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-28 13:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-28 10:14 [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed Chris Wilson
2019-01-28 10:18 ` Chris Wilson
2019-01-28 11:00 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-01-28 11:36 ` Chris Wilson
2019-01-28 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Check for hangs allowed (rev2) Patchwork
2019-01-28 13:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox