* [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start
@ 2019-01-30 16:21 Chris Wilson
2019-01-30 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-01-30 16:21 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
igt doesn't handle skipping from inside igt_fork very gracefully and
crashes instead of reporting the lack of requirements. One solution
would be to fix igt, but far easier is to just move the requirement
checking around to do it before we even fork.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109493
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_cpu_reloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/i915/gem_cpu_reloc.c b/tests/i915/gem_cpu_reloc.c
index 48cc7ddc6..470998628 100644
--- a/tests/i915/gem_cpu_reloc.c
+++ b/tests/i915/gem_cpu_reloc.c
@@ -158,9 +158,6 @@ create_tmpl(int i915, struct drm_i915_gem_relocation_entry *reloc)
struct drm_i915_gem_relocation_entry *reloc);
void *tmpl;
- /* could use BLT_FILL instead for gen2 */
- igt_require(gem_can_store_dword(i915, 0));
-
if (gen >= 8)
emit_store_addr = gen8_emit_store_addr;
else if (gen >= 4)
@@ -276,6 +273,9 @@ igt_main
i915 = drm_open_driver(DRIVER_INTEL);
igt_require_gem(i915);
+ /* could use BLT_FILL instead for gen2 */
+ igt_require(gem_can_store_dword(i915, 0));
+
igt_fork_hang_detector(i915);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_cpu_reloc: Do the can-store-dword check at start
2019-01-30 16:21 [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start Chris Wilson
@ 2019-01-30 17:05 ` Patchwork
2019-01-30 21:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-31 9:41 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-30 17:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_cpu_reloc: Do the can-store-dword check at start
URL : https://patchwork.freedesktop.org/series/55996/
State : success
== Summary ==
CI Bug Log - changes from IGT_4801 -> IGTPW_2322
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55996/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2322 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998]
* igt@pm_rpm@module-reload:
- fi-skl-6770hq: PASS -> FAIL [fdo#108511]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-pnv-d510 fi-blb-e6850
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2322
CI_DRM_5509: 3e925dcc414b68e4a5def008a2d15097b7be7db4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2322: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2322/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2322/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_cpu_reloc: Do the can-store-dword check at start
2019-01-30 16:21 [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start Chris Wilson
2019-01-30 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-30 21:33 ` Patchwork
2019-01-31 9:41 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-30 21:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_cpu_reloc: Do the can-store-dword check at start
URL : https://patchwork.freedesktop.org/series/55996/
State : success
== Summary ==
CI Bug Log - changes from IGT_4801_full -> IGTPW_2322_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55996/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2322_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-apl: NOTRUN -> FAIL [fdo#103158]
* igt@gem_pwrite_pread@uncached-pwrite-blt-gtt_mmap-performance:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@i915_suspend@shrink:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107886] / [fdo#109244]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-glk: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@basic-modeset-c:
- shard-hsw: NOTRUN -> FAIL [fdo#109490]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-apl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: NOTRUN -> FAIL [fdo#109350]
* igt@kms_cursor_crc@cursor-size-change:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166]
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_properties@plane-properties-atomic:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +1
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@dpms-vs-vblank-race:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* {igt@kms_flip@flip-vs-suspend}:
- shard-snb: FAIL [fdo#103375] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107886]: https://bugs.freedesktop.org/show_bug.cgi?id=107886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109490]: https://bugs.freedesktop.org/show_bug.cgi?id=109490
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2322
CI_DRM_5509: 3e925dcc414b68e4a5def008a2d15097b7be7db4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2322: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2322/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2322/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start
2019-01-30 16:21 [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start Chris Wilson
2019-01-30 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-30 21:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-31 9:41 ` Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2019-01-31 9:41 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 30/01/2019 16:21, Chris Wilson wrote:
> igt doesn't handle skipping from inside igt_fork very gracefully and
> crashes instead of reporting the lack of requirements. One solution
> would be to fix igt, but far easier is to just move the requirement
> checking around to do it before we even fork.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109493
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_cpu_reloc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_cpu_reloc.c b/tests/i915/gem_cpu_reloc.c
> index 48cc7ddc6..470998628 100644
> --- a/tests/i915/gem_cpu_reloc.c
> +++ b/tests/i915/gem_cpu_reloc.c
> @@ -158,9 +158,6 @@ create_tmpl(int i915, struct drm_i915_gem_relocation_entry *reloc)
> struct drm_i915_gem_relocation_entry *reloc);
> void *tmpl;
>
> - /* could use BLT_FILL instead for gen2 */
> - igt_require(gem_can_store_dword(i915, 0));
> -
> if (gen >= 8)
> emit_store_addr = gen8_emit_store_addr;
> else if (gen >= 4)
> @@ -276,6 +273,9 @@ igt_main
> i915 = drm_open_driver(DRIVER_INTEL);
> igt_require_gem(i915);
>
> + /* could use BLT_FILL instead for gen2 */
> + igt_require(gem_can_store_dword(i915, 0));
> +
> igt_fork_hang_detector(i915);
> }
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-31 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 16:21 [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start Chris Wilson
2019-01-30 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-30 21:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-31 9:41 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox