public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang
@ 2019-02-21 10:19 Chris Wilson
  2019-02-21 10:19 ` [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Chris Wilson @ 2019-02-21 10:19 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

To control hang detection, we manipulate the i915.reset module
parameter. However, to be nice we should SKIP if we cannot modify the
parameter as opposed to outright FAILing.

References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_gt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 646696727..c98a7553b 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
 	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
 		igt_require(has_gpu_reset(fd));
 
-	igt_assert(igt_sysfs_set_parameter
-		   (fd, "reset", "%d", INT_MAX /* any reset method */));
+	igt_require(igt_sysfs_set_parameter
+		    (fd, "reset", "%d", INT_MAX /* any reset method */));
 
 	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
 		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-02-21 17:43 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 10:19 [igt-dev] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang Chris Wilson
2019-02-21 10:19 ` [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed Chris Wilson
2019-02-21 16:11   ` Antonio Argenziano
2019-02-21 11:42 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang Patchwork
2019-02-21 16:08 ` [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] " Antonio Argenziano
2019-02-21 16:11   ` Chris Wilson
2019-02-21 16:16     ` Antonio Argenziano
2019-02-21 17:43 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox