[igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb

public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed

* [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb
@ 2019-02-28 17:17 Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-02-28 17:17 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter

Just realized we don't seem to have any testcase for this. Fill this
gap asap!

v2: Use igt_device_set/drop_master (Chris)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_addfb_basic.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 400241a92e81..6519c2315c2a 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -39,6 +39,7 @@
 #include "drm_fourcc.h"
 
 #include "igt_rand.h"
+#include <igt_device.h>
 
 uint32_t gem_bo;
 uint32_t gem_bo_small;
@@ -667,6 +668,45 @@ static void prop_tests(int fd)
 
 }
 
+static void master_tests(int fd)
+{
+	struct drm_mode_fb_cmd2 f = {};
+
+	f.width = 1024;
+	f.height = 1024;
+	f.pixel_format = DRM_FORMAT_XRGB8888;
+	f.pitches[0] = 1024*4;
+
+	igt_fixture {
+		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+		igt_assert(gem_bo);
+
+		f.handles[0] = gem_bo;
+
+		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
+	}
+
+	igt_subtest("master-rmfb") {
+		int master2_fd;
+
+		igt_device_drop_master(fd);
+
+		master2_fd = drm_open_driver_master(DRIVER_ANY);
+
+		igt_assert_eq(rmfb(master2_fd, f.fb_id), -ENOENT);
+
+		igt_device_drop_master(master2_fd);
+		close(master2_fd);
+
+		igt_device_set_master(fd);
+	}
+
+	igt_fixture
+		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+
+}
+
 static bool has_addfb2_iface(int fd)
 {
 	struct local_drm_mode_fb_cmd2 f = {};
@@ -713,6 +753,8 @@ igt_main
 
 	prop_tests(fd);
 
+	master_tests(fd);
+
 	igt_fixture
 		close(fd);
 }
-- 
2.14.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes
  2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
@ 2019-02-28 17:17 ` Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 3/4] tests: s/core_prop_blob/kms_prop_blob Daniel Vetter
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-02-28 17:17 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter

Been a while this landed in libdrm ...

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/core_prop_blob.c | 55 ++++++++++++++++----------------------------------
 1 file changed, 17 insertions(+), 38 deletions(-)

diff --git a/tests/core_prop_blob.c b/tests/core_prop_blob.c
index a7e787be993d..0a2004c33040 100644
--- a/tests/core_prop_blob.c
+++ b/tests/core_prop_blob.c
@@ -33,27 +33,6 @@
 
 IGT_TEST_DESCRIPTION("Tests behaviour of mass-data 'blob' properties.");
 
-struct local_drm_mode_get_blob {
-	uint32_t blob_id;
-	uint32_t length;
-	uint64_t data;
-};
-struct local_drm_mode_create_blob {
-	uint64_t data;
-	uint32_t length;
-	uint32_t blob_id;
-};
-struct local_drm_mode_destroy_blob {
-	uint32_t blob_id;
-};
-
-#define LOCAL_DRM_IOCTL_MODE_GETPROPBLOB	DRM_IOWR(0xAC, \
-						struct local_drm_mode_get_blob)
-#define LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB	DRM_IOWR(0xBD, \
-						struct local_drm_mode_create_blob)
-#define LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB	DRM_IOWR(0xBE, \
-						struct local_drm_mode_destroy_blob)
-
 static const struct drm_mode_modeinfo test_mode_valid = {
 	.clock = 1234,
 	.hdisplay = 640,
@@ -80,33 +59,33 @@ static const struct drm_mode_modeinfo test_mode_valid = {
 
 static void igt_require_propblob(int fd)
 {
-	struct local_drm_mode_create_blob c;
-	struct local_drm_mode_destroy_blob d;
+	struct drm_mode_create_blob c;
+	struct drm_mode_destroy_blob d;
 	uint32_t blob_data;
 	c.data = (uintptr_t) &blob_data;
 	c.length = sizeof(blob_data);
 
-	igt_require(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &c) == 0);
+	igt_require(drmIoctl(fd, DRM_IOCTL_MODE_CREATEPROPBLOB, &c) == 0);
 	d.blob_id = c.blob_id;
-	igt_require(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB, &d) == 0);
+	igt_require(drmIoctl(fd, DRM_IOCTL_MODE_DESTROYPROPBLOB, &d) == 0);
 }
 
 static int
 validate_prop(int fd, uint32_t prop_id)
 {
-	struct local_drm_mode_get_blob get;
+	struct drm_mode_get_blob get;
 	struct drm_mode_modeinfo ret_mode;
 
 	get.blob_id = prop_id;
 	get.length = 0;
 	get.data = (uintptr_t) 0;
-	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
+	ioctl_or_ret_errno(fd, DRM_IOCTL_MODE_GETPROPBLOB, &get);
 
 	if (get.length != sizeof(test_mode_valid))
 		return ENOMEM;
 
 	get.data = (uintptr_t) &ret_mode;
-	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
+	ioctl_or_ret_errno(fd, DRM_IOCTL_MODE_GETPROPBLOB, &get);
 
 	if (memcmp(&ret_mode, &test_mode_valid, sizeof(test_mode_valid)) != 0)
 		return EINVAL;
@@ -117,12 +96,12 @@ validate_prop(int fd, uint32_t prop_id)
 static uint32_t
 create_prop(int fd)
 {
-	struct local_drm_mode_create_blob create;
+	struct drm_mode_create_blob create;
 
 	create.length = sizeof(test_mode_valid);
 	create.data = (uintptr_t) &test_mode_valid;
 
-	do_ioctl(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create);
+	do_ioctl(fd, DRM_IOCTL_MODE_CREATEPROPBLOB, &create);
 	igt_assert_neq_u32(create.blob_id, 0);
 
 	return create.blob_id;
@@ -131,10 +110,10 @@ create_prop(int fd)
 static int
 destroy_prop(int fd, uint32_t prop_id)
 {
-	struct local_drm_mode_destroy_blob destroy;
+	struct drm_mode_destroy_blob destroy;
 
 	destroy.blob_id = prop_id;
-	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB, &destroy);
+	ioctl_or_ret_errno(fd, DRM_IOCTL_MODE_DESTROYPROPBLOB, &destroy);
 
 	return 0;
 }
@@ -142,8 +121,8 @@ destroy_prop(int fd, uint32_t prop_id)
 static void
 test_validate(int fd)
 {
-	struct local_drm_mode_create_blob create;
-	struct local_drm_mode_get_blob get;
+	struct drm_mode_create_blob create;
+	struct drm_mode_get_blob get;
 	char too_small[32];
 	uint32_t prop_id;
 
@@ -152,24 +131,24 @@ test_validate(int fd)
 	/* Outlandish size. */
 	create.length = 0x10000;
 	create.data = (uintptr_t) &too_small;
-	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
+	do_ioctl_err(fd, DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 
 	/* Outlandish address. */
 	create.length = sizeof(test_mode_valid);
 	create.data = (uintptr_t) 0xdeadbeee;
-	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
+	do_ioctl_err(fd, DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 
 	/* When we pass an incorrect size, the kernel should correct us. */
 	prop_id = create_prop(fd);
 	get.blob_id = prop_id;
 	get.length = sizeof(too_small);
 	get.data = (uintptr_t) too_small;
-	do_ioctl(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
+	do_ioctl(fd, DRM_IOCTL_MODE_GETPROPBLOB, &get);
 	igt_assert_eq_u32(get.length, sizeof(test_mode_valid));
 
 	get.blob_id = prop_id;
 	get.data = (uintptr_t) 0xdeadbeee;
-	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
+	do_ioctl_err(fd, DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 }
 
 static void
-- 
2.14.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] [PATCH i-g-t 3/4] tests: s/core_prop_blob/kms_prop_blob
  2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
@ 2019-02-28 17:17 ` Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master Daniel Vetter
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-02-28 17:17 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter

It's a kms test, name it accordingly. Also sort the build lists while
at it, one test got misplaced.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/Makefile.sources                      | 4 ++--
 tests/intel-ci/fast-feedback.testlist       | 2 +-
 tests/{core_prop_blob.c => kms_prop_blob.c} | 0
 tests/meson.build                           | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
 rename tests/{core_prop_blob.c => kms_prop_blob.c} (100%)

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 35c79592bfee..71ccf00af256 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -16,7 +16,6 @@ TESTS_progs = \
 	core_getclient \
 	core_getstats \
 	core_getversion \
-	core_prop_blob \
 	core_setmaster_vs_auth \
 	debugfs_test \
 	drm_import_export \
@@ -60,6 +59,7 @@ TESTS_progs = \
 	kms_plane_lowres \
 	kms_plane_multiple \
 	kms_plane_scaling \
+	kms_prop_blob \
 	kms_properties \
 	kms_psr \
 	kms_psr2_su \
@@ -67,13 +67,13 @@ TESTS_progs = \
 	kms_rmfb \
 	kms_rotation_crc \
 	kms_selftest \
+	kms_sequence \
 	kms_setmode \
 	kms_sysfs_edid_timing \
 	kms_tv_load_detect \
 	kms_universal_plane \
 	kms_vblank \
 	kms_vrr \
-	kms_sequence \
 	meta_test \
 	perf \
 	perf_pmu \
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 2d22c2c1cc1e..9b71194670da 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,7 +1,6 @@
 # Keep alphabetically sorted by default
 
 igt@core_auth@basic-auth
-igt@core_prop_blob@basic
 igt@debugfs_test@read_all_entries
 igt@gem_basic@bad-close
 igt@gem_basic@create-close
@@ -185,6 +184,7 @@ igt@kms_chamelium@hdmi-crc-fast
 igt@kms_chamelium@vga-hpd-fast
 igt@kms_chamelium@vga-edid-read
 igt@kms_chamelium@common-hpd-after-suspend
+igt@kms_prop_blob@basic
 igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
 igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
 igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
diff --git a/tests/core_prop_blob.c b/tests/kms_prop_blob.c
similarity index 100%
rename from tests/core_prop_blob.c
rename to tests/kms_prop_blob.c
diff --git a/tests/meson.build b/tests/meson.build
index f4bd4a109dbb..9015f809ed05 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -3,7 +3,6 @@ test_progs = [
 	'core_getclient',
 	'core_getstats',
 	'core_getversion',
-	'core_prop_blob',
 	'core_setmaster_vs_auth',
 	'debugfs_test',
 	'drm_import_export',
@@ -47,6 +46,7 @@ test_progs = [
 	'kms_plane_lowres',
 	'kms_plane_multiple',
 	'kms_plane_scaling',
+	'kms_prop_blob',
 	'kms_properties',
 	'kms_psr',
 	'kms_psr2_su',
@@ -54,8 +54,8 @@ test_progs = [
 	'kms_rmfb',
 	'kms_rotation_crc',
 	'kms_selftest',
-	'kms_setmode',
 	'kms_sequence',
+	'kms_setmode',
 	'kms_sysfs_edid_timing',
 	'kms_tv_load_detect',
 	'kms_universal_plane',
-- 
2.14.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master
  2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 3/4] tests: s/core_prop_blob/kms_prop_blob Daniel Vetter
@ 2019-02-28 17:17 ` Daniel Vetter
  2019-02-28 17:53   ` Chris Wilson
  2019-02-28 17:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Patchwork
  2019-02-28 20:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  4 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-02-28 17:17 UTC (permalink / raw)
  To: IGT development

Suggested by Chris.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 tests/core_setmaster_vs_auth.c |  6 ++++--
 tests/kms_flip_event_leak.c    | 10 ++++------
 tests/kms_lease.c              | 11 ++++++-----
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
index c335ddff3a2d..f9e97c7a57ef 100644
--- a/tests/core_setmaster_vs_auth.c
+++ b/tests/core_setmaster_vs_auth.c
@@ -39,6 +39,8 @@
 #include <stdio.h>
 #include <string.h>
 
+#include <igt_device.h>
+
 IGT_TEST_DESCRIPTION("Check that drop/setMaster correctly transfer master "
 		     "state");
 
@@ -56,8 +58,8 @@ igt_simple_main
 
 	/* Open an fd an make it master */
 	master2 = drm_open_driver(DRIVER_ANY);
-	do_or_die(drmDropMaster(master1));
-	do_or_die(drmSetMaster(master2));
+	igt_device_drop_master(master1);
+	igt_device_set_master(master2);
 
 	/* Auth shouldn't work since we're authenticating with a different
 	 * master than the one we got the magic from. */
diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
index 50f880ad3738..ef9befdd481d 100644
--- a/tests/kms_flip_event_leak.c
+++ b/tests/kms_flip_event_leak.c
@@ -28,6 +28,7 @@
 #include <stdio.h>
 #include <string.h>
 
+#include <igt_device.h>
 
 typedef struct {
 	int drm_fd;
@@ -63,11 +64,9 @@ static void test(data_t *data, enum pipe pipe, igt_output_t *output)
 
 	fd = drm_open_driver(DRIVER_ANY);
 
-	ret = drmDropMaster(data->drm_fd);
-	igt_assert_eq(ret, 0);
+	igt_device_drop_master(data->drm_fd);
 
-	ret = drmSetMaster(fd);
-	igt_assert_eq(ret, 0);
+	igt_device_set_master(fd);
 
 	igt_create_color_fb(fd, mode->hdisplay, mode->vdisplay,
 			    DRM_FORMAT_XRGB8888,
@@ -81,8 +80,7 @@ static void test(data_t *data, enum pipe pipe, igt_output_t *output)
 	ret = close(fd);
 	igt_assert_eq(ret, 0);
 
-	ret = drmSetMaster(data->drm_fd);
-	igt_assert_eq(ret, 0);
+	igt_device_set_master(data->drm_fd);
 
 	igt_plane_set_fb(primary, NULL);
 	igt_output_set_pipe(output, PIPE_ANY);
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 4823121e8cf4..6546b21f31d7 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -43,6 +43,7 @@
 #include <libudev.h>
 
 #include <drm.h>
+#include <igt_device.h>
 
 IGT_TEST_DESCRIPTION("Test of CreateLease.");
 
@@ -877,7 +878,7 @@ static void master_vs_lease(data_t *data)
 	igt_assert(is_master(data->master.fd));
 	igt_assert(is_master(lease_fd));
 
-	do_or_die(drmDropMaster(data->master.fd));
+	igt_device_drop_master(data->master.fd);
 
 	igt_assert(!is_master(data->master.fd));
 	igt_assert(!is_master(lease_fd));
@@ -885,7 +886,7 @@ static void master_vs_lease(data_t *data)
 	igt_assert_eq(drmSetMaster(lease_fd), -1);
 	igt_assert_eq(errno, EINVAL);
 
-	do_or_die(drmSetMaster(data->master.fd));
+	igt_device_set_master(data->master.fd);
 
 	igt_assert(is_master(data->master.fd));
 	igt_assert(is_master(lease_fd));
@@ -908,8 +909,8 @@ static void multimaster_lease(data_t *data)
 
 	_create_simple_lease(master2_fd, data, -EACCES);
 
-	do_or_die(drmDropMaster(data->master.fd));
-	do_or_die(drmSetMaster(master2_fd));
+	igt_device_drop_master(data->master.fd);
+	igt_device_set_master(master2_fd);
 
 	igt_assert(!is_master(data->master.fd));
 	igt_assert(!is_master(lease_fd));
@@ -921,7 +922,7 @@ static void multimaster_lease(data_t *data)
 	close(master2_fd); /* close is an implicit DropMaster */
 	igt_assert(!is_master(lease2_fd));
 
-	do_or_die(drmSetMaster(data->master.fd));
+	igt_device_set_master(data->master.fd);
 	igt_assert(is_master(data->master.fd));
 	igt_assert(is_master(lease_fd));
 
-- 
2.14.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master Daniel Vetter
@ 2019-02-28 17:53   ` Chris Wilson
  2019-03-01  7:55     ` Daniel Vetter
  0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2019-02-28 17:53 UTC (permalink / raw)
  To: Daniel Vetter, IGT development

Quoting Daniel Vetter (2019-02-28 17:17:23)
> Suggested by Chris.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/core_setmaster_vs_auth.c |  6 ++++--
>  tests/kms_flip_event_leak.c    | 10 ++++------
>  tests/kms_lease.c              | 11 ++++++-----
>  3 files changed, 14 insertions(+), 13 deletions(-)
> 
> diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> index c335ddff3a2d..f9e97c7a57ef 100644
> --- a/tests/core_setmaster_vs_auth.c
> +++ b/tests/core_setmaster_vs_auth.c
> @@ -39,6 +39,8 @@
>  #include <stdio.h>
>  #include <string.h>
>  
> +#include <igt_device.h>

"igt_device.h" for a local header?

Conversions look fine otherwise.

With "",
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master
  2019-02-28 17:53   ` Chris Wilson
@ 2019-03-01  7:55     ` Daniel Vetter
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-03-01  7:55 UTC (permalink / raw)
  To: Chris Wilson; +Cc: IGT development

On Thu, Feb 28, 2019 at 05:53:42PM +0000, Chris Wilson wrote:
> Quoting Daniel Vetter (2019-02-28 17:17:23)
> > Suggested by Chris.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  tests/core_setmaster_vs_auth.c |  6 ++++--
> >  tests/kms_flip_event_leak.c    | 10 ++++------
> >  tests/kms_lease.c              | 11 ++++++-----
> >  3 files changed, 14 insertions(+), 13 deletions(-)
> > 
> > diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> > index c335ddff3a2d..f9e97c7a57ef 100644
> > --- a/tests/core_setmaster_vs_auth.c
> > +++ b/tests/core_setmaster_vs_auth.c
> > @@ -39,6 +39,8 @@
> >  #include <stdio.h>
> >  #include <string.h>
> >  
> > +#include <igt_device.h>
> 
> "igt_device.h" for a local header?

Polished and merged, thanks for your review.
-Daniel

> 
> Conversions look fine otherwise.
> 
> With "",
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb
  2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
                   ` (2 preceding siblings ...)
  2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master Daniel Vetter
@ 2019-02-28 17:47 ` Patchwork
  2019-02-28 20:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-02-28 17:47 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb
URL   : https://patchwork.freedesktop.org/series/57357/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5674 -> IGTPW_2538
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57357/revisions/1/mbox/

New tests
---------

  New tests have been introduced between CI_DRM_5674 and IGTPW_2538:

### New IGT tests (1) ###

  * igt@kms_prop_blob@basic:
    - Statuses : 36 pass(s)
    - Exec time: [0.0, 0.00] s

  

Known issues
------------

  Here are the changes found in IGTPW_2538 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108094]

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@kms_busy@basic-flip-a:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271] +46

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720] / [fdo#109799]

  
#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       DMESG-WARN [fdo#108965] -> PASS

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
  [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#109799]: https://bugs.freedesktop.org/show_bug.cgi?id=109799


Participating hosts (44 -> 39)
------------------------------

  Additional (1): fi-hsw-peppy 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


Build changes
-------------

    * IGT: IGT_4863 -> IGTPW_2538

  CI_DRM_5674: 71bb3bfb61fb58f93f8b09e6ad576a403cd7752c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2538: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2538/
  IGT_4863: 0f0db14e7f4ec41251ca156d7cb5b8d531a38006 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@kms_addfb_basic@master-rmfb
+igt@kms_prop_blob@basic
+igt@kms_prop_blob@blob-multiple
+igt@kms_prop_blob@blob-prop-core
+igt@kms_prop_blob@blob-prop-lifetime
+igt@kms_prop_blob@blob-prop-validate
+igt@kms_prop_blob@invalid-get-prop
+igt@kms_prop_blob@invalid-get-prop-any
+igt@kms_prop_blob@invalid-set-prop
+igt@kms_prop_blob@invalid-set-prop-any
-igt@core_prop_blob@basic
-igt@core_prop_blob@blob-multiple
-igt@core_prop_blob@blob-prop-core
-igt@core_prop_blob@blob-prop-lifetime
-igt@core_prop_blob@blob-prop-validate
-igt@core_prop_blob@invalid-get-prop
-igt@core_prop_blob@invalid-get-prop-any
-igt@core_prop_blob@invalid-set-prop
-igt@core_prop_blob@invalid-set-prop-any

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2538/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb
  2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
                   ` (3 preceding siblings ...)
  2019-02-28 17:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Patchwork
@ 2019-02-28 20:42 ` Patchwork
  4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-02-28 20:42 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb
URL   : https://patchwork.freedesktop.org/series/57357/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5674_full -> IGTPW_2538_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57357/revisions/1/mbox/

New tests
---------

  New tests have been introduced between CI_DRM_5674_full and IGTPW_2538_full:

### New IGT tests (10) ###

  * igt@kms_addfb_basic@master-rmfb:
    - Statuses : 5 pass(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_prop_blob@basic:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@blob-multiple:
    - Statuses : 5 pass(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_prop_blob@blob-prop-core:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@blob-prop-lifetime:
    - Statuses : 5 pass(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_prop_blob@blob-prop-validate:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@invalid-get-prop:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@invalid-get-prop-any:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@invalid-set-prop:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_prop_blob@invalid-set-prop-any:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_2538_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_color@pipe-b-ctm-max:
    - shard-apl:          PASS -> FAIL [fdo#108147]
    - shard-kbl:          PASS -> FAIL [fdo#108147]

  * igt@kms_cursor_crc@cursor-256x256-onscreen:
    - shard-glk:          NOTRUN -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-256x85-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +1

  * igt@kms_cursor_crc@cursor-64x64-onscreen:
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +6

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-apl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
    - shard-glk:          PASS -> FAIL [fdo#103167] +2

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +17

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +12

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
    - shard-apl:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-kbl:          PASS -> FAIL [fdo#103166] +2

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-glk:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-glk:          PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]

  * igt@kms_universal_plane@cursor-fb-leak-pipe-d:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
    - shard-apl:          PASS -> FAIL [fdo#104894] +1

  * igt@kms_vblank@pipe-c-ts-continuation-modeset:
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665] +1

  * igt@perf_pmu@busy-check-all-vecs0:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +106

  * igt@prime_vgem@wait-render:
    - shard-snb:          PASS -> INCOMPLETE [fdo#105411]

  * igt@testdisplay:
    - shard-apl:          PASS -> INCOMPLETE [fdo#103927]

  
#### Possible fixes ####

  * igt@gem_eio@in-flight-suspend:
    - shard-snb:          FAIL [fdo#103375] -> PASS

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
    - shard-apl:          FAIL [fdo#109660] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS +1
    - shard-kbl:          DMESG-WARN [fdo#107956] -> PASS +2
    - shard-snb:          DMESG-WARN [fdo#107956] -> PASS +1

  * igt@kms_chv_cursor_fail@pipe-c-128x128-top-edge:
    - shard-hsw:          DMESG-WARN [fdo#102614] -> PASS +1

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-offscreen:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +3
    - shard-kbl:          FAIL [fdo#103232] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
    - shard-kbl:          FAIL [fdo#103167] -> PASS +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-apl:          FAIL [fdo#103167] -> PASS +2

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          FAIL [fdo#103167] -> PASS +4

  * igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
    - shard-glk:          FAIL [fdo#108948] -> PASS
    - shard-apl:          FAIL [fdo#108948] -> PASS

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
    - shard-glk:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_setmode@basic:
    - shard-hsw:          FAIL [fdo#99912] -> PASS
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@kms_universal_plane@universal-plane-pipe-b-functional:
    - shard-kbl:          FAIL [fdo#103166] -> PASS

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-snb:          INCOMPLETE [fdo#105411] -> PASS

  
#### Warnings ####

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> FAIL [fdo#109016]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (6 -> 5)
------------------------------

  Missing    (1): shard-skl 


Build changes
-------------

    * IGT: IGT_4863 -> IGTPW_2538
    * Piglit: piglit_4509 -> None

  CI_DRM_5674: 71bb3bfb61fb58f93f8b09e6ad576a403cd7752c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2538: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2538/
  IGT_4863: 0f0db14e7f4ec41251ca156d7cb5b8d531a38006 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2538/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-03-01  7:55 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 3/4] tests: s/core_prop_blob/kms_prop_blob Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master Daniel Vetter
2019-02-28 17:53   ` Chris Wilson
2019-03-01  7:55     ` Daniel Vetter
2019-02-28 17:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Patchwork
2019-02-28 20:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox