From: Nischala Yelchuri <nischala.yelchuri@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
Date: Wed, 6 Mar 2019 18:44:44 -0800 [thread overview]
Message-ID: <20190307024444.42432-1-nischala.yelchuri@intel.com> (raw)
For the modeset case, the vblank counter can increment by more than 1.
Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
Signed-off-by: Nischala Yelchuri <nischala.yelchuri@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105454
---
tests/kms_cursor_legacy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index d6987eea..8652047f 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -978,7 +978,7 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
if (!modeset)
igt_assert_eq(vbl.sequence, vblank_start + 1);
- if (vblank_start && vbl.sequence == vblank_start + 1)
+ if (vblank_start && vbl.sequence >= vblank_start + 1)
vblank_matches = true;
/* Do not requeue on the last 2 events. */
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-03-07 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 2:44 Nischala Yelchuri [this message]
2019-03-07 2:26 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Patchwork
2019-03-07 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-07 15:32 ` [igt-dev] [PATCH] " Summers, Stuart
2019-03-13 20:16 ` Nischala Yelchuri
2019-03-13 20:41 ` Chris Wilson
2019-03-20 15:44 ` Maarten Lankhorst
2019-03-20 15:50 ` Chris Wilson
2019-03-13 20:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2) Patchwork
2019-03-14 3:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307024444.42432-1-nischala.yelchuri@intel.com \
--to=nischala.yelchuri@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox