From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Nischala Yelchuri <nischala.yelchuri@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
Date: Wed, 20 Mar 2019 16:44:36 +0100 [thread overview]
Message-ID: <65484c84-5bfc-276a-8eda-7f404b9a5387@linux.intel.com> (raw)
In-Reply-To: <155250966026.30003.10001053991628825793@skylake-alporthouse-com>
Op 13-03-2019 om 21:41 schreef Chris Wilson:
> Quoting Nischala Yelchuri (2019-03-13 20:16:35)
>> For the !modeset case, after a pageflip is performed on both crtc's,
>> vblank counter is advanced by 1 when compared to its original value.
>>
>> For the modeset case, when pageflips and modesets are interleaved,
>> vblank counter does not always advance by 1 as nonblocking modeset
>> could fail, in which case we do not need vblank_matches.
> Having acknowledged the bug, try fixing it.
> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Hey,
Not sure that's possible. We need access to all crtc_state's when reallocating ddb, and this means a pageflip on the first crtc is stalled while doing a modeset on another.
The page flip will be blocked on the nonblocking modeset to complete.
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-20 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
2019-03-07 2:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-07 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-07 15:32 ` [igt-dev] [PATCH] " Summers, Stuart
2019-03-13 20:16 ` Nischala Yelchuri
2019-03-13 20:41 ` Chris Wilson
2019-03-20 15:44 ` Maarten Lankhorst [this message]
2019-03-20 15:50 ` Chris Wilson
2019-03-13 20:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2) Patchwork
2019-03-14 3:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65484c84-5bfc-276a-8eda-7f404b9a5387@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
--cc=nischala.yelchuri@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox