Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch

["Summers, Stuart" <stuart.summers@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]

On Wed, 2019-03-06 at 18:44 -0800, Nischala Yelchuri wrote:
> For the modeset case, the vblank counter can increment by more than
> 1.

Per my comment below, it would be great to have a little more detail
about why this is needed in the commit message.

> 
> Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
> Signed-off-by: Nischala Yelchuri <nischala.yelchuri@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105454
> ---
>  tests/kms_cursor_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index d6987eea..8652047f 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -978,7 +978,7 @@ static void
> two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
>  		if (!modeset)
>  			igt_assert_eq(vbl.sequence, vblank_start + 1);
>  
> -		if (vblank_start && vbl.sequence == vblank_start + 1)
> +		if (vblank_start && vbl.sequence >= vblank_start + 1)

Great find, but as we discussed in person, it would be interesting to
know why this can be incremented by more than once per modeset. Is this
expected?

Thanks,
Stuart

>  			vblank_matches = true;
>  
>  		/* Do not requeue on the last 2 events. */

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev