[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Arkadiusz Hiler]

Currently we are printing one igt_warn for each CRC mismatch, which gets
quite overwhelming with having to see the same error 8 times for each
color tested:

WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3

Since the most interesting information here is which format on which
pipe/plane is broken we can skip igt_warn just once.

For those weirder and rarer case where just certain colors would fail we
still provide the count:

WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3 with 8/8 solid colors tested

Cc: Martin Peres <martin.peres@free.fr>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/kms_plane.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 9c330ae4..4c0199fa 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -547,6 +547,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 	}
 
 	for (int i = 0; i < plane->drm_plane->count_formats; i++) {
+		int crc_mismatch_count = 0;
 		igt_crc_t crc;
 
 		format = plane->drm_plane->formats[i];
@@ -562,23 +563,24 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 			 kmstest_pipe_name(pipe), plane->index);
 
 		for (int j = 0; j < ARRAY_SIZE(colors); j++) {
-			bool crc_equal;
-
 			test_format_plane_color(data, pipe, plane,
 						format, width, height,
 						dst_w, dst_h,
 						j, &crc, &fb);
 
-			crc_equal = igt_check_crc_equal(&crc, &ref_crc[j]);
-			result &= crc_equal;
-
-			if (!crc_equal)
-				igt_warn("CRC mismatch with format " IGT_FORMAT_FMT " on %s.%u\n",
-					 IGT_FORMAT_ARGS(format),
-					 kmstest_pipe_name(pipe), plane->index);
+			if (!igt_check_crc_equal(&crc, &ref_crc[j])) {
+				crc_mismatch_count++;
+				result = false;
+			}
 		}
+
+		if (crc_mismatch_count)
+			igt_warn("CRC mismatch with format " IGT_FORMAT_FMT " on %s.%u with %d/%d solid colors tested\n",
+				 IGT_FORMAT_ARGS(format), kmstest_pipe_name(pipe),
+				 plane->index, crc_mismatch_count, (int)ARRAY_SIZE(colors));
 	}
 
+
 	igt_pipe_crc_stop(data->pipe_crc);
 	test_fini(data);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Martin Peres]

On 14/03/2019 13:03, Arkadiusz Hiler wrote:
> Currently we are printing one igt_warn for each CRC mismatch, which gets
> quite overwhelming with having to see the same error 8 times for each
> color tested:
> 
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> 
> Since the most interesting information here is which format on which
> pipe/plane is broken we can skip igt_warn just once.
> 
> For those weirder and rarer case where just certain colors would fail we
> still provide the count:
> 
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3 with 8/8 solid colors tested
> 
> Cc: Martin Peres <martin.peres@free.fr>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
>  tests/kms_plane.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 9c330ae4..4c0199fa 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -547,6 +547,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>  	}
>  
>  	for (int i = 0; i < plane->drm_plane->count_formats; i++) {
> +		int crc_mismatch_count = 0;
>  		igt_crc_t crc;
>  
>  		format = plane->drm_plane->formats[i];
> @@ -562,23 +563,24 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>  			 kmstest_pipe_name(pipe), plane->index);
>  
>  		for (int j = 0; j < ARRAY_SIZE(colors); j++) {
> -			bool crc_equal;
> -
>  			test_format_plane_color(data, pipe, plane,
>  						format, width, height,
>  						dst_w, dst_h,
>  						j, &crc, &fb);
>  
> -			crc_equal = igt_check_crc_equal(&crc, &ref_crc[j]);
> -			result &= crc_equal;
> -
> -			if (!crc_equal)
> -				igt_warn("CRC mismatch with format " IGT_FORMAT_FMT " on %s.%u\n",
> -					 IGT_FORMAT_ARGS(format),
> -					 kmstest_pipe_name(pipe), plane->index);
> +			if (!igt_check_crc_equal(&crc, &ref_crc[j])) {
> +				crc_mismatch_count++;
> +				result = false;
> +			}
>  		}
> +
> +		if (crc_mismatch_count)
> +			igt_warn("CRC mismatch with format " IGT_FORMAT_FMT " on %s.%u with %d/%d solid colors tested\n",
> +				 IGT_FORMAT_ARGS(format), kmstest_pipe_name(pipe),
> +				 plane->index, crc_mismatch_count, (int)ARRAY_SIZE(colors));
>  	}
>  
> +
Was this meant?

>  	igt_pipe_crc_stop(data->pipe_crc);
>  	test_fini(data);
>  
> 

In any case, this patch is:

Reviewed-by: Martin Peres <martin.peres@linux.intel.com>

Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Dhinakaran Pandiyan]

On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
> Currently we are printing one igt_warn for each CRC mismatch, which
> gets
> quite overwhelming with having to see the same error 8 times for each
> color tested:
> 
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> 
> Since the most interesting information here is which format on which
> pipe/plane is broken we can skip igt_warn just once.
> 
> For those weirder and rarer case where just certain colors would fail
> we
> still provide the count:
IMO it's better to have all the information in the logs, particularly
for those 'weirder and rare cases, which are hard to reproduce. And
don't see how count is useful. I think, we should be even logging the
RGB values for the mismatching cases.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Martin Peres]

On 15/03/2019 00:35, Dhinakaran Pandiyan wrote:
> On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
>> Currently we are printing one igt_warn for each CRC mismatch, which
>> gets
>> quite overwhelming with having to see the same error 8 times for each
>> color tested:
>>
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>>
>> Since the most interesting information here is which format on which
>> pipe/plane is broken we can skip igt_warn just once.
>>
>> For those weirder and rarer case where just certain colors would fail
>> we
>> still provide the count:
> IMO it's better to have all the information in the logs, particularly
> for those 'weirder and rare cases, which are hard to reproduce. And
> don't see how count is useful. I think, we should be even logging the
> RGB values for the mismatching cases.

I definitely stand behind your reasoning here, however I have a strong
requirement that I need to be able to file filters for this, and
multiple lines are just too hard to file filters when you also need to
check that other formats are also failing and no new one comes in
without me to get new values.

Would you have an idea on how to get the colors failing in one line? I
was initially proposing to just have a bitfield representing the colors
failing in one value, but Arek found it hard to understand.

What do you think?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Petri Latvala]

From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Currently we are printing one igt_warn for each CRC mismatch, which gets
quite overwhelming with having to see the same error 8 times for each
color tested:

WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3

Since the most interesting information here is which format on which
pipe/plane is broken we can skip igt_warn just once.

For those weirder and rarer case where just certain colors would fail we
still provide the count and the mask of color array indices that failed:

WARNING: CRC mismatches with format NV12 (0x3231564e) on A.3 with 8/8 solid colors tested (0xFF)

v2 (Petri): Print a mask so it's possible to know which colors failed.

Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com> #v1
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 tests/kms_plane.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 969a61c8..82d4d1d0 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -547,6 +547,8 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 	}
 
 	for (int i = 0; i < plane->drm_plane->count_formats; i++) {
+		int crc_mismatch_count = 0;
+		int crc_mismatch_mask = 0;
 		igt_crc_t crc;
 
 		format = plane->drm_plane->formats[i];
@@ -562,21 +564,22 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 			 kmstest_pipe_name(pipe), plane->index);
 
 		for (int j = 0; j < ARRAY_SIZE(colors); j++) {
-			bool crc_equal;
-
 			test_format_plane_color(data, pipe, plane,
 						format, width, height,
 						dst_w, dst_h,
 						j, &crc, &fb);
 
-			crc_equal = igt_check_crc_equal(&crc, &ref_crc[j]);
-			result &= crc_equal;
-
-			if (!crc_equal)
-				igt_warn("CRC mismatch with format " IGT_FORMAT_FMT " on %s.%u\n",
-					 IGT_FORMAT_ARGS(format),
-					 kmstest_pipe_name(pipe), plane->index);
+			if (!igt_check_crc_equal(&crc, &ref_crc[j])) {
+				crc_mismatch_count++;
+				crc_mismatch_mask |= (1 << j);
+				result = false;
+			}
 		}
+
+		if (crc_mismatch_count)
+			igt_warn("CRC mismatches with format " IGT_FORMAT_FMT " on %s.%u with %d/%d solid colors tested (0x%X)\n",
+				 IGT_FORMAT_ARGS(format), kmstest_pipe_name(pipe),
+				 plane->index, crc_mismatch_count, (int)ARRAY_SIZE(colors), crc_mismatch_mask);
 	}
 
 	igt_pipe_crc_stop(data->pipe_crc);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests/kms_plane: Use just one valid output

[Petri Latvala]

From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Since those are just pipe CRC tests output does not really matter.

Instead of running the test number-of-connected-outputs times per pipe,
let's run them just once.

Cc: Martin Peres <martin.peres@free.fr>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_plane.c | 78 +++++++++++++++++++----------------------------
 1 file changed, 32 insertions(+), 46 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 82d4d1d0..d8a14ecb 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -219,28 +219,23 @@ test_plane_position_with_output(data_t *data,
 static void
 test_plane_position(data_t *data, enum pipe pipe, unsigned int flags)
 {
+	int n_planes = data->display.pipes[pipe].n_planes;
 	igt_output_t *output;
-	int connected_outs = 0;
-
-	for_each_valid_output_on_pipe(&data->display, pipe, output) {
-		int n_planes = data->display.pipes[pipe].n_planes;
-		igt_crc_t reference_crc;
-
-		test_init(data, pipe);
+	igt_crc_t reference_crc;
 
-		test_grab_crc(data, output, pipe, &green, &reference_crc);
+	output = igt_get_single_output_for_pipe(&data->display, pipe);
+	igt_require(output);
 
-		for (int plane = 1; plane < n_planes; plane++)
-			test_plane_position_with_output(data, pipe, plane,
-							output, &reference_crc,
-							flags);
+	test_init(data, pipe);
 
-		test_fini(data);
+	test_grab_crc(data, output, pipe, &green, &reference_crc);
 
-		connected_outs++;
-	}
+	for (int plane = 1; plane < n_planes; plane++)
+		test_plane_position_with_output(data, pipe, plane,
+						output, &reference_crc,
+						flags);
 
-	igt_skip_on(connected_outs == 0);
+	test_fini(data);
 }
 
 /*
@@ -340,31 +335,24 @@ test_plane_panning_with_output(data_t *data,
 static void
 test_plane_panning(data_t *data, enum pipe pipe, unsigned int flags)
 {
+	int n_planes = data->display.pipes[pipe].n_planes;
 	igt_output_t *output;
-	int connected_outs = 0;
-
-	for_each_valid_output_on_pipe(&data->display, pipe, output) {
-		int n_planes = data->display.pipes[pipe].n_planes;
-		igt_crc_t red_crc;
-		igt_crc_t blue_crc;
-
-		test_init(data, pipe);
+	igt_crc_t red_crc;
+	igt_crc_t blue_crc;
 
-		test_grab_crc(data, output, pipe, &red, &red_crc);
-		test_grab_crc(data, output, pipe, &blue, &blue_crc);
+	output = igt_get_single_output_for_pipe(&data->display, pipe);
+	igt_require(output);
 
-		for (int plane = 1; plane < n_planes; plane++)
-			test_plane_panning_with_output(data, pipe, plane,
-						       output,
-						       &red_crc, &blue_crc,
-						       flags);
+	test_init(data, pipe);
 
-		test_fini(data);
+	test_grab_crc(data, output, pipe, &red, &red_crc);
+	test_grab_crc(data, output, pipe, &blue, &blue_crc);
 
-		connected_outs++;
-	}
+	for (int plane = 1; plane < n_planes; plane++)
+		test_plane_panning_with_output(data, pipe, plane, output,
+					       &red_crc, &blue_crc, flags);
 
-	igt_skip_on(connected_outs == 0);
+	test_fini(data);
 }
 
 static const color_t colors[] = {
@@ -601,22 +589,20 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 static void
 test_pixel_formats(data_t *data, enum pipe pipe)
 {
+	bool result;
 	igt_output_t *output;
+	igt_plane_t *plane;
 
-	igt_display_require_output_on_pipe(&data->display, pipe);
-
-	for_each_valid_output_on_pipe(&data->display, pipe, output) {
-		bool result = true;
-		igt_plane_t *plane;
+	output = igt_get_single_output_for_pipe(&data->display, pipe);
+	igt_require(output);
 
-		for_each_plane_on_pipe(&data->display, pipe, plane)
-			result &= test_format_plane(data, pipe, output, plane);
+	result = true;
+	for_each_plane_on_pipe(&data->display, pipe, plane)
+		result &= test_format_plane(data, pipe, output, plane);
 
-		igt_assert_f(result, "At least one CRC mismatch happened\n");
+	igt_assert_f(result, "At least one CRC mismatch happened\n");
 
-
-		igt_output_set_pipe(output, PIPE_ANY);
-	}
+	igt_output_set_pipe(output, PIPE_ANY);
 }
 
 static void
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Dhinakaran Pandiyan]

On Fri, 2019-03-15 at 13:56 +0200, Martin Peres wrote:
> On 15/03/2019 00:35, Dhinakaran Pandiyan wrote:
> > On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
> > > Currently we are printing one igt_warn for each CRC mismatch,
> > > which
> > > gets
> > > quite overwhelming with having to see the same error 8 times for
> > > each
> > > color tested:
> > > 
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > 
> > > Since the most interesting information here is which format on
> > > which
> > > pipe/plane is broken we can skip igt_warn just once.
> > > 
> > > For those weirder and rarer case where just certain colors would
> > > fail
> > > we
> > > still provide the count:
> > 
> > IMO it's better to have all the information in the logs,
> > particularly
> > for those 'weirder and rare cases, which are hard to reproduce. And
> > don't see how count is useful. I think, we should be even logging
> > the
> > RGB values for the mismatching cases.
> 
> I definitely stand behind your reasoning here, however I have a
> strong
> requirement that I need to be able to file filters for this, and
> multiple lines are just too hard to file filters when you also need
> to
> check that other formats are also failing and no new one comes in
> without me to get new values.
It would have been nice to include this justification in the commit
message.

> 
> Would you have an idea on how to get the colors failing in one line?
> I
> was initially proposing to just have a bitfield representing the
> colors
> failing in one value, but Arek found it hard to understand.
> 
> What do you think?
A bit mask, like what Petri has done, is still useful to quickly
identify failing patterns; we can always go back and check the color
during debug.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane: Print count of mismatched colors (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane: Print count of mismatched colors (rev2)
URL   : https://patchwork.freedesktop.org/series/58058/
State : success

== Summary ==

CI Bug Log - changes from IGT_4888 -> IGTPW_2642
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58058/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2642 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_cs_nop@sync-gfx0:
    - fi-kbl-7567u:       NOTRUN -> SKIP [fdo#109271] +17

  * igt@i915_module_load@reload:
    - fi-kbl-7567u:       PASS -> DMESG-WARN [fdo#105602] / [fdo#108529]

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-7567u:       NOTRUN -> DMESG-WARN [fdo#108529]
    - fi-skl-6770hq:      PASS -> FAIL [fdo#108511]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@i915_selftest@live_hangcheck:
    - fi-ilk-650:         PASS -> INCOMPLETE [fdo#109723]

  * igt@kms_busy@basic-flip-a:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7567u:       PASS -> DMESG-FAIL [fdo#105079]

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
    - fi-kbl-7567u:       PASS -> SKIP [fdo#109271] +33

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-whl-u:           PASS -> FAIL [fdo#103375] +3
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#107362] -> PASS

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS +1

  * igt@prime_vgem@basic-fence-flip:
    - fi-ilk-650:         FAIL [fdo#104008] -> PASS

  
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
  [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#109723]: https://bugs.freedesktop.org/show_bug.cgi?id=109723


Participating hosts (46 -> 38)
------------------------------

  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4888 -> IGTPW_2642
    * Linux: CI_DRM_5756 -> CI_DRM_5763

  CI_DRM_5756: 0a2a982693ac3f3ecabf8e6c12cb18aa993ae3b0 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_5763: de2772b353b83e6347687973dfff6f7f5257e364 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2642: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2642/
  IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2642/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Petri Latvala]

On Fri, Mar 15, 2019 at 12:41:35PM -0700, Dhinakaran Pandiyan wrote:
> On Fri, 2019-03-15 at 13:56 +0200, Martin Peres wrote:
> > On 15/03/2019 00:35, Dhinakaran Pandiyan wrote:
> > > On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
> > > > Currently we are printing one igt_warn for each CRC mismatch,
> > > > which
> > > > gets
> > > > quite overwhelming with having to see the same error 8 times for
> > > > each
> > > > color tested:
> > > > 
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> > > > 
> > > > Since the most interesting information here is which format on
> > > > which
> > > > pipe/plane is broken we can skip igt_warn just once.
> > > > 
> > > > For those weirder and rarer case where just certain colors would
> > > > fail
> > > > we
> > > > still provide the count:
> > > 
> > > IMO it's better to have all the information in the logs,
> > > particularly
> > > for those 'weirder and rare cases, which are hard to reproduce. And
> > > don't see how count is useful. I think, we should be even logging
> > > the
> > > RGB values for the mismatching cases.
> > 
> > I definitely stand behind your reasoning here, however I have a
> > strong
> > requirement that I need to be able to file filters for this, and
> > multiple lines are just too hard to file filters when you also need
> > to
> > check that other formats are also failing and no new one comes in
> > without me to get new values.
> It would have been nice to include this justification in the commit
> message.
> 
> > 
> > Would you have an idea on how to get the colors failing in one line?
> > I
> > was initially proposing to just have a bitfield representing the
> > colors
> > failing in one value, but Arek found it hard to understand.
> > 
> > What do you think?
> A bit mask, like what Petri has done, is still useful to quickly
> identify failing patterns; we can always go back and check the color
> during debug.


Can I interpret this as an acked-by on the mask printing version?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] tests/kms_plane: Print count of mismatched colors (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane: Print count of mismatched colors (rev2)
URL   : https://patchwork.freedesktop.org/series/58058/
State : success

== Summary ==

CI Bug Log - changes from IGT_4888_full -> IGTPW_2642_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58058/revisions/2/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2642_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
    - shard-apl:          PASS -> FAIL +2

  * {igt@kms_plane@pixel-format-pipe-c-planes}:
    - shard-kbl:          PASS -> FAIL

  
Known issues
------------

  Here are the changes found in IGTPW_2642_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
    - shard-apl:          PASS -> FAIL [fdo#109660]

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10

  * igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_busy@extended-modeset-hang-newfb-render-c:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107956] +1

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956] +1

  * igt@kms_busy@extended-pageflip-hang-newfb-render-a:
    - shard-snb:          PASS -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_color@pipe-a-degamma:
    - shard-apl:          PASS -> FAIL [fdo#104782] / [fdo#108145]
    - shard-kbl:          PASS -> FAIL [fdo#104782] / [fdo#108145]

  * igt@kms_color@pipe-c-legacy-gamma:
    - shard-glk:          PASS -> FAIL [fdo#104782]

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-kbl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +7

  * igt@kms_cursor_crc@cursor-alpha-opaque:
    - shard-glk:          PASS -> FAIL [fdo#109350]

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          PASS -> FAIL [fdo#105767]

  * igt@kms_cursor_legacy@pipe-b-torture-bo:
    - shard-apl:          PASS -> DMESG-WARN [fdo#107122]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-kbl:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-apl:          PASS -> FAIL [fdo#103167] +4

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          PASS -> FAIL [fdo#103167] +6

  * igt@kms_frontbuffer_tracking@fbc-2p-rte:
    - shard-glk:          PASS -> FAIL [fdo#103167] / [fdo#105682]

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +5

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +101

  * igt@kms_psr@sprite_plane_onoff:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +11

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          PASS -> FAIL [fdo#109016]

  * igt@kms_setmode@basic:
    - shard-hsw:          PASS -> FAIL [fdo#99912]

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
    - shard-apl:          PASS -> FAIL [fdo#104894] +1
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  * igt@perf_pmu@rc6-runtime-pm-long:
    - shard-apl:          PASS -> FAIL [fdo#105010]
    - shard-kbl:          PASS -> FAIL [fdo#105010]

  * igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +6

  * igt@sw_sync@sync_busy_fork_unixsocket:
    - shard-snb:          NOTRUN -> FAIL [fdo#110150 ]

  * igt@tools_test@tools_test:
    - shard-snb:          PASS -> SKIP [fdo#109271]

  
#### Possible fixes ####

  * igt@gem_eio@reset-stress:
    - shard-snb:          FAIL [fdo#109661] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-kbl:          DMESG-WARN [fdo#107956] -> PASS +1
    - shard-snb:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-onscreen:
    - shard-apl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
    - shard-kbl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          FAIL [fdo#105767] -> PASS

  * igt@kms_flip@modeset-vs-vblank-race-interruptible:
    - shard-glk:          FAIL [fdo#103060] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
    - shard-apl:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-glk:          FAIL [fdo#103167] -> PASS +1
    - shard-kbl:          FAIL [fdo#103167] -> PASS +1

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS

  * {igt@kms_plane@pixel-format-pipe-a-planes-source-clamping}:
    - shard-apl:          FAIL [fdo#110033] -> PASS +1
    - shard-kbl:          FAIL -> PASS

  * {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
    - shard-glk:          SKIP [fdo#109271] -> PASS

  * {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
    - shard-apl:          FAIL [fdo#110037] -> PASS +3

  * igt@kms_setmode@basic:
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@kms_vblank@pipe-c-ts-continuation-modeset:
    - shard-kbl:          FAIL [fdo#104894] -> PASS
    - shard-apl:          FAIL [fdo#104894] -> PASS

  
#### Warnings ####

  * igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
    - shard-glk:          FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
  [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110033]: https://bugs.freedesktop.org/show_bug.cgi?id=110033
  [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
  [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
  [fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
  [fdo#110150 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110150 
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4888 -> IGTPW_2642
    * Linux: CI_DRM_5756 -> CI_DRM_5763

  CI_DRM_5756: 0a2a982693ac3f3ecabf8e6c12cb18aa993ae3b0 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_5763: de2772b353b83e6347687973dfff6f7f5257e364 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2642: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2642/
  IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2642/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Dhinakaran Pandiyan]

On Fri, 2019-03-15 at 14:53 +0200, Petri Latvala wrote:
> From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> Currently we are printing one igt_warn for each CRC mismatch, which
> gets
> quite overwhelming with having to see the same error 8 times for each
> color tested:
> 
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> 
> Since the most interesting information here is which format on which
> pipe/plane is broken we can skip igt_warn just once.
> 
> For those weirder and rarer case where just certain colors would fail
> we
> still provide the count and the mask of color array indices that
> failed:
> 
> WARNING: CRC mismatches with format NV12 (0x3231564e) on A.3 with 8/8
> solid colors tested (0xFF)
> 
> v2 (Petri): Print a mask so it's possible to know which colors
> failed.

Acked-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> 
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Reviewed-by: Martin Peres <martin.peres@linux.intel.com> #v1
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  tests/kms_plane.c | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 969a61c8..82d4d1d0 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -547,6 +547,8 @@ static bool test_format_plane(data_t *data, enum
> pipe pipe,
>  	}
>  
>  	for (int i = 0; i < plane->drm_plane->count_formats; i++) {
> +		int crc_mismatch_count = 0;
> +		int crc_mismatch_mask = 0;
>  		igt_crc_t crc;
>  
>  		format = plane->drm_plane->formats[i];
> @@ -562,21 +564,22 @@ static bool test_format_plane(data_t *data,
> enum pipe pipe,
>  			 kmstest_pipe_name(pipe), plane->index);
>  
>  		for (int j = 0; j < ARRAY_SIZE(colors); j++) {
> -			bool crc_equal;
> -
>  			test_format_plane_color(data, pipe, plane,
>  						format, width, height,
>  						dst_w, dst_h,
>  						j, &crc, &fb);
>  
> -			crc_equal = igt_check_crc_equal(&crc,
> &ref_crc[j]);
> -			result &= crc_equal;
> -
> -			if (!crc_equal)
> -				igt_warn("CRC mismatch with format "
> IGT_FORMAT_FMT " on %s.%u\n",
> -					 IGT_FORMAT_ARGS(format),
> -					 kmstest_pipe_name(pipe),
> plane->index);
> +			if (!igt_check_crc_equal(&crc, &ref_crc[j])) {
> +				crc_mismatch_count++;
> +				crc_mismatch_mask |= (1 << j);
> +				result = false;
> +			}
>  		}
> +
> +		if (crc_mismatch_count)
> +			igt_warn("CRC mismatches with format "
> IGT_FORMAT_FMT " on %s.%u with %d/%d solid colors tested (0x%X)\n",
> +				 IGT_FORMAT_ARGS(format),
> kmstest_pipe_name(pipe),
> +				 plane->index, crc_mismatch_count,
> (int)ARRAY_SIZE(colors), crc_mismatch_mask);
>  	}
>  
>  	igt_pipe_crc_stop(data->pipe_crc);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev