* [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
@ 2019-03-18 8:13 Chris Wilson
2019-03-18 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-03-18 8:13 UTC (permalink / raw)
To: igt-dev
sendmsg/recvmsg return the number of bytes transferred, not just an
error code.
Fixes: 520b6f7fbb6c ("sw_sync: Wait until the end")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110150
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/sw_sync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 26457ce76..950b8b614 100644
--- a/tests/sw_sync.c
+++ b/tests/sw_sync.c
@@ -197,7 +197,7 @@ static void test_sync_busy_fork_unixsocket(void)
msg.msg_control = c_buffer;
msg.msg_controllen = sizeof(c_buffer);
- igt_assert(recvmsg(socket, &msg, 0) == 0);
+ igt_assert(recvmsg(socket, &msg, 0) > 0);
cmsg = CMSG_FIRSTHDR(&msg);
data = CMSG_DATA(cmsg);
@@ -233,7 +233,7 @@ static void test_sync_busy_fork_unixsocket(void)
igt_assert_f(sync_fence_wait(fence, 0) == -ETIME,
"Fence signaled (it should not have been signalled yet)\n");
- igt_assert(sendmsg(socket, &msg, 0) == 0);
+ igt_assert(sendmsg(socket, &msg, 0) > 0);
igt_assert_f(sync_fence_wait(fence, 2*1000) == 0,
"Fence not signaled (timeline value 1 fence seqno 1)\n");
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
2019-03-18 8:13 [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg Chris Wilson
@ 2019-03-18 12:00 ` Patchwork
2019-03-18 13:14 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-03-18 15:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-18 12:00 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
URL : https://patchwork.freedesktop.org/series/58117/
State : success
== Summary ==
CI Bug Log - changes from IGT_4888 -> IGTPW_2648
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58117/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2648 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-kbl-7567u: NOTRUN -> SKIP [fdo#109271] +17
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_module_load@reload:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602] / [fdo#108529]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7567u: NOTRUN -> DMESG-WARN [fdo#108529]
- fi-skl-6770hq: PASS -> FAIL [fdo#108511]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: PASS -> DMESG-FAIL [fdo#105079]
* igt@kms_chamelium@dp-edid-read:
- fi-skl-iommu: NOTRUN -> SKIP [fdo#109271] +45
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: PASS -> SKIP [fdo#109271] +33
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-whl-u: PASS -> FAIL [fdo#103375] +3
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +2
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: FAIL [fdo#104008] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
Participating hosts (46 -> 38)
------------------------------
Additional (1): fi-skl-iommu
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4888 -> IGTPW_2648
* Linux: CI_DRM_5756 -> CI_DRM_5763
CI_DRM_5756: 0a2a982693ac3f3ecabf8e6c12cb18aa993ae3b0 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5763: de2772b353b83e6347687973dfff6f7f5257e364 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2648: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2648/
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2648/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
2019-03-18 8:13 [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg Chris Wilson
2019-03-18 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-18 13:14 ` Petri Latvala
2019-03-18 15:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Petri Latvala @ 2019-03-18 13:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Mon, Mar 18, 2019 at 08:13:22AM +0000, Chris Wilson wrote:
> sendmsg/recvmsg return the number of bytes transferred, not just an
> error code.
>
> Fixes: 520b6f7fbb6c ("sw_sync: Wait until the end")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110150
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/sw_sync.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/sw_sync.c b/tests/sw_sync.c
> index 26457ce76..950b8b614 100644
> --- a/tests/sw_sync.c
> +++ b/tests/sw_sync.c
> @@ -197,7 +197,7 @@ static void test_sync_busy_fork_unixsocket(void)
> msg.msg_control = c_buffer;
> msg.msg_controllen = sizeof(c_buffer);
>
> - igt_assert(recvmsg(socket, &msg, 0) == 0);
> + igt_assert(recvmsg(socket, &msg, 0) > 0);
>
> cmsg = CMSG_FIRSTHDR(&msg);
> data = CMSG_DATA(cmsg);
> @@ -233,7 +233,7 @@ static void test_sync_busy_fork_unixsocket(void)
> igt_assert_f(sync_fence_wait(fence, 0) == -ETIME,
> "Fence signaled (it should not have been signalled yet)\n");
>
> - igt_assert(sendmsg(socket, &msg, 0) == 0);
> + igt_assert(sendmsg(socket, &msg, 0) > 0);
>
> igt_assert_f(sync_fence_wait(fence, 2*1000) == 0,
> "Fence not signaled (timeline value 1 fence seqno 1)\n");
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
2019-03-18 8:13 [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg Chris Wilson
2019-03-18 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-18 13:14 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2019-03-18 15:21 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-18 15:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
URL : https://patchwork.freedesktop.org/series/58117/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4888_full -> IGTPW_2648_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2648_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2648_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58117/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2648_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: PASS -> FAIL
- shard-apl: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2648_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10
* igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +1
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: PASS -> INCOMPLETE [fdo#103927] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#103355]
* igt@kms_flip@2x-flip-vs-fences:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: PASS -> DMESG-WARN [fdo#108566]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +2
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +9
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +4
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +104
* igt@kms_psr@sprite_plane_onoff:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +10
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +2
* igt@perf@oa-exponents:
- shard-glk: PASS -> FAIL [fdo#105483]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +6
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-snb: FAIL [fdo#109661] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +2
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* {igt@kms_plane@pixel-format-pipe-a-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS +1
- shard-apl: FAIL [fdo#110033] -> PASS +1
- shard-kbl: FAIL [fdo#110127] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
- shard-apl: FAIL [fdo#108145] -> PASS
- shard-kbl: FAIL [fdo#108145] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
- shard-apl: FAIL [fdo#110037] -> PASS +3
* {igt@kms_plane_multiple@atomic-pipe-c-tiling-y}:
- shard-glk: FAIL [fdo#110037] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
* igt@sw_sync@sync_busy_fork_unixsocket:
- shard-apl: FAIL [fdo#110150 ] -> PASS
- shard-glk: FAIL [fdo#110150 ] -> PASS
- shard-hsw: FAIL [fdo#110150 ] -> PASS
- shard-kbl: FAIL [fdo#110150 ] -> PASS
#### Warnings ####
* igt@gem_bad_reloc@negative-reloc-bsd2:
- shard-glk: SKIP [fdo#109271] -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-glk: FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> FAIL [fdo#110098]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110033]: https://bugs.freedesktop.org/show_bug.cgi?id=110033
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
[fdo#110127]: https://bugs.freedesktop.org/show_bug.cgi?id=110127
[fdo#110150 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110150
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4888 -> IGTPW_2648
* Linux: CI_DRM_5756 -> CI_DRM_5763
CI_DRM_5756: 0a2a982693ac3f3ecabf8e6c12cb18aa993ae3b0 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5763: de2772b353b83e6347687973dfff6f7f5257e364 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2648: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2648/
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2648/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-18 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-18 8:13 [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg Chris Wilson
2019-03-18 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-18 13:14 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-03-18 15:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox