* [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test
@ 2019-03-22 14:17 Uma Shankar
2019-03-22 14:11 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Uma Shankar @ 2019-03-22 14:17 UTC (permalink / raw)
To: igt-dev; +Cc: ville.syrjala, maarten.lankhorst
Due to Gamma/Degamma limitation with precision (lack of
exact 1.0 representation) due to ABI restriction, applying
linear gamma affects crc. This patch fixes the same by making
ctm tests independant of gamma/degamma.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
tests/kms_color.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..0656682 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -662,13 +662,9 @@ static bool test_pipe_ctm(data_t *data,
0.0, 1.0, 0.0,
0.0, 0.0, 1.0
};
- double *degamma_linear, *gamma_linear;
igt_output_t *output;
bool ret = true;
- degamma_linear = generate_table(data->degamma_lut_size, 1.0);
- gamma_linear = generate_table(data->gamma_lut_size, 1.0);
-
for_each_valid_output_on_pipe(&data->display, primary->pipe->pipe, output) {
drmModeModeInfo *mode;
struct igt_fb fb_modeset, fb;
@@ -696,8 +692,6 @@ static bool test_pipe_ctm(data_t *data,
igt_assert(fb_modeset_id);
igt_plane_set_fb(primary, &fb_modeset);
- set_degamma(data, primary->pipe, degamma_linear);
- set_gamma(data, primary->pipe, gamma_linear);
disable_ctm(primary->pipe);
igt_display_commit(&data->display);
@@ -725,9 +719,6 @@ static bool test_pipe_ctm(data_t *data,
igt_output_set_pipe(output, PIPE_NONE);
}
- free(degamma_linear);
- free(gamma_linear);
-
return ret;
}
--
1.9.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test
2019-03-22 14:17 [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
@ 2019-03-22 14:11 ` Ville Syrjälä
2019-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-23 14:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2019-03-22 14:11 UTC (permalink / raw)
To: Uma Shankar; +Cc: igt-dev, ville.syrjala, maarten.lankhorst
On Fri, Mar 22, 2019 at 07:47:33PM +0530, Uma Shankar wrote:
> Due to Gamma/Degamma limitation with precision (lack of
> exact 1.0 representation) due to ABI restriction, applying
> linear gamma affects crc. This patch fixes the same by making
> ctm tests independant of gamma/degamma.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_color.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index decf3c2..0656682 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -662,13 +662,9 @@ static bool test_pipe_ctm(data_t *data,
> 0.0, 1.0, 0.0,
> 0.0, 0.0, 1.0
> };
> - double *degamma_linear, *gamma_linear;
> igt_output_t *output;
> bool ret = true;
>
> - degamma_linear = generate_table(data->degamma_lut_size, 1.0);
> - gamma_linear = generate_table(data->gamma_lut_size, 1.0);
> -
> for_each_valid_output_on_pipe(&data->display, primary->pipe->pipe, output) {
> drmModeModeInfo *mode;
> struct igt_fb fb_modeset, fb;
> @@ -696,8 +692,6 @@ static bool test_pipe_ctm(data_t *data,
> igt_assert(fb_modeset_id);
> igt_plane_set_fb(primary, &fb_modeset);
>
> - set_degamma(data, primary->pipe, degamma_linear);
> - set_gamma(data, primary->pipe, gamma_linear);
> disable_ctm(primary->pipe);
> igt_display_commit(&data->display);
>
> @@ -725,9 +719,6 @@ static bool test_pipe_ctm(data_t *data,
> igt_output_set_pipe(output, PIPE_NONE);
> }
>
> - free(degamma_linear);
> - free(gamma_linear);
> -
> return ret;
> }
>
> --
> 1.9.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test
2019-03-22 14:17 [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-03-22 14:11 ` Ville Syrjälä
@ 2019-03-22 15:02 ` Patchwork
2019-03-23 14:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-22 15:02 UTC (permalink / raw)
To: Uma Shankar; +Cc: igt-dev
== Series Details ==
Series: tests/kms_color: Fix CRC mismatch issues with ctm test
URL : https://patchwork.freedesktop.org/series/58412/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5795 -> IGTPW_2690
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2690 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +41
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +55
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_ctx_param@basic:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +106
* igt@gem_exec_basic@basic-bsd2:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_basic@gtt-bsd:
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +103
* igt@gem_exec_basic@readonly-bsd:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_gttfill@basic:
- fi-skl-gvtdvm: NOTRUN -> SKIP [fdo#109271] +41
* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: NOTRUN -> SKIP [fdo#109271] +45
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]
- fi-icl-u2: PASS -> FAIL [fdo#103167]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
Participating hosts (33 -> 35)
------------------------------
Additional (11): fi-skl-gvtdvm fi-bsw-n3050 fi-bwr-2160 fi-snb-2520m fi-kbl-x1275 fi-gdg-551 fi-icl-u3 fi-pnv-d510 fi-bsw-kefka fi-skl-lmem fi-skl-6700k2
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-byt-n2820 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4899 -> IGTPW_2690
CI_DRM_5795: 9b13e20521f1b66a20161bd3afd6727f383db604 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2690: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2690/
IGT_4899: ba96339c238180b38d05d7fa2dca772d49eee332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2690/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_color: Fix CRC mismatch issues with ctm test
2019-03-22 14:17 [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-03-22 14:11 ` Ville Syrjälä
2019-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-23 14:12 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-23 14:12 UTC (permalink / raw)
To: Uma Shankar; +Cc: igt-dev
== Series Details ==
Series: tests/kms_color: Fix CRC mismatch issues with ctm test
URL : https://patchwork.freedesktop.org/series/58412/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5795_full -> IGTPW_2690_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2690_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2690_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2690_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_color@pipe-a-ctm-0-25:
- shard-kbl: PASS -> FAIL +8
* igt@kms_color@pipe-a-ctm-0-75:
- shard-apl: PASS -> FAIL +7
* igt@kms_color@pipe-b-ctm-green-to-red:
- shard-glk: PASS -> FAIL +10
* igt@kms_color@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> FAIL +1
Known issues
------------
Here are the changes found in IGTPW_2690_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parse@basic-rejected:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +17
* igt@gem_mocs_settings@mocs-rc6-render:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +58
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222] +2
- shard-kbl: PASS -> DMESG-WARN [fdo#110222] +2
- shard-snb: PASS -> DMESG-WARN [fdo#110222] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-snb: NOTRUN -> INCOMPLETE [fdo#105411]
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#103355]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-glk: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +48
#### Possible fixes ####
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: FAIL [fdo#109660] -> PASS
- shard-kbl: FAIL [fdo#109660] -> PASS
* igt@kms_atomic_transition@2x-modeset-transitions-fencing:
- shard-hsw: SKIP [fdo#109271] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_color@pipe-c-ctm-max:
- shard-glk: FAIL [fdo#108147] -> PASS +2
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: FAIL [fdo#102887] -> PASS
* igt@kms_flip@plain-flip-ts-check:
- shard-glk: FAIL [fdo#100368] -> PASS
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
* igt@perf_pmu@semaphore-wait-vcs0:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4899 -> IGTPW_2690
* Piglit: piglit_4509 -> None
CI_DRM_5795: 9b13e20521f1b66a20161bd3afd6727f383db604 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2690: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2690/
IGT_4899: ba96339c238180b38d05d7fa2dca772d49eee332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2690/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-23 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-22 14:17 [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test Uma Shankar
2019-03-22 14:11 ` Ville Syrjälä
2019-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-23 14:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox