* [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
@ 2019-03-26 18:57 Chris Wilson
2019-03-26 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-03-26 18:57 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Even with 128MiB reserved for other use, a single pass of gem_exec_big
runs out of memory. Give in and halve our batch size, that has to be
enough slack! As to why it keeps on failing, is left as an exercise to
the reader -- we have to solve the mm/ mystery one day, as eventually it
will be our only remaining source of bugs!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
---
tests/i915/gem_exec_big.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index 015f59e29..440136ee8 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -260,7 +260,7 @@ static void single(int i915)
uint32_t handle;
void *ptr;
- batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
+ batch_size = (intel_get_avail_ram_mb() / 2) << 20; /* XXX CI slack? */
limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
if (!gem_uses_full_ppgtt(i915))
limit = 3 * limit / 4;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
2019-03-26 18:57 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope! Chris Wilson
@ 2019-03-26 19:37 ` Patchwork
2019-03-27 4:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-27 6:16 ` [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-26 19:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
URL : https://patchwork.freedesktop.org/series/58602/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5818 -> IGTPW_2715
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58602/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2715 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770: SKIP [fdo#109271] -> PASS +2
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4905 -> IGTPW_2715
CI_DRM_5818: de0e80842f3d103996e99cfe27f999690c2ee06e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2715: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2715/
IGT_4905: a350b9f9f606296b1599c3617c8530a8985709e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2715/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
2019-03-26 18:57 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope! Chris Wilson
2019-03-26 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-27 4:07 ` Patchwork
2019-03-27 6:16 ` [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-03-27 4:07 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
URL : https://patchwork.freedesktop.org/series/58602/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5818_full -> IGTPW_2715_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58602/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2715_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_bad_reloc@negative-reloc-lut-bsd1:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +3
* igt@gem_exec_schedule@preempt-vebox:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +9
* igt@gem_softpin@noreloc-s3:
- shard-apl: PASS -> DMESG-WARN [fdo#108566]
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +22
* igt@kms_atomic_transition@4x-modeset-transitions-fencing:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@basic-flip-d:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
- shard-snb: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13
* igt@kms_color@pipe-b-degamma:
- shard-glk: NOTRUN -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +106
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +4
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-snb: NOTRUN -> FAIL [fdo#99912]
#### Possible fixes ####
* {igt@gem_exec_big@single}:
- shard-glk: FAIL -> PASS
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +2
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS +1
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
* {igt@kms_plane@pixel-format-pipe-c-planes}:
- shard-glk: SKIP [fdo#109271] -> PASS
* {igt@kms_plane@plane-position-covered-pipe-b-planes}:
- shard-glk: FAIL [fdo#110038] -> PASS
- shard-kbl: FAIL [fdo#110038] -> PASS
- shard-apl: FAIL [fdo#110038] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4905 -> IGTPW_2715
* Piglit: piglit_4509 -> None
CI_DRM_5818: de0e80842f3d103996e99cfe27f999690c2ee06e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2715: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2715/
IGT_4905: a350b9f9f606296b1599c3617c8530a8985709e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2715/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
2019-03-26 18:57 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope! Chris Wilson
2019-03-26 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-27 4:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-27 6:16 ` Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2019-03-27 6:16 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 26/03/2019 18:57, Chris Wilson wrote:
> Even with 128MiB reserved for other use, a single pass of gem_exec_big
> runs out of memory. Give in and halve our batch size, that has to be
> enough slack! As to why it keeps on failing, is left as an exercise to
> the reader -- we have to solve the mm/ mystery one day, as eventually it
> will be our only remaining source of bugs!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
> tests/i915/gem_exec_big.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index 015f59e29..440136ee8 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -260,7 +260,7 @@ static void single(int i915)
> uint32_t handle;
> void *ptr;
>
> - batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
> + batch_size = (intel_get_avail_ram_mb() / 2) << 20; /* XXX CI slack? */
> limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> if (!gem_uses_full_ppgtt(i915))
> limit = 3 * limit / 4;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-27 6:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-26 18:57 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope! Chris Wilson
2019-03-26 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-27 4:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-27 6:16 ` [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox