* [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test
@ 2019-04-01 15:17 Ville Syrjala
2019-04-02 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Ville Syrjala @ 2019-04-01 15:17 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Set the src/dst viewports correctly when trying to crop off the
edges.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110296
Fixes: 80eb61459791 ("tests/kms_plane: Remove the upscaling requirement")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_plane.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 33e2905a8d71..471bcbeb8f77 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -436,8 +436,11 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
/*
* if clamping test. DRM_FORMAT_XRGB8888 is used for reference color.
*/
- if (data->crop != 0 && format != DRM_FORMAT_XRGB8888)
+ if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) {
igt_fb_set_position(fb, plane, data->crop, data->crop);
+ igt_fb_set_size(fb, plane, width, height);
+ igt_plane_set_size(plane, width, height);
+ }
igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: Fix crop test
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
@ 2019-04-02 5:51 ` Patchwork
2019-04-02 7:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-02 5:51 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane: Fix crop test
URL : https://patchwork.freedesktop.org/series/58838/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5852 -> IGTPW_2755
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58838/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2755 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_parse@basic-rejected:
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u3: PASS -> DMESG-WARN [fdo#109638]
* igt@i915_selftest@live_contexts:
- fi-icl-y: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bwr-2160: PASS -> FAIL [fdo#100368]
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3
* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]
* igt@runner@aborted:
- fi-skl-6700k2: NOTRUN -> FAIL [fdo#104108]
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-hsw-peppy: DMESG-FAIL -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
Participating hosts (50 -> 44)
------------------------------
Additional (1): fi-icl-y
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4917 -> IGTPW_2755
CI_DRM_5852: ddcab27b76cf685a9136cf26f11103765fd7d8d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2755: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
IGT_4917: ec9792ad770d5055d6f42e2a481b8314754c9218 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane: Fix crop test
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
2019-04-02 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-02 7:38 ` Patchwork
2019-04-02 7:57 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2019-04-02 9:02 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-02 7:38 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane: Fix crop test
URL : https://patchwork.freedesktop.org/series/58838/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5852_full -> IGTPW_2755_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2755_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2755_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58838/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2755_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2755_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@smoketest-blt:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +22
* igt@kms_busy@basic-modeset-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10
* igt@kms_chamelium@common-hpd-after-suspend:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +1
* igt@kms_concurrent@pipe-f:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_content_protection@legacy:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +82
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894] +3
- shard-kbl: PASS -> FAIL [fdo#104894] +3
* igt@prime_nv_pcopy@test1_micro:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +2
* igt@testdisplay:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-hsw: FAIL [fdo#102887] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-snb: FAIL [fdo#110296 ] -> PASS +1
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#110296 ] -> PASS +2
- shard-hsw: FAIL [fdo#110296 ] -> PASS +2
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-kbl: FAIL [fdo#110296 ] -> PASS +2
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
#### Warnings ####
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#110296 ] -> SKIP [fdo#109271] +2
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110296 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110296
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4917 -> IGTPW_2755
* Piglit: piglit_4509 -> None
CI_DRM_5852: ddcab27b76cf685a9136cf26f11103765fd7d8d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2755: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
IGT_4917: ec9792ad770d5055d6f42e2a481b8314754c9218 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: Fix crop test
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
2019-04-02 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-02 7:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-04-02 7:57 ` Patchwork
2019-04-02 9:02 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-02 7:57 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane: Fix crop test
URL : https://patchwork.freedesktop.org/series/58838/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5852_full -> IGTPW_2755_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58838/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2755_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@smoketest-blt:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +22
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: PASS -> FAIL [fdo#108686]
* igt@kms_busy@basic-modeset-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10
* igt@kms_chamelium@common-hpd-after-suspend:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +1
* igt@kms_concurrent@pipe-f:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_content_protection@legacy:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +82
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894] +3
- shard-kbl: PASS -> FAIL [fdo#104894] +3
* igt@prime_nv_pcopy@test1_micro:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +2
* igt@testdisplay:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-hsw: FAIL [fdo#102887] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-snb: FAIL [fdo#110296 ] -> PASS +1
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#110296 ] -> PASS +2
- shard-hsw: FAIL [fdo#110296 ] -> PASS +2
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-kbl: FAIL [fdo#110296 ] -> PASS +2
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
#### Warnings ####
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#110296 ] -> SKIP [fdo#109271] +2
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110296 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110296
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4917 -> IGTPW_2755
* Piglit: piglit_4509 -> None
CI_DRM_5852: ddcab27b76cf685a9136cf26f11103765fd7d8d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2755: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
IGT_4917: ec9792ad770d5055d6f42e2a481b8314754c9218 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2755/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
` (2 preceding siblings ...)
2019-04-02 7:57 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
@ 2019-04-02 9:02 ` Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-04-02 9:02 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
On Mon, Apr 01, 2019 at 06:17:07PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Set the src/dst viewports correctly when trying to crop off the
> edges.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110296
> Fixes: 80eb61459791 ("tests/kms_plane: Remove the upscaling requirement")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Oops, bad review by me :-/
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
... but not sure how much value there is in that ...
-Daniel
> ---
> tests/kms_plane.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 33e2905a8d71..471bcbeb8f77 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -436,8 +436,11 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
> /*
> * if clamping test. DRM_FORMAT_XRGB8888 is used for reference color.
> */
> - if (data->crop != 0 && format != DRM_FORMAT_XRGB8888)
> + if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) {
> igt_fb_set_position(fb, plane, data->crop, data->crop);
> + igt_fb_set_size(fb, plane, width, height);
> + igt_plane_set_size(plane, width, height);
> + }
>
> igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
> --
> 2.19.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-02 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
2019-04-02 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-02 7:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-04-02 7:57 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2019-04-02 9:02 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox