* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes
@ 2019-04-02 13:08 Ville Syrjala
2019-04-02 14:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-04-02 13:08 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We may not be able to enable all the planes simultaneously. In that
case just keep going with fewer planes. The test already requires
atomic so let's use TEST_ONLY unconditionally.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_concurrent.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 117016dc44e8..d82ca0404839 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -184,6 +184,7 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
y[primary->index] = 0;
for (i = 0; i < max_planes; i++) {
igt_plane_t *plane = igt_output_get_plane(output, i);
+ int ret;
if (plane->type == DRM_PLANE_TYPE_PRIMARY)
continue;
@@ -206,7 +207,18 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
igt_plane_set_position(data->plane[i], x[i], y[i]);
igt_plane_set_fb(data->plane[i], &data->fb[i]);
+
+ ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
+ if (ret) {
+ igt_plane_set_fb(data->plane[i], NULL);
+ igt_remove_fb(data->drm_fd, &data->fb[i]);
+ data->plane[i] = NULL;
+ break;
+ }
}
+ max_planes = i;
+
+ igt_assert_lt(0, max_planes);
/* primary plane */
data->plane[primary->index] = primary;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-02 13:08 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes Ville Syrjala
@ 2019-04-02 14:01 ` Patchwork
2019-04-02 17:49 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-04-02 14:01 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Allow the test to proceed with fewer planes
URL : https://patchwork.freedesktop.org/series/58872/
State : success
== Summary ==
CI Bug Log - changes from IGT_4920 -> IGTPW_2760
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58872/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2760 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_psr@primary_mmap_gtt:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +27
* igt@runner@aborted:
- fi-skl-iommu: NOTRUN -> FAIL [fdo#104108] / [fdo#108602]
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (48 -> 44)
------------------------------
Additional (2): fi-bsw-n3050 fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4920 -> IGTPW_2760
CI_DRM_5854: 3b59d4fb5ba3fb53a87c7a4495d81b0a25aa96eb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2760: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
IGT_4920: dc36fa26305b832686616f3fadb1ef05f10f0f8f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-02 13:08 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes Ville Syrjala
2019-04-02 14:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-02 17:49 ` Souza, Jose
2019-04-02 21:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-04-03 8:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
3 siblings, 0 replies; 8+ messages in thread
From: Souza, Jose @ 2019-04-02 17:49 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, igt-dev@lists.freedesktop.org
[-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --]
On Tue, 2019-04-02 at 16:08 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We may not be able to enable all the planes simultaneously. In that
> case just keep going with fewer planes. The test already requires
> atomic so let's use TEST_ONLY unconditionally.
Tested and Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_concurrent.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 117016dc44e8..d82ca0404839 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -184,6 +184,7 @@ prepare_planes(data_t *data, enum pipe pipe, int
> max_planes,
> y[primary->index] = 0;
> for (i = 0; i < max_planes; i++) {
> igt_plane_t *plane = igt_output_get_plane(output, i);
> + int ret;
>
> if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> continue;
> @@ -206,7 +207,18 @@ prepare_planes(data_t *data, enum pipe pipe, int
> max_planes,
>
> igt_plane_set_position(data->plane[i], x[i], y[i]);
> igt_plane_set_fb(data->plane[i], &data->fb[i]);
> +
> + ret = igt_display_try_commit_atomic(&data->display,
> DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> + if (ret) {
> + igt_plane_set_fb(data->plane[i], NULL);
> + igt_remove_fb(data->drm_fd, &data->fb[i]);
> + data->plane[i] = NULL;
> + break;
> + }
> }
> + max_planes = i;
> +
> + igt_assert_lt(0, max_planes);
>
> /* primary plane */
> data->plane[primary->index] = primary;
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-02 13:08 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes Ville Syrjala
2019-04-02 14:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-02 17:49 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
@ 2019-04-02 21:21 ` Patchwork
2019-04-03 0:28 ` Souza, Jose
2019-04-03 8:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
3 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2019-04-02 21:21 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Allow the test to proceed with fewer planes
URL : https://patchwork.freedesktop.org/series/58872/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4920_full -> IGTPW_2760_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2760_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2760_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58872/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2760_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_vblank@pipe-b-ts-continuation-modeset:
- shard-kbl: PASS -> DMESG-FAIL
Known issues
------------
Here are the changes found in IGTPW_2760_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-bsd1:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +22
* igt@gem_exec_schedule@independent-bsd2:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +63
* igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +12
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-oldfb-render-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-e:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +2
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: PASS -> FAIL [fdo#104873]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +32
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +75
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_plane_scaling@pipe-c-plane-scaling:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: NOTRUN -> DMESG-FAIL [fdo#105763]
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +1
#### Possible fixes ####
* igt@gem_ctx_isolation@vecs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS +2
- shard-snb: DMESG-WARN [fdo#110222] -> PASS +2
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS +1
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-kbl: FAIL [fdo#103167] -> PASS
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- shard-glk: FAIL [fdo#110037] -> PASS
- shard-apl: FAIL [fdo#110037] -> PASS
- shard-kbl: FAIL [fdo#110037] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS +2
* igt@prime_busy@hang-vebox:
- shard-apl: FAIL [fdo#108807] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4920 -> IGTPW_2760
CI_DRM_5854: 3b59d4fb5ba3fb53a87c7a4495d81b0a25aa96eb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2760: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
IGT_4920: dc36fa26305b832686616f3fadb1ef05f10f0f8f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-02 21:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2019-04-03 0:28 ` Souza, Jose
2019-04-03 8:36 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Souza, Jose @ 2019-04-03 0:28 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, igt-dev@lists.freedesktop.org
[-- Attachment #1.1: Type: text/plain, Size: 8134 bytes --]
On Tue, 2019-04-02 at 21:21 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: tests/kms_concurrent: Allow the test to proceed with fewer
> planes
> URL : https://patchwork.freedesktop.org/series/58872/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from IGT_4920_full -> IGTPW_2760_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_2760_full absolutely need
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the
> changes
> introduced in IGTPW_2760_full, please notify your bug team to allow
> them
> to document this new failure mode, which will reduce false
> positives in CI.
>
> External URL:
> https://patchwork.freedesktop.org/api/1.0/series/58872/revisions/1/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in
> IGTPW_2760_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@kms_vblank@pipe-b-ts-continuation-modeset:
> - shard-kbl: PASS -> DMESG-FAIL
Not related at all.
Patch pushed.
Thanks
>
>
> Known issues
> ------------
>
> Here are the changes found in IGTPW_2760_full that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_busy@busy-bsd1:
> - shard-apl: NOTRUN -> SKIP [fdo#109271] +22
>
> * igt@gem_exec_schedule@independent-bsd2:
> - shard-glk: NOTRUN -> SKIP [fdo#109271] +63
>
> * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
> - shard-snb: NOTRUN -> SKIP [fdo#109271] +12
>
> * igt@kms_busy@extended-modeset-hang-newfb-render-c:
> - shard-glk: NOTRUN -> DMESG-WARN [fdo#110222]
>
> * igt@kms_busy@extended-modeset-hang-oldfb-render-d:
> - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +1
>
> * igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-e:
> - shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +4
>
> * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> - shard-hsw: NOTRUN -> DMESG-WARN [fdo#110222]
>
> * igt@kms_cursor_crc@cursor-64x64-onscreen:
> - shard-glk: NOTRUN -> FAIL [fdo#103232] +2
>
> * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
> - shard-glk: PASS -> FAIL [fdo#104873]
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
> - shard-kbl: NOTRUN -> SKIP [fdo#109271] +32
>
> * igt@kms
> _frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
> - shard-hsw: NOTRUN -> SKIP [fdo#109271] +75
>
> * igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
> - shard-kbl: NOTRUN -> FAIL [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
> - shard-glk: PASS -> FAIL [fdo#108145]
> - shard-apl: PASS -> FAIL [fdo#108145]
> - shard-kbl: PASS -> FAIL [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
> - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +1
>
> * igt@kms_plane_scaling@2x-scaler-multi-pipe:
> - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +2
>
> * igt@kms_plane_scaling@pipe-c-plane-scaling:
> - shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
> +8
>
> * igt@kms_rotation_crc@multiplane-rotation:
> - shard-kbl: PASS -> INCOMPLETE [fdo#103665]
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
> - shard-kbl: NOTRUN -> DMESG-FAIL [fdo#105763]
>
> * igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
> - shard-apl: PASS -> FAIL [fdo#104894] +1
>
>
> #### Possible fixes ####
>
> * igt@gem_ctx_isolation@vecs0-s3:
> - shard-kbl: INCOMPLETE [fdo#103665] -> PASS
>
> * igt@kms_atomic_transition@plane-all-modeset-transition:
> - shard-apl: INCOMPLETE [fdo#103927] -> PASS
>
> * igt@kms_busy@extended-modeset-hang-newfb-render-a:
> - shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
>
> * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
> - shard-kbl: DMESG-WARN [fdo#110222] -> PASS +2
> - shard-snb: DMESG-WARN [fdo#110222] -> PASS +2
>
> * igt@kms_cursor_crc@cursor-128x42-sliding:
> - shard-apl: FAIL [fdo#103232] -> PASS
>
> * igt@kms_cursor_crc@cursor-256x256-suspend:
> - shard-apl: DMESG-WARN [fdo#108566] -> PASS
>
> * igt@kms_flip@flip-vs-suspend:
> - shard-hsw: INCOMPLETE [fdo#103540] -> PASS +1
> - shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] ->
> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
> - shard-kbl: FAIL [fdo#103167] -> PASS
> - shard-apl: FAIL [fdo#103167] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen
> :
> - shard-glk: FAIL [fdo#103167] -> PASS
>
> * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
> - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS +1
>
> * igt@kms_setmode@basic:
> - shard-kbl: FAIL [fdo#99912] -> PASS
>
> * igt@kms_universal_plane@universal-plane-pipe-a-functional:
> - shard-glk: FAIL [fdo#110037] -> PASS
> - shard-apl: FAIL [fdo#110037] -> PASS
> - shard-kbl: FAIL [fdo#110037] -> PASS
>
> * igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
> - shard-kbl: FAIL [fdo#104894] -> PASS
>
> * igt@kms_vblank@pipe-c-ts-continuation-suspend:
> - shard-apl: FAIL [fdo#104894] -> PASS +2
>
> * igt@prime_busy@hang-vebox:
> - shard-apl: FAIL [fdo#108807] -> PASS
>
>
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
> [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
> [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> [fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
> [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
> [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (7 -> 5)
> ------------------------------
>
> Missing (2): shard-skl shard-iclb
>
>
> Build changes
> -------------
>
> * IGT: IGT_4920 -> IGTPW_2760
>
> CI_DRM_5854: 3b59d4fb5ba3fb53a87c7a4495d81b0a25aa96eb @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_2760: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
> IGT_4920: dc36fa26305b832686616f3fadb1ef05f10f0f8f @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2760/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-03 0:28 ` Souza, Jose
@ 2019-04-03 8:36 ` Daniel Vetter
2019-04-03 8:48 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-04-03 8:36 UTC (permalink / raw)
To: Souza, Jose; +Cc: igt-dev@lists.freedesktop.org
On Wed, Apr 03, 2019 at 12:28:12AM +0000, Souza, Jose wrote:
> On Tue, 2019-04-02 at 21:21 +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/kms_concurrent: Allow the test to proceed with fewer
> > planes
> > URL : https://patchwork.freedesktop.org/series/58872/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from IGT_4920_full -> IGTPW_2760_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **FAILURE**
> >
> > Serious unknown changes coming with IGTPW_2760_full absolutely need
> > to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the
> > changes
> > introduced in IGTPW_2760_full, please notify your bug team to allow
> > them
> > to document this new failure mode, which will reduce false
> > positives in CI.
> >
> > External URL:
> > https://patchwork.freedesktop.org/api/1.0/series/58872/revisions/1/mbox/
> >
> > Possible new issues
> > -------------------
> >
> > Here are the unknown changes that may have been introduced in
> > IGTPW_2760_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> > * igt@kms_vblank@pipe-b-ts-continuation-modeset:
> > - shard-kbl: PASS -> DMESG-FAIL
>
> Not related at all.
>
> Patch pushed.
See my reply, I think we now have a test gap. Can you pls fill that again?
I know there's a pile of pressure, but that's no good reason to rush
stuff.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-03 8:36 ` Daniel Vetter
@ 2019-04-03 8:48 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-04-03 8:48 UTC (permalink / raw)
To: Souza, Jose; +Cc: igt-dev@lists.freedesktop.org
On Wed, Apr 03, 2019 at 10:36:41AM +0200, Daniel Vetter wrote:
> On Wed, Apr 03, 2019 at 12:28:12AM +0000, Souza, Jose wrote:
> > On Tue, 2019-04-02 at 21:21 +0000, Patchwork wrote:
> > > == Series Details ==
> > >
> > > Series: tests/kms_concurrent: Allow the test to proceed with fewer
> > > planes
> > > URL : https://patchwork.freedesktop.org/series/58872/
> > > State : failure
> > >
> > > == Summary ==
> > >
> > > CI Bug Log - changes from IGT_4920_full -> IGTPW_2760_full
> > > ====================================================
> > >
> > > Summary
> > > -------
> > >
> > > **FAILURE**
> > >
> > > Serious unknown changes coming with IGTPW_2760_full absolutely need
> > > to be
> > > verified manually.
> > >
> > > If you think the reported changes have nothing to do with the
> > > changes
> > > introduced in IGTPW_2760_full, please notify your bug team to allow
> > > them
> > > to document this new failure mode, which will reduce false
> > > positives in CI.
> > >
> > > External URL:
> > > https://patchwork.freedesktop.org/api/1.0/series/58872/revisions/1/mbox/
> > >
> > > Possible new issues
> > > -------------------
> > >
> > > Here are the unknown changes that may have been introduced in
> > > IGTPW_2760_full:
> > >
> > > ### IGT changes ###
> > >
> > > #### Possible regressions ####
> > >
> > > * igt@kms_vblank@pipe-b-ts-continuation-modeset:
> > > - shard-kbl: PASS -> DMESG-FAIL
> >
> > Not related at all.
> >
> > Patch pushed.
>
> See my reply, I think we now have a test gap. Can you pls fill that again?
>
> I know there's a pile of pressure, but that's no good reason to rush
> stuff.
btw I'll be on vacations for 1 week starting this Fri, so if you want me
to review your patch, pls send it out today.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes
2019-04-02 13:08 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes Ville Syrjala
` (2 preceding siblings ...)
2019-04-02 21:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2019-04-03 8:35 ` Daniel Vetter
3 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-04-03 8:35 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
On Tue, Apr 02, 2019 at 04:08:37PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We may not be able to enable all the planes simultaneously. In that
> case just keep going with fewer planes. The test already requires
> atomic so let's use TEST_ONLY unconditionally.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_concurrent.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 117016dc44e8..d82ca0404839 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -184,6 +184,7 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
> y[primary->index] = 0;
> for (i = 0; i < max_planes; i++) {
> igt_plane_t *plane = igt_output_get_plane(output, i);
> + int ret;
>
> if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> continue;
> @@ -206,7 +207,18 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
>
> igt_plane_set_position(data->plane[i], x[i], y[i]);
> igt_plane_set_fb(data->plane[i], &data->fb[i]);
> +
> + ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> + if (ret) {
> + igt_plane_set_fb(data->plane[i], NULL);
> + igt_remove_fb(data->drm_fd, &data->fb[i]);
> + data->plane[i] = NULL;
> + break;
> + }
> }
> + max_planes = i;
Imo we need to shuffle planes, to make sure we don't just test the first
few all the times. Shouldn't be too hard to insert an igt_permute_array
to shuffle stuff around. Without that we leave a pretty big test hole
behind.
Same for the other testcases where we actually want to validate planes
working correctly.
-Daniel
> +
> + igt_assert_lt(0, max_planes);
>
> /* primary plane */
> data->plane[primary->index] = primary;
> --
> 2.19.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-03 8:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-02 13:08 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Allow the test to proceed with fewer planes Ville Syrjala
2019-04-02 14:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-02 17:49 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2019-04-02 21:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-04-03 0:28 ` Souza, Jose
2019-04-03 8:36 ` Daniel Vetter
2019-04-03 8:48 ` Daniel Vetter
2019-04-03 8:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox