[igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more

[igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more

[Daniel Vetter]

Success is not the right status if the test does nothing. Fix that.

Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_color.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2a680e..d2352cf8a9ba 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -1135,8 +1135,7 @@ invalid_ctm_matrix_sizes(data_t *data)
 	igt_pipe_t *pipe = &display->pipes[0];
 	void *ptr;
 
-	if (!igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
-		return;
+	igt_require(igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM));
 
 	ptr = malloc(sizeof(struct _drm_color_ctm) * 4);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more

[Daniel Vetter]

On Wed, Apr 03, 2019 at 03:50:42PM +0200, Daniel Vetter wrote:
> Success is not the right status if the test does nothing. Fix that.
> 
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Please disregard, Ville has a patch covering this one already.
-Daniel

> ---
>  tests/kms_color.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index decf3c2a680e..d2352cf8a9ba 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -1135,8 +1135,7 @@ invalid_ctm_matrix_sizes(data_t *data)
>  	igt_pipe_t *pipe = &display->pipes[0];
>  	void *ptr;
>  
> -	if (!igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
> -		return;
> +	igt_require(igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM));
>  
>  	ptr = malloc(sizeof(struct _drm_color_ctm) * 4);
>  
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Use igt_require more

[Patchwork]

== Series Details ==

Series: tests/kms_color: Use igt_require more
URL   : https://patchwork.freedesktop.org/series/58951/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5863 -> IGTPW_2776
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2776 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2776, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58951/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2776:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      PASS -> DMESG-FAIL

  
Known issues
------------

  Here are the changes found in IGTPW_2776 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_store@basic-bsd1:
    - fi-kbl-r:           NOTRUN -> SKIP [fdo#109271] +41

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362] +1

  
#### Possible fixes ####

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  * igt@kms_pipe_crc_basic@read-crc-pipe-a:
    - fi-byt-clapper:     FAIL [fdo#107362] -> PASS

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271


Participating hosts (47 -> 41)
------------------------------

  Additional (1): fi-kbl-r 
  Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4924 -> IGTPW_2776

  CI_DRM_5863: d2c849411d8ae6de9c718b9c0cd1e00da7f0f121 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2776: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2776/
  IGT_4924: bcf2f21996b2ee5c6177f5412046690ff8017772 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2776/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev