[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Mika Kahola]

Update the list of pixel formats that cannot be rotated by 90/270 degrees. With this patch,
the kernel and IGT are aligned for i915 driver.

References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 079d2700..3d247130 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
 static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
 		       igt_rotation_t rot)
 {
-	if (format == DRM_FORMAT_C8 ||
-	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
-		return false;
 
-	// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
-	if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
-	    (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
+	if (!is_i915_device(d->drm_fd))
+		return true;
+
+	switch (format) {
+	case DRM_FORMAT_RGB565:
+		if (intel_gen(d->devid) >= 11)
+			break;
+		/* fall through */
+	case DRM_FORMAT_C8:
+	case DRM_FORMAT_XRGB16161616F:
+	case DRM_FORMAT_XBGR16161616F:
+	case DRM_FORMAT_ARGB16161616F:
+	case DRM_FORMAT_ABGR16161616F:
+	case DRM_FORMAT_Y210:
+	case DRM_FORMAT_Y212:
+	case DRM_FORMAT_Y216:
+	case DRM_FORMAT_XVYU12_16161616:
+	case DRM_FORMAT_XVYU16161616:
 		return false;
+	default:
+		break;
+	}
 
 	return true;
 }
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Update list of supported pixel formats for rotation
URL   : https://patchwork.freedesktop.org/series/59826/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5971 -> IGTPW_2904
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59826/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2904 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  
#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - fi-bwr-2160:        [FAIL][3] ([fdo#100368]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank.html

  
  [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 


Participating hosts (50 -> 44)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2904

  CI_DRM_5971: e91b848a66e8672c48ea65d082b260f13f2c86b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2904: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Update list of supported pixel formats for rotation
URL   : https://patchwork.freedesktop.org/series/59826/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5971_full -> IGTPW_2904_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59826/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2904_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +4 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-apl3/igt@i915_suspend@sysfs-reader.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-apl8/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-kbl6/igt@kms_flip@flip-vs-suspend.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-kbl5/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
    - shard-iclb:         [PASS][5] -> [FAIL][6] ([fdo#103167]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt:
    - shard-hsw:          NOTRUN -> [SKIP][7] ([fdo#109271]) +7 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-hsw3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-hsw:          NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#109278]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-hsw8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
    - shard-glk:          [PASS][9] -> [SKIP][10] ([fdo#109271] / [fdo#109278])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-glk4/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109642]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb7/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          [PASS][13] -> [DMESG-FAIL][14] ([fdo#105763])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][15] -> [FAIL][16] ([fdo#99912])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-kbl4/igt@kms_setmode@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-kbl5/igt@kms_setmode@basic.html

  * igt@perf_pmu@rc6-runtime-pm:
    - shard-kbl:          [PASS][17] -> [FAIL][18] ([fdo#105010])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-kbl3/igt@perf_pmu@rc6-runtime-pm.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-kbl4/igt@perf_pmu@rc6-runtime-pm.html
    - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#105010])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb6/igt@perf_pmu@rc6-runtime-pm.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb2/igt@perf_pmu@rc6-runtime-pm.html

  
#### Possible fixes ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [FAIL][21] ([fdo#108686]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb1/igt@gem_tiled_swapping@non-threaded.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb1/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +5 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-apl7/igt@gem_workarounds@suspend-resume.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-apl1/igt@gem_workarounds@suspend-resume.html

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [FAIL][25] ([fdo#104097]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb8/igt@i915_pm_rpm@i2c.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb6/igt@i915_pm_rpm@i2c.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][27] ([fdo#109349]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-hsw:          [INCOMPLETE][29] ([fdo#103540]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
    - shard-iclb:         [FAIL][31] ([fdo#103167]) -> [PASS][32] +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - shard-iclb:         [FAIL][33] ([fdo#103167] / [fdo#110378]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-rte.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [FAIL][35] ([fdo#103167]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [FAIL][37] ([fdo#103166]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
    - shard-glk:          [SKIP][39] ([fdo#109271] / [fdo#109278]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-glk7/igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
    - shard-iclb:         [FAIL][41] ([fdo#109052]) -> [PASS][42] +2 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb3/igt@kms_plane_scaling@pipe-b-scaler-with-rotation.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb6/igt@kms_plane_scaling@pipe-b-scaler-with-rotation.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][43] ([fdo#109441]) -> [PASS][44] +4 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5971/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2904
  * Piglit: piglit_4509 -> None

  CI_DRM_5971: e91b848a66e8672c48ea65d082b260f13f2c86b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2904: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2904/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Juha-Pekka Heikkila]

Look ok to me. Hope i915 doesn't get changes onto that list too frequently.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 23.4.2019 16.00, Mika Kahola wrote:
> Update the list of pixel formats that cannot be rotated by 90/270 degrees. With this patch,
> the kernel and IGT are aligned for i915 driver.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>   tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
>   1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 079d2700..3d247130 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
>   static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
>   		       igt_rotation_t rot)
>   {
> -	if (format == DRM_FORMAT_C8 ||
> -	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
> -		return false;
>   
> -	// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> -	if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
> -	    (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
> +	if (!is_i915_device(d->drm_fd))
> +		return true;
> +
> +	switch (format) {
> +	case DRM_FORMAT_RGB565:
> +		if (intel_gen(d->devid) >= 11)
> +			break;
> +		/* fall through */
> +	case DRM_FORMAT_C8:
> +	case DRM_FORMAT_XRGB16161616F:
> +	case DRM_FORMAT_XBGR16161616F:
> +	case DRM_FORMAT_ARGB16161616F:
> +	case DRM_FORMAT_ABGR16161616F:
> +	case DRM_FORMAT_Y210:
> +	case DRM_FORMAT_Y212:
> +	case DRM_FORMAT_Y216:
> +	case DRM_FORMAT_XVYU12_16161616:
> +	case DRM_FORMAT_XVYU16161616:
>   		return false;
> +	default:
> +		break;
> +	}
>   
>   	return true;
>   }
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Kahola, Mika]

Pushed. Thank you for the review!

Cheers,
Mika

On Wed, 2019-04-24 at 10:58 +0300, Juha-Pekka Heikkila wrote:
> Look ok to me. Hope i915 doesn't get changes onto that list too
> frequently.
> 
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> 
> On 23.4.2019 16.00, Mika Kahola wrote:
> > Update the list of pixel formats that cannot be rotated by 90/270
> > degrees. With this patch,
> > the kernel and IGT are aligned for i915 driver.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >   tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
> >   1 file changed, 21 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 079d2700..3d247130 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
> >   static bool can_rotate(data_t *d, unsigned format, uint64_t
> > tiling,
> >   		       igt_rotation_t rot)
> >   {
> > -	if (format == DRM_FORMAT_C8 ||
> > -	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
> > -		return false;
> >   
> > -	// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> > -	if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
> > -	    (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
> > +	if (!is_i915_device(d->drm_fd))
> > +		return true;
> > +
> > +	switch (format) {
> > +	case DRM_FORMAT_RGB565:
> > +		if (intel_gen(d->devid) >= 11)
> > +			break;
> > +		/* fall through */
> > +	case DRM_FORMAT_C8:
> > +	case DRM_FORMAT_XRGB16161616F:
> > +	case DRM_FORMAT_XBGR16161616F:
> > +	case DRM_FORMAT_ARGB16161616F:
> > +	case DRM_FORMAT_ABGR16161616F:
> > +	case DRM_FORMAT_Y210:
> > +	case DRM_FORMAT_Y212:
> > +	case DRM_FORMAT_Y216:
> > +	case DRM_FORMAT_XVYU12_16161616:
> > +	case DRM_FORMAT_XVYU16161616:
> >   		return false;
> > +	default:
> > +		break;
> > +	}
> >   
> >   	return true;
> >   }
> > 
> 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[James Ausmus]

On Wed, Apr 24, 2019 at 10:58:54AM +0300, Juha-Pekka Heikkila wrote:
> Look ok to me. Hope i915 doesn't get changes onto that list too frequently.

Is this something that would make sense for i915 to abstract out to a
header file, then just regularly copy that header file in to IGT to
ensure alignment - similar to how we copy the PCI IDs from kernel to
userspace components?

-James

> 
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> 
> On 23.4.2019 16.00, Mika Kahola wrote:
> > Update the list of pixel formats that cannot be rotated by 90/270 degrees. With this patch,
> > the kernel and IGT are aligned for i915 driver.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >   tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
> >   1 file changed, 21 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 079d2700..3d247130 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
> >   static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
> >   		       igt_rotation_t rot)
> >   {
> > -	if (format == DRM_FORMAT_C8 ||
> > -	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
> > -		return false;
> >   
> > -	// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> > -	if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
> > -	    (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
> > +	if (!is_i915_device(d->drm_fd))
> > +		return true;
> > +
> > +	switch (format) {
> > +	case DRM_FORMAT_RGB565:
> > +		if (intel_gen(d->devid) >= 11)
> > +			break;
> > +		/* fall through */
> > +	case DRM_FORMAT_C8:
> > +	case DRM_FORMAT_XRGB16161616F:
> > +	case DRM_FORMAT_XBGR16161616F:
> > +	case DRM_FORMAT_ARGB16161616F:
> > +	case DRM_FORMAT_ABGR16161616F:
> > +	case DRM_FORMAT_Y210:
> > +	case DRM_FORMAT_Y212:
> > +	case DRM_FORMAT_Y216:
> > +	case DRM_FORMAT_XVYU12_16161616:
> > +	case DRM_FORMAT_XVYU16161616:
> >   		return false;
> > +	default:
> > +		break;
> > +	}
> >   
> >   	return true;
> >   }
> > 
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation

[Kahola, Mika]

On Wed, 2019-04-24 at 12:16 -0700, James Ausmus wrote:
> On Wed, Apr 24, 2019 at 10:58:54AM +0300, Juha-Pekka Heikkila wrote:
> > Look ok to me. Hope i915 doesn't get changes onto that list too
> > frequently.
> 
> Is this something that would make sense for i915 to abstract out to a
> header file, then just regularly copy that header file in to IGT to
> ensure alignment - similar to how we copy the PCI IDs from kernel to
> userspace components?

I think we could do that. It seems that various pixel formats just
keeps coming. This solution was merely a short term solution just to
get our bugs fixed. 

One alternative solution could be that kernel would be able to tell IGT
what formats are able to do rotation.

Cheers,
Mika

> 
> -James
> 
> > 
> > Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > 
> > On 23.4.2019 16.00, Mika Kahola wrote:
> > > Update the list of pixel formats that cannot be rotated by 90/270
> > > degrees. With this patch,
> > > the kernel and IGT are aligned for i915 driver.
> > > 
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> > > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > > ---
> > >   tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
> > >   1 file changed, 21 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/tests/kms_plane_scaling.c
> > > b/tests/kms_plane_scaling.c
> > > index 079d2700..3d247130 100644
> > > --- a/tests/kms_plane_scaling.c
> > > +++ b/tests/kms_plane_scaling.c
> > > @@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
> > >   static bool can_rotate(data_t *d, unsigned format, uint64_t
> > > tiling,
> > >   		       igt_rotation_t rot)
> > >   {
> > > -	if (format == DRM_FORMAT_C8 ||
> > > -	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
> > > -		return false;
> > >   
> > > -	// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> > > -	if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
> > > -	    (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
> > > +	if (!is_i915_device(d->drm_fd))
> > > +		return true;
> > > +
> > > +	switch (format) {
> > > +	case DRM_FORMAT_RGB565:
> > > +		if (intel_gen(d->devid) >= 11)
> > > +			break;
> > > +		/* fall through */
> > > +	case DRM_FORMAT_C8:
> > > +	case DRM_FORMAT_XRGB16161616F:
> > > +	case DRM_FORMAT_XBGR16161616F:
> > > +	case DRM_FORMAT_ARGB16161616F:
> > > +	case DRM_FORMAT_ABGR16161616F:
> > > +	case DRM_FORMAT_Y210:
> > > +	case DRM_FORMAT_Y212:
> > > +	case DRM_FORMAT_Y216:
> > > +	case DRM_FORMAT_XVYU12_16161616:
> > > +	case DRM_FORMAT_XVYU16161616:
> > >   		return false;
> > > +	default:
> > > +		break;
> > > +	}
> > >   
> > >   	return true;
> > >   }
> > > 
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev