[igt-dev] [PATCH i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

[igt-dev] [PATCH i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

[Emil Velikov]

From: Emil Velikov <emil.velikov@collabora.com>

Currently we allocate a state and set the state cursor to 0. The latter
is not needed since it's already zero.

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
Please push this for me if patch looks good.  I have commit access, yet
am really short on time at the moment :-(
---
 lib/igt_kms.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index df9aafd2..de310042 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3274,7 +3274,6 @@ static int igt_atomic_commit(igt_display_t *display, uint32_t flags, void *user_
 	if (display->is_atomic != 1)
 		return -1;
 	req = drmModeAtomicAlloc();
-	drmModeAtomicSetCursor(req, 0);
 
 	for_each_pipe(display, pipe) {
 		igt_pipe_t *pipe_obj = &display->pipes[pipe];
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

[Patchwork]

== Series Details ==

Series: lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call
URL   : https://patchwork.freedesktop.org/series/59946/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6000 -> IGTPW_2921
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59946/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2921 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [DMESG-FAIL][1] ([fdo#110235 ]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 


Participating hosts (32 -> 28)
------------------------------

  Additional (11): fi-hsw-peppy fi-skl-6770hq fi-cfl-guc fi-byt-clapper fi-hsw-4770 fi-ivb-3770 fi-cfl-8109u fi-bsw-kefka fi-blb-e6850 fi-icl-dsi fi-kbl-r 
  Missing    (15): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-bsw-n3050 fi-skl-guc fi-bsw-cyan fi-snb-2520m fi-kbl-guc fi-ctg-p8600 fi-gdg-551 fi-skl-iommu fi-pnv-d510 fi-icl-y fi-skl-lmem fi-skl-6700k2 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2921

  CI_DRM_6000: a0c3fff52846356f63dd210cddf81e5bb01e7aa0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2921: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

[Patchwork]

== Series Details ==

Series: lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call
URL   : https://patchwork.freedesktop.org/series/59946/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6000_full -> IGTPW_2921_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59946/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2921_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [PASS][1] -> [DMESG-WARN][2] ([fdo#109982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb1/igt@i915_pm_rpm@i2c.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb2/igt@i915_pm_rpm@i2c.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-apl4/igt@i915_suspend@sysfs-reader.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-apl8/igt@i915_suspend@sysfs-reader.html

  * igt@kms_cursor_crc@cursor-64x64-dpms:
    - shard-kbl:          [PASS][5] -> [FAIL][6] ([fdo#103232])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl7/igt@kms_cursor_crc@cursor-64x64-dpms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl5/igt@kms_cursor_crc@cursor-64x64-dpms.html
    - shard-apl:          [PASS][7] -> [FAIL][8] ([fdo#103232])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-apl2/igt@kms_cursor_crc@cursor-64x64-dpms.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-apl7/igt@kms_cursor_crc@cursor-64x64-dpms.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
    - shard-iclb:         [PASS][9] -> [FAIL][10] ([fdo#103167]) +4 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][11] -> [FAIL][12] ([fdo#103166])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
    - shard-glk:          [PASS][13] -> [SKIP][14] ([fdo#109271] / [fdo#109278])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-glk9/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-glk3/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109642])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb7/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_sprite_blt:
    - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#109441]) +4 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          [PASS][19] -> [DMESG-FAIL][20] ([fdo#105763])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl4/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl7/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl6/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [INCOMPLETE][23] ([fdo#103665]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl5/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@kms_cursor_crc@cursor-256x256-suspend:
    - shard-kbl:          [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl5/igt@kms_cursor_crc@cursor-256x256-suspend.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl4/igt@kms_cursor_crc@cursor-256x256-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [FAIL][27] ([fdo#103167]) -> [PASS][28] +6 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [SKIP][29] ([fdo#109441]) -> [PASS][30] +3 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          [FAIL][31] ([fdo#109016]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-kbl2/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [FAIL][33] ([fdo#100047]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-iclb3/igt@kms_sysfs_edid_timing.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-iclb8/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6000/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/shard-apl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2921
  * Piglit: piglit_4509 -> None

  CI_DRM_6000: a0c3fff52846356f63dd210cddf81e5bb01e7aa0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2921: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2921/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

[Ser, Simon]

On Thu, 2019-04-25 at 16:43 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> Currently we allocate a state and set the state cursor to 0. The
> latter
> is not needed since it's already zero.
> 
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
> Please push this for me if patch looks good.  I have commit access,
> yet
> am really short on time at the moment :-(
> ---
>  lib/igt_kms.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index df9aafd2..de310042 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3274,7 +3274,6 @@ static int igt_atomic_commit(igt_display_t
> *display, uint32_t flags, void *user_
>  	if (display->is_atomic != 1)
>  		return -1;
>  	req = drmModeAtomicAlloc();
> -	drmModeAtomicSetCursor(req, 0);
>  
>  	for_each_pipe(display, pipe) {
>  		igt_pipe_t *pipe_obj = &display->pipes[pipe];
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev