public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard
@ 2019-05-20 18:39 Antonio Argenziano
  2019-05-21  7:10 ` Ser, Simon
  2019-05-21  9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2) Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Antonio Argenziano @ 2019-05-20 18:39 UTC (permalink / raw)
  To: igt-dev

The alsa library is only guaranteed to exists is the HAVE_CHAMELIUM flag
is set.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Simon Ser <simon.ser@intel.com>
---
 lib/igt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt.h b/lib/igt.h
index 5852d557..2ae43c30 100644
--- a/lib/igt.h
+++ b/lib/igt.h
@@ -35,13 +35,13 @@
 #include "igt_dummyload.h"
 #include "igt_fb.h"
 #include "igt_frame.h"
-#include "igt_alsa.h"
 #include "igt_audio.h"
 #include "igt_gt.h"
 #include "igt_kms.h"
 #include "igt_pm.h"
 #include "igt_stats.h"
 #ifdef HAVE_CHAMELIUM
+#include "igt_alsa.h"
 #include "igt_chamelium.h"
 #include "igt_chamelium_stream.h"
 #endif
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard
  2019-05-20 18:39 [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard Antonio Argenziano
@ 2019-05-21  7:10 ` Ser, Simon
  2019-05-21  9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2) Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Ser, Simon @ 2019-05-21  7:10 UTC (permalink / raw)
  To: igt-dev@lists.freedesktop.org, Argenziano, Antonio

On Mon, 2019-05-20 at 11:39 -0700, Antonio Argenziano wrote:
> The alsa library is only guaranteed to exists is the HAVE_CHAMELIUM flag
> is set.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Simon Ser <simon.ser@intel.com>

Thanks for the fix!

Reviewed-by: Simon Ser <simon.ser@intel.com>

and pushed.

> ---
>  lib/igt.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt.h b/lib/igt.h
> index 5852d557..2ae43c30 100644
> --- a/lib/igt.h
> +++ b/lib/igt.h
> @@ -35,13 +35,13 @@
>  #include "igt_dummyload.h"
>  #include "igt_fb.h"
>  #include "igt_frame.h"
> -#include "igt_alsa.h"
>  #include "igt_audio.h"
>  #include "igt_gt.h"
>  #include "igt_kms.h"
>  #include "igt_pm.h"
>  #include "igt_stats.h"
>  #ifdef HAVE_CHAMELIUM
> +#include "igt_alsa.h"
>  #include "igt_chamelium.h"
>  #include "igt_chamelium_stream.h"
>  #endif
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2)
  2019-05-20 18:39 [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard Antonio Argenziano
  2019-05-21  7:10 ` Ser, Simon
@ 2019-05-21  9:58 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-05-21  9:58 UTC (permalink / raw)
  To: Antonio Argenziano; +Cc: igt-dev

== Series Details ==

Series: lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2)
URL   : https://patchwork.freedesktop.org/series/60873/
State : failure

== Summary ==

Series 60873 revision 2 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-21  9:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 18:39 [igt-dev] [PATCH i-g-t] lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard Antonio Argenziano
2019-05-21  7:10 ` Ser, Simon
2019-05-21  9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt.h: Guard igt_alsa.h in HAVE_CHAMELIUM guard (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox