[igt-dev] [PATCH i-g-t] tests/prime_busy: Increase timeout to mind pre-silicon.

[igt-dev] [PATCH i-g-t] tests/prime_busy: Increase timeout to mind pre-silicon.

[Tomasz Lis]

From: "Lis, Tomasz" <tomasz.lis@intel.com>

On silicon, simple submission is finished much faster than in a second.
But for pre-silicon, it is not always the case. Six seconds should be
enough though.

Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
Cc: Mrzyglod Daniel T <daniel.t.mrzyglod@intel.com>
Cc: Michal Winiarski <michal.winiarski@intel.com>
Cc: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 tests/prime_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/prime_busy.c b/tests/prime_busy.c
index a82acbdb..8e0f3ca6 100644
--- a/tests/prime_busy.c
+++ b/tests/prime_busy.c
@@ -147,7 +147,7 @@ static void busy(int fd, unsigned ring, unsigned flags)
 	if ((flags & HANG) == 0) {
 		*bbe = MI_BATCH_BUFFER_END;
 		__sync_synchronize();
-		timeout = 1;
+		timeout = 6;
 	}
 
 	/* Calling busy in a loop should be enough to flush the rendering */
-- 
2.14.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/prime_busy: Increase timeout to mind pre-silicon.

[Patchwork]

== Series Details ==

Series: tests/prime_busy: Increase timeout to mind pre-silicon.
URL   : https://patchwork.freedesktop.org/series/61331/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6162 -> IGTPW_3076
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61331/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3076 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  
#### Possible fixes ####

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [FAIL][3] ([fdo#109483] / [fdo#109635 ]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (45 -> 40)
------------------------------

  Missing    (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3076

  CI_DRM_6162: d35e150f090fed2b37052ace606850ed7780c34d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3076: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/prime_busy: Increase timeout to mind pre-silicon.

[Patchwork]

== Series Details ==

Series: tests/prime_busy: Increase timeout to mind pre-silicon.
URL   : https://patchwork.freedesktop.org/series/61331/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6162_full -> IGTPW_3076_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61331/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3076_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [PASS][1] -> [SKIP][2] ([fdo#109271])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-snb2/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +4 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-apl8/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-hsw:          [PASS][5] -> [SKIP][6] ([fdo#109271]) +14 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-hsw5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-hsw1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-glk:          [PASS][7] -> [FAIL][8] ([fdo#103167])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#99912])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl3/igt@kms_setmode@basic.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-kbl1/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-apl:          [DMESG-WARN][11] ([fdo#108566]) -> [PASS][12] +4 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [FAIL][13] ([fdo#108686]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl3/igt@gem_tiled_swapping@non-threaded.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-kbl7/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
    - shard-hsw:          [SKIP][15] ([fdo#109271]) -> [PASS][16] +20 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][17] ([fdo#99912]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl1/igt@kms_setmode@basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-apl6/igt@kms_setmode@basic.html

  
#### Warnings ####

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-random:
    - shard-apl:          [SKIP][19] ([fdo#109271]) -> [INCOMPLETE][20] ([fdo#103927])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-512x170-random.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-512x170-random.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (9 -> 5)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3076
  * Piglit: piglit_4509 -> None

  CI_DRM_6162: d35e150f090fed2b37052ace606850ed7780c34d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3076: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3076/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/prime_busy: Increase timeout to mind pre-silicon.

[Katarzyna Dec]

On Wed, May 29, 2019 at 03:53:32PM +0200, Tomasz Lis wrote:
> From: "Lis, Tomasz" <tomasz.lis@intel.com>
> 
> On silicon, simple submission is finished much faster than in a second.
> But for pre-silicon, it is not always the case. Six seconds should be
> enough though.
> 
> Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
> Cc: Mrzyglod Daniel T <daniel.t.mrzyglod@intel.com>
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>  tests/prime_busy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/prime_busy.c b/tests/prime_busy.c
> index a82acbdb..8e0f3ca6 100644
> --- a/tests/prime_busy.c
> +++ b/tests/prime_busy.c
> @@ -147,7 +147,7 @@ static void busy(int fd, unsigned ring, unsigned flags)
>  	if ((flags & HANG) == 0) {
>  		*bbe = MI_BATCH_BUFFER_END;
>  		__sync_synchronize();
> -		timeout = 1;
> +		timeout = 6;
Here you are changing timeout for all configurations that can be used -
simulation or HW and for other HW generations. I suggest we use something like:
 if (igt_run_in_simulation()) {
	timeout = 6;
 } else {
	timeout = 1;
 }

This wil allow to preserve scenario for non-simulation environment.

Kasia
>  	}
>  
>  	/* Calling busy in a loop should be enough to flush the rendering */
> -- 
> 2.14.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev