[igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[Mika Kahola]

Kernel doesn't support Y or Yf tiling for interlaced modes. In kms_flip_tiling test case
we are missing such a check. Let's add a requirement that whenever we try to do flip with Y/Yf
tiling, we ensure that we have non-interlaced mode selected.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_flip_tiling.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index d1e6687f..582af53c 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -75,6 +75,14 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
 	igt_output_set_pipe(output, pipe);
 
 	mode = igt_output_get_mode(output);
+
+	/* Interlaced modes don't support Y/Yf tiling */
+	if (tiling[0] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
+	    tiling[0] == LOCAL_I915_FORMAT_MOD_Yf_TILED ||
+	    tiling[1] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
+	    tiling[1] == LOCAL_I915_FORMAT_MOD_Yf_TILED)
+		igt_require(!(mode->flags & DRM_MODE_FLAG_INTERLACE));
+
 	primary = igt_output_get_plane(output, 0);
 
 	width = mode->hdisplay;
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[Patchwork]

== Series Details ==

Series: tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling
URL   : https://patchwork.freedesktop.org/series/61324/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6162 -> IGTPW_3073
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61324/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3073 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/fi-blb-e6850/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/fi-blb-e6850/igt@i915_module_load@reload.html

  * igt@i915_selftest@live_contexts:
    - fi-hsw-peppy:       [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/fi-hsw-peppy/igt@i915_selftest@live_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/fi-hsw-peppy/igt@i915_selftest@live_contexts.html

  
#### Possible fixes ####

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#109483] / [fdo#109635 ]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (45 -> 40)
------------------------------

  Missing    (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3073

  CI_DRM_6162: d35e150f090fed2b37052ace606850ed7780c34d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3073: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[Patchwork]

== Series Details ==

Series: tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling
URL   : https://patchwork.freedesktop.org/series/61324/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6162_full -> IGTPW_3073_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61324/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3073_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vcs0-s3:
    - shard-kbl:          [PASS][1] -> [INCOMPLETE][2] ([fdo#103665])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl6/igt@gem_ctx_isolation@vcs0-s3.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-kbl4/igt@gem_ctx_isolation@vcs0-s3.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl5/igt@i915_suspend@sysfs-reader.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-apl7/igt@i915_suspend@sysfs-reader.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][5] -> [FAIL][6] ([fdo#103355])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_flip@2x-plain-flip-ts-check-interruptible:
    - shard-hsw:          [PASS][7] -> [SKIP][8] ([fdo#109271]) +13 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-hsw5/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl2/igt@kms_flip@flip-vs-suspend.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-kbl6/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_flip@plain-flip-ts-check:
    - shard-glk:          [PASS][11] -> [FAIL][12] ([fdo#100368])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-glk2/igt@kms_flip@plain-flip-ts-check.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-glk8/igt@kms_flip@plain-flip-ts-check.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#103167])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-glk8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][15] -> [FAIL][16] ([fdo#99912])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl3/igt@kms_setmode@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-kbl4/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-apl:          [DMESG-WARN][17] ([fdo#108566]) -> [PASS][18] +5 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [FAIL][19] ([fdo#108686]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-kbl3/igt@gem_tiled_swapping@non-threaded.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-kbl2/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_flip@2x-plain-flip-interruptible:
    - shard-hsw:          [SKIP][21] ([fdo#109271]) -> [PASS][22] +26 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6162/shard-hsw1/igt@kms_flip@2x-plain-flip-interruptible.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/shard-hsw4/igt@kms_flip@2x-plain-flip-interruptible.html

  
  [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (9 -> 5)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3073
  * Piglit: piglit_4509 -> None

  CI_DRM_6162: d35e150f090fed2b37052ace606850ed7780c34d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3073: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3073/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[Ville Syrjälä]

On Wed, May 29, 2019 at 03:45:06PM +0300, Mika Kahola wrote:
> Kernel doesn't support Y or Yf tiling for interlaced modes. In kms_flip_tiling test case
> we are missing such a check. Let's add a requirement that whenever we try to do flip with Y/Yf
> tiling, we ensure that we have non-interlaced mode selected.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  tests/kms_flip_tiling.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index d1e6687f..582af53c 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -75,6 +75,14 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
>  	igt_output_set_pipe(output, pipe);
>  
>  	mode = igt_output_get_mode(output);
> +
> +	/* Interlaced modes don't support Y/Yf tiling */
> +	if (tiling[0] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> +	    tiling[0] == LOCAL_I915_FORMAT_MOD_Yf_TILED ||
> +	    tiling[1] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> +	    tiling[1] == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> +		igt_require(!(mode->flags & DRM_MODE_FLAG_INTERLACE));
> +

Any test using Y/Yf could hit this. But can't really think of
generic place that could handle this (apart from TEST_ONLY
which is probably how some tests would skip this).

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	primary = igt_output_get_plane(output, 0);
>  
>  	width = mode->hdisplay;
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

[Kahola, Mika]

On Fri, 2019-05-31 at 15:11 +0300, Ville Syrjälä wrote:
> On Wed, May 29, 2019 at 03:45:06PM +0300, Mika Kahola wrote:
> > Kernel doesn't support Y or Yf tiling for interlaced modes. In
> > kms_flip_tiling test case
> > we are missing such a check. Let's add a requirement that whenever
> > we try to do flip with Y/Yf
> > tiling, we ensure that we have non-interlaced mode selected.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >  tests/kms_flip_tiling.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> > index d1e6687f..582af53c 100644
> > --- a/tests/kms_flip_tiling.c
> > +++ b/tests/kms_flip_tiling.c
> > @@ -75,6 +75,14 @@ test_flip_tiling(data_t *data, enum pipe pipe,
> > igt_output_t *output, uint64_t ti
> >  	igt_output_set_pipe(output, pipe);
> >  
> >  	mode = igt_output_get_mode(output);
> > +
> > +	/* Interlaced modes don't support Y/Yf tiling */
> > +	if (tiling[0] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> > +	    tiling[0] == LOCAL_I915_FORMAT_MOD_Yf_TILED ||
> > +	    tiling[1] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> > +	    tiling[1] == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> > +		igt_require(!(mode->flags & DRM_MODE_FLAG_INTERLACE));
> > +
> 
> Any test using Y/Yf could hit this. But can't really think of
> generic place that could handle this (apart from TEST_ONLY
> which is probably how some tests would skip this).
That's true. Maybe we could create a library routine to check these. 

Thanks for the review!

The patch is now pushed to IGT.

> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> >  	primary = igt_output_get_plane(output, 0);
> >  
> >  	width = mode->hdisplay;
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev