[igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

I missed these when sprinkling the memsets. Using stack garbage as the
aux surface state isn't a good idea. Causes kms_front_buffer_tracking
to fail on skl+.

Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index ebae915113da..c7d5770dca28 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 	drm_intel_bo *src, *dst;
 	uint32_t devid = intel_get_drm_devid(fd);
 	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
-	struct igt_buf src_buf, dst_buf;
+	struct igt_buf src_buf = {}, dst_buf = {};
 	struct intel_batchbuffer *batch;
 	uint32_t tiling, swizzle;
 	struct buf_data tmp;
-- 
2.16.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Chris Wilson]

Quoting Ville Syrjala (2018-07-06 17:39:40)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

And I'm still being lazy and only reviewing the patch in front of me...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Antonio Argenziano]

On 06/07/18 09:39, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   lib/igt_draw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index ebae915113da..c7d5770dca28 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>   	drm_intel_bo *src, *dst;
>   	uint32_t devid = intel_get_drm_devid(fd);
>   	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
> -	struct igt_buf src_buf, dst_buf;
> +	struct igt_buf src_buf = {}, dst_buf = {};
>   	struct intel_batchbuffer *batch;
>   	uint32_t tiling, swizzle;
>   	struct buf_data tmp;
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

I missed these when sprinkling the memsets. Using stack garbage as the
aux surface state isn't a good idea. Causes kms_front_buffer_tracking
to fail on skl+.

Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index ebae915113da..c7d5770dca28 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 	drm_intel_bo *src, *dst;
 	uint32_t devid = intel_get_drm_devid(fd);
 	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
-	struct igt_buf src_buf, dst_buf;
+	struct igt_buf src_buf = {}, dst_buf = {};
 	struct intel_batchbuffer *batch;
 	uint32_t tiling, swizzle;
 	struct buf_data tmp;
-- 
2.16.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Ville Syrjälä]

On Mon, Jun 24, 2019 at 06:14:18PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

bash history fail. Please ignore.

> ---
>  lib/igt_draw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index ebae915113da..c7d5770dca28 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>  	drm_intel_bo *src, *dst;
>  	uint32_t devid = intel_get_drm_devid(fd);
>  	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
> -	struct igt_buf src_buf, dst_buf;
> +	struct igt_buf src_buf = {}, dst_buf = {};
>  	struct intel_batchbuffer *batch;
>  	uint32_t tiling, swizzle;
>  	struct buf_data tmp;
> -- 
> 2.16.4

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_draw: Zero initalize the igt_bufs (rev2)

[Patchwork]

== Series Details ==

Series: lib/igt_draw: Zero initalize the igt_bufs (rev2)
URL   : https://patchwork.freedesktop.org/series/46083/
State : failure

== Summary ==

Series 46083 revision 2 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs

[Ser, Simon]

On Mon, 2019-06-24 at 18:14 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I missed these when sprinkling the memsets. Using stack garbage as the
> aux surface state isn't a good idea. Causes kms_front_buffer_tracking
> to fail on skl+.
> 
> Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
>  lib/igt_draw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index ebae915113da..c7d5770dca28 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>  	drm_intel_bo *src, *dst;
>  	uint32_t devid = intel_get_drm_devid(fd);
>  	igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
> -	struct igt_buf src_buf, dst_buf;
> +	struct igt_buf src_buf = {}, dst_buf = {};
>  	struct intel_batchbuffer *batch;
>  	uint32_t tiling, swizzle;
>  	struct buf_data tmp;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev