public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/i915_pm_sseu: Don't try to get enabled subslices if it's not there
@ 2019-07-24  8:38 Arkadiusz Hiler
  2019-07-24  8:49 ` Lionel Landwerlin
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Arkadiusz Hiler @ 2019-07-24  8:38 UTC (permalink / raw)
  To: igt-dev

The debugfs contains "Enabled SliceX subslices:" line only if a given
slice is enabled. If we try to dbg_get_status() with everything shut
down we will get a confusing assertion failure:

CRITICAL: Test assertion failure function dbg_get_int, file ../tests/i915/i915_pm_sseu.c:120:
CRITICAL: Failed assertion: pos != NULL

To fix that let's just read the enabled subslices if the line is there,

Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110593
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/i915/i915_pm_sseu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_sseu.c b/tests/i915/i915_pm_sseu.c
index 252df7d3..0b936982 100644
--- a/tests/i915/i915_pm_sseu.c
+++ b/tests/i915/i915_pm_sseu.c
@@ -199,7 +199,7 @@ dbg_get_status(struct status *stat)
 	if (dbg_has_line(first, last, "Enabled Subslice Per Slice:")) {
 		stat->hw.subslice_per =
 			dbg_get_int(first, last, "Enabled Subslice Per Slice:");
-	} else {
+	} else if (dbg_has_line(first, last, "Enabled Slice0 subslices:")) {
 		stat->hw.subslice_per =
 			dbg_get_int(first, last, "Enabled Slice0 subslices:");
 	}
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-07-25 12:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24  8:38 [igt-dev] [PATCH i-g-t] tests/i915_pm_sseu: Don't try to get enabled subslices if it's not there Arkadiusz Hiler
2019-07-24  8:49 ` Lionel Landwerlin
2019-07-24  8:53 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-07-24  9:10 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-07-24 12:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-07-25 12:42 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox